New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 632419 link

Starred by 2 users
Status: Fixed
Owner:
est...@chromium.org
Closed: Aug 2016
Cc:
█ mab@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Secure time histograms: collapse NetworkTimeTracker.UpdateTimeFetchSucceeded and NetworkTimeTracker.UpdateTimeFetchAttempted if they are the same

Project Member Reported by est...@chromium.org, Jul 28 2016 
Per discussion at https://codereview.chromium.org/2176373003/diff/1/components/network_time/network_time_tracker.cc#newcode391, if Canary doesn't show any significant difference between these two histograms, we can probably just collapse them into one.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9a6bfb3670adb37cb84b14d13a1b4e46fa3e44e

commit f9a6bfb3670adb37cb84b14d13a1b4e46fa3e44e
Author: estark <estark@chromium.org>
Date: Mon Aug 15 20:24:20 2016

Remove NetworkTimeTracker.UpdateTimeFetchAttempted histogram

As mab@ predicted in
https://codereview.chromium.org/2176373003/diff/1/components/network_time/network_time_tracker.cc#newcode391,
NetworkTimeTracker.UpdateTimeFetchAttempted does not show anything
interesting happening on Canary, so the UpdateTimeFetchValid and
UpdateTimeFetchFailed histograms should be enough for our purposes.

BUG= 632419 

Review-Url: https://codereview.chromium.org/2232663002
Cr-Commit-Position: refs/heads/master@{#412034}

[modify] https://crrev.com/f9a6bfb3670adb37cb84b14d13a1b4e46fa3e44e/components/network_time/network_time_tracker.cc
[modify] https://crrev.com/f9a6bfb3670adb37cb84b14d13a1b4e46fa3e44e/components/network_time/network_time_tracker_unittest.cc
[modify] https://crrev.com/f9a6bfb3670adb37cb84b14d13a1b4e46fa3e44e/tools/metrics/histograms/histograms.xml

Comment 2 by est...@chromium.org, Aug 15 2016

Labels: M-54
Status: Fixed (was: Assigned)

Comment 3 by lafo...@chromium.org, Dec 9 2016

Components: -Security>UX
Labels: Team-Security-UX
Security>UX component is deprecated in favor of the Team-Security-UX label
►

Sign in to add a comment