Update mosys eventlog recovery reason reporting |
||||
Issue descriptionmosys translates eventlog recovery reason numbers into readable strings with a table. This table is heavily out of date... some reasons were added for vboot2 that need to be reflected there. More importantly, if a recovery reason doesn't get recognized, it should print the raw number in addition to "Unknown" to avoid hiding information (like in issue 615662).
,
Sep 30 2016
This keeps causing problems with analysis of feedback reports. Katie, can you triage?
,
Sep 30 2016
shelley - do you have time?
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/2424a640d23df73b3f00f384992a726d408448b2 commit 2424a640d23df73b3f00f384992a726d408448b2 Author: Shelley Chen <shchen@chromium.org> Date: Fri Sep 30 22:41:16 2016 mosys: Add recovery code when reason not found Currently, when mosys can't determine the recovery reason it returns "Unknown", which is not helpful when debugging. Appending recovery reason code to this string, so it will return "Unknown reason: 0x2d" or the like. BUG= chromium:632413 BRANCH=None TEST=mosys eventlog list Change-Id: I30a3442357c28f3572af30d0fda61783dc4b9ffc Signed-off-by: Shelley Chen <shchen@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/391048 Reviewed-by: Julius Werner <jwerner@chromium.org> [modify] https://crrev.com/2424a640d23df73b3f00f384992a726d408448b2/lib/eventlog/elog.c [modify] https://crrev.com/2424a640d23df73b3f00f384992a726d408448b2/include/lib/elog.h
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/6fe1d39a636c509ed6d60b36229ca53c8f904049 commit 6fe1d39a636c509ed6d60b36229ca53c8f904049 Author: Shelley Chen <shchen@chromium.org> Date: Mon Oct 03 18:24:25 2016 mosys: adding in missing reason codes for vbnv Went through vboot_reference/firmware/lib/vboot_display.c to update the recovery codes in elog.c/h. In particular, 0x2B-0x2F, 0x5C-0x5E, 0xC2-0xC3. BUG= chromium:632413 BRANCH=None TEST=mosys eventlog list Change-Id: I17bc0611bb988a30a154111d8d5eaab3b0507857 Signed-off-by: Shelley Chen <shchen@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/391168 Tested-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> [modify] https://crrev.com/6fe1d39a636c509ed6d60b36229ca53c8f904049/lib/eventlog/elog.c [modify] https://crrev.com/6fe1d39a636c509ed6d60b36229ca53c8f904049/include/lib/elog.h
,
Oct 5 2016
All bugs have landed. Julius, let me know if you see a problem with this in the future. |
||||
►
Sign in to add a comment |
||||
Comment 1 by jwer...@chromium.org
, Aug 11 2016