New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632405 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: native breakpoint scopes break with blackboxing

Project Member Reported by dgozman@chromium.org, Jul 28 2016

Issue description

This includes:
- interaction with RequestStepFrame and willExecuteScript;
- nested scopes break all assumptions.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12e4094f1942c015925e406c7ce86c9cdafea645

commit 12e4094f1942c015925e406c7ce86c9cdafea645
Author: dgozman <dgozman@chromium.org>
Date: Sat Jul 30 05:25:09 2016

[DevTools] Pass error object when reporting exceptions.

We used to just extract string from the error, which didn't allow to inspect the error object itself. Now we pass the thrown object as a RemoteObject.

This also unifies exceptions with promise rejections in V8Debugger.

BUG= 631162 , 632405 

Review-Url: https://codereview.chromium.org/2170263002
Cr-Commit-Position: refs/heads/master@{#408863}

[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/chrome/test/data/extensions/api_test/uncaught_exception_logging/content_script.js
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/chrome/test/data/extensions/api_test/uncaught_exception_logging/extension_page.js
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-exception-source-url-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-stack-overflow-source-url-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/console-log-eval-syntax-error-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/console-log-syntax-error-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/console-log-syntax-error.html
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/console-message-from-inline-with-url-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/console-stack-overflow-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-in-eval-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/console-worker-nested-imports-syntax-error-expected.txt
[add] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/exception-objects-expected.txt
[add] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/exception-objects.html
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/function-name-in-console-message-stack-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-in-console-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/testing/NullExecutionContext.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/web/WebSharedWorkerImpl.h

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/56bf7dbdaf6cb413390d56f2e595d1fbaecc9b30

commit 56bf7dbdaf6cb413390d56f2e595d1fbaecc9b30
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Wed Feb 08 01:42:54 2017

[inspector] support for nested scheduled breaks

In current implementation we don't support nested scheduled break at all. If one break was scheduled inside another and second one doesn't produce actual break (execution was in blackboxed code or no JavaScript was executed) then second one will clear first scheduled break even if any not blackboxed JavaScript will be executed later.

Ambiguous break reason is added for the case when we have more then one scheduled reason. "auxData" in this case contains object with array of { reason: reason, auxData: auxData } objects for each reason in 'reasons' property.

BUG= chromium:632405 

Review-Url: https://codereview.chromium.org/2678313002
Cr-Commit-Position: refs/heads/master@{#43021}

[modify] https://crrev.com/56bf7dbdaf6cb413390d56f2e595d1fbaecc9b30/src/inspector/js_protocol.json
[modify] https://crrev.com/56bf7dbdaf6cb413390d56f2e595d1fbaecc9b30/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/56bf7dbdaf6cb413390d56f2e595d1fbaecc9b30/src/inspector/v8-debugger-agent-impl.h
[add] https://crrev.com/56bf7dbdaf6cb413390d56f2e595d1fbaecc9b30/test/inspector/debugger/framework-nested-scheduled-break-expected.txt
[add] https://crrev.com/56bf7dbdaf6cb413390d56f2e595d1fbaecc9b30/test/inspector/debugger/framework-nested-scheduled-break.js
[modify] https://crrev.com/56bf7dbdaf6cb413390d56f2e595d1fbaecc9b30/test/inspector/debugger/inspector-break-api.js
[modify] https://crrev.com/56bf7dbdaf6cb413390d56f2e595d1fbaecc9b30/test/inspector/inspector-test.cc

Status: Fixed (was: Assigned)

Sign in to add a comment