New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632401 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Add unit tests for MediaCodecLoop

Project Member Reported by liber...@chromium.org, Jul 28 2016

Issue description


add unit tests for MediaCodecLoop.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7014d6d056a3a524c123b5886065a6f1e2722c09

commit 7014d6d056a3a524c123b5886065a6f1e2722c09
Author: liberato <liberato@chromium.org>
Date: Wed Aug 10 17:45:47 2016

MediaCodecLoop unit tests.

This CL adds unit tests for MediaCodecLoop that compile and run
anywhere.  We do this, so that we don't accidentally take any
dependencies on the android runtime, e.g., BuildInfo.  It does
this with new build targets.

For example, we know that media_codec_loop.cc does not depend on
JNI to run, and doesn't care if (for example) MediaCodec is broken
today on the particular device on which the tests run.

Moved MediaCodecBridge and MediaCodecLoop to android/anywhere, which
builds anywhere.  For example, building media_unittests on linux will
include tests for MediaCodecLoop.

Note that building non-unittest targets on non-android platforms will
not include extra code.

BUG= 632401 

Review-Url: https://codereview.chromium.org/2132653002
Cr-Commit-Position: refs/heads/master@{#411075}

[modify] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/base/BUILD.gn
[modify] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/base/android/BUILD.gn
[modify] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/base/android/java/src/org/chromium/media/MediaCodecUtil.java
[modify] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/base/android/media_codec_bridge.cc
[modify] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/base/android/media_codec_bridge.h
[add] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/base/android/media_codec_direction.h
[modify] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/base/android/media_codec_loop.cc
[modify] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/base/android/media_codec_loop.h
[modify] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/base/android/media_codec_loop_unittest.cc
[modify] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/base/android/media_codec_util.h
[add] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/base/android/mock_media_codec_bridge.cc
[add] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/base/android/mock_media_codec_bridge.h
[modify] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/base/android/ndk_media_codec_bridge.cc
[modify] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/base/android/sdk_media_codec_bridge.cc
[modify] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/base/decrypt_config.h
[add] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/base/subsample_entry.h
[modify] https://crrev.com/7014d6d056a3a524c123b5886065a6f1e2722c09/media/filters/android/media_codec_audio_decoder.cc

Status: Fixed (was: Started)

Sign in to add a comment