New issue
Advanced search Search tips

Issue 632390 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 807286

Blocking:
issue 645094



Sign in to add a comment

v8 GN build does not support BigEndian target (mips, mips64)

Project Member Reported by js...@chromium.org, Jul 28 2016

Issue description

Gyp supports Big Endian targets (mips, mips64), but GN does not yet. 


 

Comment 1 by js...@chromium.org, Jul 28 2016

Blocking: -v8:4828
Components: Build
Blocking: -631440 645094

Comment 4 by wqing...@gmail.com, Jul 11 2017

GN supports 32-bits LittleEndian targets (mipsel), but GN does not supports 64-bits mips64el. 
I think support for big endian landed already (associated to some other bug). So the only remaining thing is to support mips64el? Maybe change this CL desc?

Comment 7 by wqing...@gmail.com, Jul 11 2017

I new  issue 740468 
Blockedon: 807286
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ae1fbc0dc502ffab2b8c0f4715562f8c8e847920

commit ae1fbc0dc502ffab2b8c0f4715562f8c8e847920
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Jan 31 14:38:43 2018

[build] Enable downloading mips toolchain via runhooks

This downloads the mips tool chain into tools/mips_toolchain via
runhooks if the flag download_mips_toolchain is specified for
gclient.

The currently uploaded version is 2015/1/7.

Bug:  chromium:632390 
Change-Id: Ied396d1a980db962773a96e9dadd3f282c7541c0
Reviewed-on: https://chromium-review.googlesource.com/892864
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50999}
[modify] https://crrev.com/ae1fbc0dc502ffab2b8c0f4715562f8c8e847920/.gitignore
[modify] https://crrev.com/ae1fbc0dc502ffab2b8c0f4715562f8c8e847920/DEPS
[add] https://crrev.com/ae1fbc0dc502ffab2b8c0f4715562f8c8e847920/tools/mips_toolchain.tar.gz.sha1

Cc: -machenb...@chromium.org
Owner: machenb...@chromium.org
Status: Fixed (was: Untriaged)
We can now build mips (BE) with GN. Manually verified that the builds work on our mips boards (we have always built without snapshot and without i18n support).
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8f7ccb6c1e7fb321d280c405b8893838c8bbadab

commit 8f7ccb6c1e7fb321d280c405b8893838c8bbadab
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Feb 08 08:25:47 2018

[build] Support mips toolchain for cross-compiling

This enables compiling V8 stand-alone for mips (big endian)
on an ia32 host with gn args:

custom_toolchain="//:mips-bundled"
v8_use_snapshot=false
v8_enable_i18n_support=false
icu_use_data_file=false
is_debug=false
target_cpu="mips"

Bug:  chromium:632390 
Change-Id: I0b59126d742a2979dd0fcbcdd3a574008a09479a
Reviewed-on: https://chromium-review.googlesource.com/904990
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51167}
[add] https://crrev.com/8f7ccb6c1e7fb321d280c405b8893838c8bbadab/tools/toolchain/BUILD.gn

Sign in to add a comment