New issue
Advanced search Search tips

Issue 632382 link

Starred by 3 users
Status: Verified
Owner:
tommycli@chromium.org
Closed: Aug 2016
Cc:
tommycli@chromium.org
sdantul...@chromium.org
finnur@chromium.org
dbeam@chromium.org
michae...@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 608115



Sign in to add a comment

MD Settings: routing: support internet/networkDetail?guild=12345678

Project Member Reported by steve...@chromium.org, Jul 28 2016 
We need to support a way to navigate directly to the networkDetail page for a specific network, e.g.:

chrome://md-settings/internet/networkDetail?guid=12345678

Notes:

Currently, even though routes.js has the following:

  r.INTERNET = r.BASIC.createSection('/internet', 'internet');
  r.NETWORK_DETAIL = r.INTERNET.createChild('/networkDetail', 'network-detail');

the route to the network detail page appears as:

chrome://md-settings/networkDetail


The old settings url for a particular network is:

chrome://settings/internet?guid=12345678

It would be nice to be able to support that route as well.

Comment 1 by steve...@chromium.org, Jul 28 2016 

Note: I am happy to work on this once the routing is otherwise stable.

Comment 2 by tommycli@chromium.org, Jul 28 2016 

Hey Steven, I support that. It shouldn't be too bad to add support for dynamic parameters to routes.

Comment 3 by steve...@chromium.org, Jul 28 2016 

Great! Let me know when it is ready and how internet_detail_page should handle it. The page has a 'guid' property that just needs to get set to the ?guid= property.

Comment 4 by tommycli@chromium.org, Jul 30 2016

Cc: finnur@chromium.org tommycli@chromium.org
 Issue 629960  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad273fdd66e17f67ae992933dd9438a58554f92e

commit ad273fdd66e17f67ae992933dd9438a58554f92e
Author: tommycli <tommycli@chromium.org>
Date: Wed Aug 03 19:56:35 2016

Settings Router Refactor: Support dynamic parameters

BUG= 632382 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2206613003
Cr-Commit-Position: refs/heads/master@{#409601}

[modify] https://crrev.com/ad273fdd66e17f67ae992933dd9438a58554f92e/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/ad273fdd66e17f67ae992933dd9438a58554f92e/chrome/test/data/webui/settings/cr_settings_browsertest.js

Comment 6 by tommycli@chromium.org, Aug 3 2016

Status: Fixed (was: Assigned)
I added support for dynamic query params in above patch.

Let me know if it's inadequate for your guys' needs. Cheers.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b6b548e6ebc2374818b61e14cd315add717f71a

commit 5b6b548e6ebc2374818b61e14cd315add717f71a
Author: tommycli <tommycli@chromium.org>
Date: Sat Aug 06 00:26:59 2016

Settings Router Refactor: Kill settings-router.

Use RouteObserverBehavior everywhere instead.

BUG= 632382 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2210933004
Cr-Commit-Position: refs/heads/master@{#410228}

[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/about_page/about_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/advanced_page/advanced_page.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/advanced_page/advanced_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/advanced_page/compiled_resources2.gyp
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/appearance_page/appearance_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/basic_page/basic_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/basic_page/compiled_resources2.gyp
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/default_browser_page/default_browser_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/device_page/device_page.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/device_page/device_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/on_startup_page/on_startup_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/people_page/compiled_resources2.gyp
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/people_page/quick_unlock_authenticate.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/people_page/quick_unlock_choose_method.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/people_page/quick_unlock_setup_pin.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/printing_page/printing_page.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/printing_page/printing_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/search_page/search_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/settings_main/compiled_resources2.gyp
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/settings_menu/compiled_resources2.gyp
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/settings_page/compiled_resources2.gyp
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/settings_page/main_page_behavior.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/settings_page/main_page_behavior.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
[delete] https://crrev.com/ae875419ff203324cd94c335695a7f9c0081e197/chrome/browser/resources/settings/settings_page/settings_router.html
[delete] https://crrev.com/ae875419ff203324cd94c335695a7f9c0081e197/chrome/browser/resources/settings/settings_page/settings_router.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/settings_page/settings_section.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/site_settings/all_sites.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/site_settings/all_sites.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/site_settings/site_settings_category.html
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/site_settings/site_settings_category.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/test/data/webui/settings/basic_page_browsertest.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/test/data/webui/settings/device_page_tests.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/test/data/webui/settings/languages_page_browsertest.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/test/data/webui/settings/people_page_sync_page_test.js
[modify] https://crrev.com/5b6b548e6ebc2374818b61e14cd315add717f71a/chrome/test/data/webui/settings/site_list_tests.js
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf72a2e8783b5438ed796f78a1e3dcd31afa23d0

commit cf72a2e8783b5438ed796f78a1e3dcd31afa23d0
Author: tommycli <tommycli@chromium.org>
Date: Tue Aug 09 16:08:42 2016

Settings Router Refactor: Remove subpage-back.

BUG= 632382 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2226003002
Cr-Commit-Position: refs/heads/master@{#410692}

[modify] https://crrev.com/cf72a2e8783b5438ed796f78a1e3dcd31afa23d0/chrome/browser/resources/settings/device_page/device_page.js
[modify] https://crrev.com/cf72a2e8783b5438ed796f78a1e3dcd31afa23d0/chrome/browser/resources/settings/internet_page/compiled_resources2.gyp
[modify] https://crrev.com/cf72a2e8783b5438ed796f78a1e3dcd31afa23d0/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/cf72a2e8783b5438ed796f78a1e3dcd31afa23d0/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/cf72a2e8783b5438ed796f78a1e3dcd31afa23d0/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
[modify] https://crrev.com/cf72a2e8783b5438ed796f78a1e3dcd31afa23d0/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
[modify] https://crrev.com/cf72a2e8783b5438ed796f78a1e3dcd31afa23d0/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/cf72a2e8783b5438ed796f78a1e3dcd31afa23d0/chrome/browser/resources/settings/site_settings/site_details.js
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce61a592e45865d01c17b36c86cbaf347dc5899

commit 1ce61a592e45865d01c17b36c86cbaf347dc5899
Author: tommycli <tommycli@chromium.org>
Date: Fri Aug 12 16:19:54 2016

Settings Router Refactor: Replace route.subpage usage with route.path

The neon-animated-pages elements that previously had subpage ids now use the path as ids. (including the slashes)

BUG= 632382 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2224163002
Cr-Commit-Position: refs/heads/master@{#411668}

[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/a11y_page/a11y_page.html
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/device_page/device_page.html
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/printing_page/printing_page.html
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/settings_page/main_page_behavior.js
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/settings_page/settings_animated_pages.html
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/test/data/webui/settings/device_page_tests.js
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/test/data/webui/settings/languages_page_browsertest.js
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/test/data/webui/settings/route_tests.js
[modify] https://crrev.com/1ce61a592e45865d01c17b36c86cbaf347dc5899/chrome/test/data/webui/settings/settings_page_browsertest.js
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a114fa87c2ee8e854f12b371a29d8a0e7da39788

commit a114fa87c2ee8e854f12b371a29d8a0e7da39788
Author: tommycli <tommycli@chromium.org>
Date: Fri Aug 12 17:43:42 2016

Settings Router Refactor: Fix typo in fonts subpage route.

BUG= 632382 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2240873002
Cr-Commit-Position: refs/heads/master@{#411695}

[modify] https://crrev.com/a114fa87c2ee8e854f12b371a29d8a0e7da39788/chrome/browser/resources/settings/appearance_page/appearance_page.html
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce37c93fb3538e1ebe6b84fcf370871c50401ebe

commit ce37c93fb3538e1ebe6b84fcf370871c50401ebe
Author: tommycli <tommycli@chromium.org>
Date: Mon Aug 15 18:31:48 2016

Settings Router Refactor: Normalize URL only for main settings page.

Normalize URL in cr-settings.created only, not when child elements are
directly loaded.

i.e., URL normalized for chrome://md-settings/foo/bar but not for
chrome://md-settings/people_page/people_page.html

Also fixes a bug where the URL state is pushed rather than replaced.

BUG= 632382 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2231203002
Cr-Commit-Position: refs/heads/master@{#411993}

[modify] https://crrev.com/ce37c93fb3538e1ebe6b84fcf370871c50401ebe/chrome/browser/resources/settings/compiled_resources2.gyp
[modify] https://crrev.com/ce37c93fb3538e1ebe6b84fcf370871c50401ebe/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/ce37c93fb3538e1ebe6b84fcf370871c50401ebe/chrome/browser/resources/settings/settings.html
[modify] https://crrev.com/ce37c93fb3538e1ebe6b84fcf370871c50401ebe/chrome/browser/resources/settings/settings.js
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67d17aee41b895d81c6e6e7d7ff33690bee9f74e

commit 67d17aee41b895d81c6e6e7d7ff33690bee9f74e
Author: tommycli <tommycli@chromium.org>
Date: Mon Aug 15 18:34:14 2016

Settings Router Refactor: Normalize URL only for main settings page.

Normalize URL in cr-settings.created only, not when child elements are
directly loaded.

i.e., URL normalized for chrome://md-settings/foo/bar but not for
chrome://md-settings/people_page/people_page.html

Also fixes a bug where the URL state is pushed rather than replaced.

BUG= 632382 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2231203002
Cr-Commit-Position: refs/heads/master@{#411995}

[modify] https://crrev.com/67d17aee41b895d81c6e6e7d7ff33690bee9f74e/chrome/browser/resources/settings/compiled_resources2.gyp

Comment 15 by patricia@chromium.org, Aug 29 2016

Labels: VerifyIn-54

Comment 16 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 17 by sdantul...@chromium.org, Oct 21 2016

Cc: sdantul...@chromium.org
Labels: Needs-Feedback
@tommycli Could you please provide repro steps for this bug? Where to look for guid of a specific network?

Comment 18 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 19 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 20 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 21 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 22 by sdantul...@chromium.org, May 8 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment