md-settings regression 'Default theme' no longer differentiates between Classic theme and GTK+ theme
Reported by
vanantwe...@gmail.com,
Jul 28 2016
|
||||||||||||||||
Issue descriptionIn the old settings page, when you (on linux) went to the appearance page, it showed a button for the default (ugly blue) theme and the system integrated GTK+ theme. Withing md-settings, only a 'reset to default' is available
,
Aug 2 2016
The template wasn't working at that time :( The version should be 54.0.2810.2 (Official Build) dev (64-bit)
,
Aug 10 2016
Thank you for providing more feedback. Adding requester "tbuckley@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 16 2016
@dbeam can you confirm that this is available on Chrome for Linux? The version reported came out after the original bug was marked as fixed (July 28)
,
Aug 16 2016
tbuckely@: bug 624194 is different see screenshot: there are 3 things to change in old options, and only 2 things in MD settings
,
Aug 16 2016
Is there a difference between "Use GTK+ theme" and "Use system title bar and borders"?
,
Aug 16 2016
Yes, there is a difference the system bar can move the minimize ... buttons out of chrome and move them to the top of the screen in unity. The GTK+ theme removes the ugly blue and replaces this by some greyish theme on my pc
,
Aug 16 2016
yes
,
Aug 16 2016
note: I'm using xmonad, in unity these differences are likely more pronounced
,
Aug 29 2016
Issue 641715 has been merged into this issue.
,
Sep 6 2016
Issue 643841 has been merged into this issue.
,
Sep 20 2016
Issue 648100 has been merged into this issue.
,
Sep 22 2016
,
Sep 26 2016
Issue 650256 has been merged into this issue.
,
Sep 26 2016
,
Oct 3 2016
Issue 646920 has been merged into this issue.
,
Oct 4 2016
Adding GTK+ and Classic buttons https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW_Appearance-web-content.png%3Fz=width
,
Oct 13 2016
,
Oct 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/128f6569dc555f54ec1f09dd117ac73311597734 commit 128f6569dc555f54ec1f09dd117ac73311597734 Author: dbeam <dbeam@chromium.org> Date: Thu Oct 13 20:59:55 2016 MD Settings: allow changing to GTK+ theme on Linux R=dpapad@chromium.org BUG= 632376 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2413623004 Cr-Commit-Position: refs/heads/master@{#425149} [modify] https://crrev.com/128f6569dc555f54ec1f09dd117ac73311597734/chrome/app/settings_strings.grdp [modify] https://crrev.com/128f6569dc555f54ec1f09dd117ac73311597734/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/128f6569dc555f54ec1f09dd117ac73311597734/chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js [modify] https://crrev.com/128f6569dc555f54ec1f09dd117ac73311597734/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/128f6569dc555f54ec1f09dd117ac73311597734/chrome/browser/resources/settings/appearance_page/appearance_page.js [modify] https://crrev.com/128f6569dc555f54ec1f09dd117ac73311597734/chrome/browser/resources/settings/appearance_page/compiled_resources2.gyp [modify] https://crrev.com/128f6569dc555f54ec1f09dd117ac73311597734/chrome/browser/ui/webui/settings/appearance_handler.cc [modify] https://crrev.com/128f6569dc555f54ec1f09dd117ac73311597734/chrome/browser/ui/webui/settings/appearance_handler.h [modify] https://crrev.com/128f6569dc555f54ec1f09dd117ac73311597734/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/128f6569dc555f54ec1f09dd117ac73311597734/chrome/test/data/webui/settings/appearance_page_test.js
,
Oct 13 2016
I would generally call this fixed. I'm adding a small enhancement, but using GTK+ theme is easier again.
,
Oct 13 2016
,
Oct 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f2f534bbcf83f1a54d35bad3345e3b181da71ba commit 1f2f534bbcf83f1a54d35bad3345e3b181da71ba Author: dbeam <dbeam@chromium.org> Date: Fri Oct 14 01:15:36 2016 MD Settings: use theme homepage URLs when set R=dpapad@chromium.org BUG= 632376 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2414213002 Cr-Commit-Position: refs/heads/master@{#425227} [modify] https://crrev.com/1f2f534bbcf83f1a54d35bad3345e3b181da71ba/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/1f2f534bbcf83f1a54d35bad3345e3b181da71ba/chrome/browser/resources/settings/appearance_page/appearance_page.js |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by tbuck...@chromium.org
, Aug 2 2016