New issue
Advanced search Search tips

Issue 632361 link

Starred by 8 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment

[meta] Implement "NoStatePrefetch"

Project Member Reported by droger@chromium.org, Jul 28 2016

Issue description

This bug tracks the implementation of No-State Prefetch.

Design doc:
https://docs.google.com/document/d/16VCYGGWau483IMSxODpg5faZny1FJ6vNK2v-BuM5EhU
 

Comment 1 by pasko@chromium.org, Jul 28 2016

Labels: -Pri-3 Pri-2

Comment 2 by pasko@chromium.org, Jul 28 2016

Labels: Performance
Owner: pasko@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by droger@chromium.org, Jul 28 2016

Blockedon: 632367

Comment 4 by pasko@chromium.org, Jul 28 2016

Blockedon: 632368

Comment 5 by pasko@chromium.org, Jul 28 2016

Blockedon: 632402

Comment 6 by pasko@chromium.org, Jul 28 2016

Blockedon: 632404

Comment 7 by pasko@chromium.org, Jul 28 2016

Blockedon: 632406

Comment 8 by pasko@chromium.org, Jul 28 2016

Summary: [meta] Implement "No-State Prefetch" (was: Implement "No-State Prefetch")
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67b240c6628573aa3437e14fc82edcb7de78e944

commit 67b240c6628573aa3437e14fc82edcb7de78e944
Author: droger <droger@chromium.org>
Date: Wed Aug 03 11:50:27 2016

[Prerender] Change IPC from bool to enum for more prerender modes

This change is in preparation for adding a PreFetch mode to
prerendering.

BUG=632361

Review-Url: https://codereview.chromium.org/2179903005
Cr-Commit-Position: refs/heads/master@{#409494}

[modify] https://crrev.com/67b240c6628573aa3437e14fc82edcb7de78e944/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/67b240c6628573aa3437e14fc82edcb7de78e944/chrome/common/prerender_messages.h
[modify] https://crrev.com/67b240c6628573aa3437e14fc82edcb7de78e944/chrome/common/prerender_types.h
[modify] https://crrev.com/67b240c6628573aa3437e14fc82edcb7de78e944/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/67b240c6628573aa3437e14fc82edcb7de78e944/chrome/renderer/chrome_render_frame_observer.h
[modify] https://crrev.com/67b240c6628573aa3437e14fc82edcb7de78e944/chrome/renderer/plugins/chrome_plugin_placeholder.cc
[modify] https://crrev.com/67b240c6628573aa3437e14fc82edcb7de78e944/chrome/renderer/plugins/chrome_plugin_placeholder.h
[modify] https://crrev.com/67b240c6628573aa3437e14fc82edcb7de78e944/chrome/renderer/prerender/prerender_helper.cc
[modify] https://crrev.com/67b240c6628573aa3437e14fc82edcb7de78e944/chrome/renderer/prerender/prerender_helper.h

Blockedon: 638155
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04f065d8f4417c062ec53cbc7d27ed571e6736b2

commit 04f065d8f4417c062ec53cbc7d27ed571e6736b2
Author: droger <droger@chromium.org>
Date: Thu Aug 25 12:28:56 2016

Renderer-side changes for NoState Prefetch

NoState Prefetch design doc:
https://docs.google.com/document/d/16VCYGGWau483IMSxODpg5faZny1FJ6vNK2v-BuM5EhU

This CL is the first step for NoState Prefetch implementation
in the renderer.

The code added in this CL is not called yet (it will be called
only when the PREFETCH_ONLY enum is sent through IPC).

The prefetching is implemented in the HTMLDocumentParser.
When prefetching, the parser runs in single-thread mode.
When feeded with HTML input, it runs the preload scanner on
it, and stops without actually building or executing the page.

BUG=632361

Review-Url: https://codereview.chromium.org/2172613002
Cr-Commit-Position: refs/heads/master@{#414406}

[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/chrome/renderer/prerender/prerender_helper.cc
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/chrome/renderer/prerender/prerender_helper.h
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/chrome/renderer/prerender/prerenderer_client.cc
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/chrome/renderer/prerender/prerenderer_client.h
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/third_party/WebKit/Source/core/dom/DecodedDataDocumentParser.h
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/third_party/WebKit/Source/core/dom/DocumentParser.h
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/third_party/WebKit/Source/core/dom/ScriptableDocumentParser.h
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h
[add] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/third_party/WebKit/Source/core/html/parser/HTMLDocumentParserTest.cpp
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/third_party/WebKit/Source/core/html/parser/HTMLScriptRunnerHost.h
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/third_party/WebKit/Source/core/loader/PrerendererClient.h
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/third_party/WebKit/Source/web/PrerendererClientImpl.cpp
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/third_party/WebKit/Source/web/PrerendererClientImpl.h
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/third_party/WebKit/Source/web/tests/PrerenderingTest.cpp
[modify] https://crrev.com/04f065d8f4417c062ec53cbc7d27ed571e6736b2/third_party/WebKit/public/web/WebPrerendererClient.h

Blockedon: 641327

Comment 14 by pasko@chromium.org, Aug 30 2016

Blockedon: 642371
Blockedon: 643652
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/308308a95a348f446a25de9c9bd789c5a94c92c4

commit 308308a95a348f446a25de9c9bd789c5a94c92c4
Author: droger <droger@chromium.org>
Date: Mon Sep 12 12:38:50 2016

[NoStatePrefetch] Do not send responses to renderer in prefetch mode.

Only the main frame is sent, to allow running the preload scanner on it,
other resources are not.
The renderer does not need this data, and so this CL avoids having them
in the renderer memory unnnecessarily.

This is done by creating the DetachableResourceHandler in detached mode
when such a blocked resource is found.

BUG=632361

Review-Url: https://codereview.chromium.org/2262183002
Cr-Commit-Position: refs/heads/master@{#417926}

[modify] https://crrev.com/308308a95a348f446a25de9c9bd789c5a94c92c4/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/308308a95a348f446a25de9c9bd789c5a94c92c4/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/308308a95a348f446a25de9c9bd789c5a94c92c4/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/308308a95a348f446a25de9c9bd789c5a94c92c4/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/308308a95a348f446a25de9c9bd789c5a94c92c4/content/child/request_extra_data.cc
[modify] https://crrev.com/308308a95a348f446a25de9c9bd789c5a94c92c4/content/child/request_extra_data.h
[modify] https://crrev.com/308308a95a348f446a25de9c9bd789c5a94c92c4/content/child/resource_dispatcher.cc
[modify] https://crrev.com/308308a95a348f446a25de9c9bd789c5a94c92c4/content/child/web_url_request_util.cc
[modify] https://crrev.com/308308a95a348f446a25de9c9bd789c5a94c92c4/content/common/resource_messages.h
[modify] https://crrev.com/308308a95a348f446a25de9c9bd789c5a94c92c4/content/common/resource_request.h
[modify] https://crrev.com/308308a95a348f446a25de9c9bd789c5a94c92c4/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/308308a95a348f446a25de9c9bd789c5a94c92c4/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/308308a95a348f446a25de9c9bd789c5a94c92c4/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/308308a95a348f446a25de9c9bd789c5a94c92c4/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp

Blockedon: 649632
Blockedon: 656581

Comment 19 by pasko@chromium.org, Oct 18 2016

Blockedon: 657022

Comment 20 by pasko@chromium.org, Oct 18 2016

Blockedon: 657025
Blockedon: 657762
Blockedon: 657764
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66351bd0a0fc8740749663fe765a301e1a175538

commit 66351bd0a0fc8740749663fe765a301e1a175538
Author: pasko <pasko@chromium.org>
Date: Wed Oct 26 13:47:46 2016

[NoStatePrefetch] Kill renderer after preload scanning

The design doc is linked in the first bug. Main goal: remove Prerender.

Currently NoState Prefetch uses the same logic to manage renderers as the
PrerenderManager. Prefetch code is still living in PrerenderManager, separating
the code from there is planned after we finalize on how much of the
functionality of PrerenderManager is needed.

This is the first tweak in the renderer lifetime: the renderer asks to be killed
as soon as the main resource is fully preload-scanned and all possible
subresources are requested, special Prerendering FinalStatus is recorded to allow:
* testing
* provide a hint that a new prefetch can be started soon

Browsertest changes:

* TestPrerender now keeps FinalStatus for longer, to be able to verify that it
  is correct even after the TestPrerenderContents is destroyed.

* Prefetch browsertests wait only for creation of PrerenderContents, Prerender
  tests have more waiting for page loads on top of that

* PrerenderTestUrlImpl is removed to eliminate one hop through protected method
  in the parent class, which also simplified the prefetch side of the tests: no
  need to mention how many page loads to wait for

* Disabled two tests that load a non-HTML document, correctly killing the
  renderer will be done in later changes.

BUG=632361, 649632 

Review-Url: https://codereview.chromium.org/2411863002
Cr-Commit-Position: refs/heads/master@{#427678}

[modify] https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538/chrome/browser/prerender/prerender_final_status.cc
[modify] https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538/chrome/browser/prerender/prerender_final_status.h
[modify] https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538/chrome/browser/prerender/prerender_manager.h
[modify] https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538/chrome/browser/prerender/prerender_message_filter.cc
[modify] https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538/chrome/browser/prerender/prerender_message_filter.h
[modify] https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538/chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc
[modify] https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538/chrome/browser/prerender/prerender_test_utils.cc
[modify] https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538/chrome/browser/prerender/prerender_test_utils.h
[modify] https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538/chrome/common/prerender_messages.h
[modify] https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538/chrome/renderer/prerender/prerender_dispatcher.cc
[modify] https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538/chrome/renderer/prerender/prerender_dispatcher.h
[modify] https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538/third_party/WebKit/Source/web/tests/PrerenderingTest.cpp
[modify] https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538/third_party/WebKit/public/platform/WebPrerenderingSupport.h

Project Member

Comment 24 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f69bf24f0861768f03628206668ddb84f55dc8d4

commit f69bf24f0861768f03628206668ddb84f55dc8d4
Author: foolip <foolip@chromium.org>
Date: Thu Oct 27 09:08:20 2016

Revert of [NoStatePrefetch] Kill renderer after preload scanning (patchset #12 id:240001 of https://codereview.chromium.org/2411863002/ )

Reason for revert:
"NoStatePrefetchBrowserTest.OpenTaskManagerBeforePrefetch" became flaky
shortly after this landed.

BUG= 659697 

Original issue's description:
> [NoStatePrefetch] Kill renderer after preload scanning
>
> The design doc is linked in the first bug. Main goal: remove Prerender.
>
> Currently NoState Prefetch uses the same logic to manage renderers as the
> PrerenderManager. Prefetch code is still living in PrerenderManager, separating
> the code from there is planned after we finalize on how much of the
> functionality of PrerenderManager is needed.
>
> This is the first tweak in the renderer lifetime: the renderer asks to be killed
> as soon as the main resource is fully preload-scanned and all possible
> subresources are requested, special Prerendering FinalStatus is recorded to allow:
> * testing
> * provide a hint that a new prefetch can be started soon
>
> Browsertest changes:
>
> * TestPrerender now keeps FinalStatus for longer, to be able to verify that it
>   is correct even after the TestPrerenderContents is destroyed.
>
> * Prefetch browsertests wait only for creation of PrerenderContents, Prerender
>   tests have more waiting for page loads on top of that
>
> * PrerenderTestUrlImpl is removed to eliminate one hop through protected method
>   in the parent class, which also simplified the prefetch side of the tests: no
>   need to mention how many page loads to wait for
>
> * Disabled two tests that load a non-HTML document, correctly killing the
>   renderer will be done in later changes.
>
> BUG=632361, 649632 
>
> Committed: https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538
> Cr-Commit-Position: refs/heads/master@{#427678}

TBR=jochen@chromium.org,csharrison@chromium.org,droger@chromium.org,mattcary@chromium.org,mkwst@chromium.org,pasko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632361, 649632 

Review-Url: https://codereview.chromium.org/2452313002
Cr-Commit-Position: refs/heads/master@{#427974}

[modify] https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4/chrome/browser/prerender/prerender_final_status.cc
[modify] https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4/chrome/browser/prerender/prerender_final_status.h
[modify] https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4/chrome/browser/prerender/prerender_manager.h
[modify] https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4/chrome/browser/prerender/prerender_message_filter.cc
[modify] https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4/chrome/browser/prerender/prerender_message_filter.h
[modify] https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4/chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc
[modify] https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4/chrome/browser/prerender/prerender_test_utils.cc
[modify] https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4/chrome/browser/prerender/prerender_test_utils.h
[modify] https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4/chrome/common/prerender_messages.h
[modify] https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4/chrome/renderer/prerender/prerender_dispatcher.cc
[modify] https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4/chrome/renderer/prerender/prerender_dispatcher.h
[modify] https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4/third_party/WebKit/Source/web/tests/PrerenderingTest.cpp
[modify] https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4/third_party/WebKit/public/platform/WebPrerenderingSupport.h

Project Member

Comment 25 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07afa9f65f71178f9be52e2738303eee3c9fdb0d

commit 07afa9f65f71178f9be52e2738303eee3c9fdb0d
Author: pasko <pasko@chromium.org>
Date: Thu Oct 27 15:01:15 2016

Reland: [NoStatePrefetch] Kill renderer after preload scanning

Remove the inherently flaky test
NoStatePrefetchBrowserTest.OpenTaskManagerBeforePrefetch and revert the
following revert:

> Reason for revert:
> "NoStatePrefetchBrowserTest.OpenTaskManagerBeforePrefetch" became flaky
> shortly after this landed.
>
> BUG= 659697 
> Original issue's description:
> > [NoStatePrefetch] Kill renderer after preload scanning
> >
> > The design doc is linked in the first bug. Main goal: remove Prerender.
> >
> > Currently NoState Prefetch uses the same logic to manage renderers as the
> > PrerenderManager. Prefetch code is still living in PrerenderManager, separating
> > the code from there is planned after we finalize on how much of the
> > functionality of PrerenderManager is needed.
> >
> > This is the first tweak in the renderer lifetime: the renderer asks to be killed
> > as soon as the main resource is fully preload-scanned and all possible
> > subresources are requested, special Prerendering FinalStatus is recorded to allow:
> > * testing
> > * provide a hint that a new prefetch can be started soon
> >
> > Browsertest changes:
> >
> > * TestPrerender now keeps FinalStatus for longer, to be able to verify that it
> >   is correct even after the TestPrerenderContents is destroyed.
> >
> > * Prefetch browsertests wait only for creation of PrerenderContents, Prerender
> >   tests have more waiting for page loads on top of that
> >
> > * PrerenderTestUrlImpl is removed to eliminate one hop through protected method
> >   in the parent class, which also simplified the prefetch side of the tests: no
> >   need to mention how many page loads to wait for
> >
> > * Disabled two tests that load a non-HTML document, correctly killing the
> >   renderer will be done in later changes.
> >
> > BUG=632361,  649632 
> >
> > Committed: https://crrev.com/66351bd0a0fc8740749663fe765a301e1a175538
> > Cr-Commit-Position: refs/heads/master@{#427678}
> Committed: https://crrev.com/f69bf24f0861768f03628206668ddb84f55dc8d4
> Cr-Commit-Position: refs/heads/master@{#427974}

TBR=jochen@chromium.org,csharrison@chromium.org,mattcary@chromium.org,mkwst@chromium.org,pasko@chromium.org
BUG=632361,  649632 

Review-Url: https://codereview.chromium.org/2455653005
Cr-Commit-Position: refs/heads/master@{#428027}

[modify] https://crrev.com/07afa9f65f71178f9be52e2738303eee3c9fdb0d/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/07afa9f65f71178f9be52e2738303eee3c9fdb0d/chrome/browser/prerender/prerender_final_status.cc
[modify] https://crrev.com/07afa9f65f71178f9be52e2738303eee3c9fdb0d/chrome/browser/prerender/prerender_final_status.h
[modify] https://crrev.com/07afa9f65f71178f9be52e2738303eee3c9fdb0d/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/07afa9f65f71178f9be52e2738303eee3c9fdb0d/chrome/browser/prerender/prerender_manager.h
[modify] https://crrev.com/07afa9f65f71178f9be52e2738303eee3c9fdb0d/chrome/browser/prerender/prerender_message_filter.cc
[modify] https://crrev.com/07afa9f65f71178f9be52e2738303eee3c9fdb0d/chrome/browser/prerender/prerender_message_filter.h
[modify] https://crrev.com/07afa9f65f71178f9be52e2738303eee3c9fdb0d/chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc
[modify] https://crrev.com/07afa9f65f71178f9be52e2738303eee3c9fdb0d/chrome/browser/prerender/prerender_test_utils.cc
[modify] https://crrev.com/07afa9f65f71178f9be52e2738303eee3c9fdb0d/chrome/browser/prerender/prerender_test_utils.h
[modify] https://crrev.com/07afa9f65f71178f9be52e2738303eee3c9fdb0d/chrome/common/prerender_messages.h
[modify] https://crrev.com/07afa9f65f71178f9be52e2738303eee3c9fdb0d/chrome/renderer/prerender/prerender_dispatcher.cc
[modify] https://crrev.com/07afa9f65f71178f9be52e2738303eee3c9fdb0d/chrome/renderer/prerender/prerender_dispatcher.h
[modify] https://crrev.com/07afa9f65f71178f9be52e2738303eee3c9fdb0d/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/07afa9f65f71178f9be52e2738303eee3c9fdb0d/third_party/WebKit/Source/web/tests/PrerenderingTest.cpp
[modify] https://crrev.com/07afa9f65f71178f9be52e2738303eee3c9fdb0d/third_party/WebKit/public/platform/WebPrerenderingSupport.h

Project Member

Comment 26 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55713eceac5ddad41cbf6be7b4f4864dffcb8722

commit 55713eceac5ddad41cbf6be7b4f4864dffcb8722
Author: pasko <pasko@chromium.org>
Date: Thu Oct 27 15:57:15 2016

[NoStatePrefetch] Re-enable non-html tests

After the prefetchFinished() notification was moved to
Document::finishedParsing(), it actually started executing even for non-HTML
documents, which kills the renderer properly, and hence the tests can be
re-enabled.

Initially prefetchFinished() was called HTMLDocumentParser::end() which made
these tests fail, but then the call was moved to the better place during review.

BUG=632361, 649632 

Review-Url: https://codereview.chromium.org/2454783002
Cr-Commit-Position: refs/heads/master@{#428035}

[modify] https://crrev.com/55713eceac5ddad41cbf6be7b4f4864dffcb8722/chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc

Project Member

Comment 27 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aba1187ad8a7dd32263eb3db1cde0555cd443567

commit aba1187ad8a7dd32263eb3db1cde0555cd443567
Author: pasko <pasko@chromium.org>
Date: Thu Oct 27 16:25:59 2016

[NoStatePrefetch] Add new FinalStatus to histograms.xml

Followup to http://crrev.com/427678, where a new value to the enum was
introduced.

BUG=632361

Review-Url: https://codereview.chromium.org/2449163003
Cr-Commit-Position: refs/heads/master@{#428046}

[modify] https://crrev.com/aba1187ad8a7dd32263eb3db1cde0555cd443567/tools/metrics/histograms/histograms.xml

Comment 28 by pasko@chromium.org, Oct 28 2016

Blocking: 565501
Blockedon: 666306
Blockedon: 666738
Blockedon: 667243
Project Member

Comment 32 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f68f2e8b9b13fcd9ae65523f762d6f0e845367e

commit 0f68f2e8b9b13fcd9ae65523f762d6f0e845367e
Author: pasko <pasko@chromium.org>
Date: Mon Nov 21 15:36:15 2016

[NoStatePrefetch] Test that history is not written on prefetches

BUG=632361

Review-Url: https://codereview.chromium.org/2514663003
Cr-Commit-Position: refs/heads/master@{#433551}

[modify] https://crrev.com/0f68f2e8b9b13fcd9ae65523f762d6f0e845367e/chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc

Comment 33 by pasko@chromium.org, Nov 25 2016

Blockedon: 668714
Blockedon: 668997

Comment 35 by pasko@chromium.org, Dec 14 2016

Blockedon: 673771

Comment 36 by pasko@chromium.org, Dec 14 2016

Blockedon: 674181

Comment 37 by pasko@chromium.org, Jan 23 2017

Blockedon: 683905

Comment 38 by pasko@chromium.org, Mar 24 2017

Blockedon: 704911

Comment 39 by pasko@chromium.org, Mar 24 2017

Blockedon: 704868
Labels: -Performance Performance-Browser
Blocking: 762489
Blockedon: 756770
Blockedon: 792776

Comment 44 by pasko@chromium.org, Dec 27 2017

Blockedon: 796855

Comment 45 by pasko@chromium.org, Jan 31 2018

Summary: [meta] Implement "NoStatePrefetch" (was: [meta] Implement "No-State Prefetch")
What is the status of NoStatePrefetch? Can you help triage or provide context for issue 632406 and issue 632404?

Comment 47 by pasko@chromium.org, May 25 2018

back from OOO, sorry for delay

NoStatePrefetch is launched, the ideas to make it more SW-friendly are valid, but due to other priorities we are not working on them right now.
Blockedon: 677755

Sign in to add a comment