New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632360 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[arc-intents] Clicking on some links in chrome can trigger infinite tabs opening

Project Member Reported by kenobi@chromium.org, Jul 28 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7af62bdaac59bc72d4a87581243a2ce634d0918

commit b7af62bdaac59bc72d4a87581243a2ce634d0918
Author: kenobi <kenobi@chromium.org>
Date: Fri Jul 29 21:40:16 2016

[arc-intents] Properly qualify API-generated page transitions.

Unqualified page transitions are treated as link-clicks, which can get
sent to android via the arc intent mechanism.  This can result in
infinite-looping if the URL that is being opened originated from android
in the first place.

Marking this as an API-generated page transition ensures that the arc
intent code does not forward this URL back to android.

BUG= 632360 

Review-Url: https://codereview.chromium.org/2189063002
Cr-Commit-Position: refs/heads/master@{#408775}

[modify] https://crrev.com/b7af62bdaac59bc72d4a87581243a2ce634d0918/ash/common/shell_delegate.h
[modify] https://crrev.com/b7af62bdaac59bc72d4a87581243a2ce634d0918/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/b7af62bdaac59bc72d4a87581243a2ce634d0918/ash/mus/shell_delegate_mus.h
[modify] https://crrev.com/b7af62bdaac59bc72d4a87581243a2ce634d0918/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/b7af62bdaac59bc72d4a87581243a2ce634d0918/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/b7af62bdaac59bc72d4a87581243a2ce634d0918/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/b7af62bdaac59bc72d4a87581243a2ce634d0918/ash/sysui/shell_delegate_mus.h
[modify] https://crrev.com/b7af62bdaac59bc72d4a87581243a2ce634d0918/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/b7af62bdaac59bc72d4a87581243a2ce634d0918/ash/test/test_shell_delegate.h
[modify] https://crrev.com/b7af62bdaac59bc72d4a87581243a2ce634d0918/chrome/browser/chromeos/arc/arc_print_service.cc
[modify] https://crrev.com/b7af62bdaac59bc72d4a87581243a2ce634d0918/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/b7af62bdaac59bc72d4a87581243a2ce634d0918/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/b7af62bdaac59bc72d4a87581243a2ce634d0918/components/arc/intent_helper/arc_intent_helper_bridge.cc

Comment 2 by kenobi@chromium.org, Jul 29 2016

Status: Fixed (was: Assigned)

Comment 3 by kenobi@chromium.org, Jul 29 2016

Labels: Merge-Request-53 M-53

Comment 4 by dimu@chromium.org, Jul 30 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 1 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97ec68299a62dd2cb000639e7e990235b513eadc

commit 97ec68299a62dd2cb000639e7e990235b513eadc
Author: Ben Kwa <kenobi@google.com>
Date: Mon Aug 01 20:52:55 2016

[arc-intents] Properly qualify API-generated page transitions.

Unqualified page transitions are treated as link-clicks, which can get
sent to android via the arc intent mechanism.  This can result in
infinite-looping if the URL that is being opened originated from android
in the first place.

Marking this as an API-generated page transition ensures that the arc
intent code does not forward this URL back to android.

BUG= 632360 

Review-Url: https://codereview.chromium.org/2189063002
Cr-Commit-Position: refs/heads/master@{#408775}
(cherry picked from commit b7af62bdaac59bc72d4a87581243a2ce634d0918)

Review URL: https://codereview.chromium.org/2202753002 .

Cr-Commit-Position: refs/branch-heads/2785@{#443}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/ash/shell_delegate.h
[modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/ash/sysui/shell_delegate_mus.h
[modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/ash/test/test_shell_delegate.h
[modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/components/arc/intent_helper/arc_intent_helper_bridge.cc

Status: Verified (was: Fixed)

Sign in to add a comment