[arc-intents] Clicking on some links in chrome can trigger infinite tabs opening |
||||||
Issue descriptionSee b/30125340
,
Jul 29 2016
,
Jul 29 2016
,
Jul 30 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97ec68299a62dd2cb000639e7e990235b513eadc commit 97ec68299a62dd2cb000639e7e990235b513eadc Author: Ben Kwa <kenobi@google.com> Date: Mon Aug 01 20:52:55 2016 [arc-intents] Properly qualify API-generated page transitions. Unqualified page transitions are treated as link-clicks, which can get sent to android via the arc intent mechanism. This can result in infinite-looping if the URL that is being opened originated from android in the first place. Marking this as an API-generated page transition ensures that the arc intent code does not forward this URL back to android. BUG= 632360 Review-Url: https://codereview.chromium.org/2189063002 Cr-Commit-Position: refs/heads/master@{#408775} (cherry picked from commit b7af62bdaac59bc72d4a87581243a2ce634d0918) Review URL: https://codereview.chromium.org/2202753002 . Cr-Commit-Position: refs/branch-heads/2785@{#443} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/ash/shell/shell_delegate_impl.cc [modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/ash/shell/shell_delegate_impl.h [modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/ash/shell_delegate.h [modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/ash/sysui/shell_delegate_mus.cc [modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/ash/sysui/shell_delegate_mus.h [modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/ash/test/test_shell_delegate.cc [modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/ash/test/test_shell_delegate.h [modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/chrome/browser/ui/ash/chrome_shell_delegate.cc [modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/chrome/browser/ui/ash/chrome_shell_delegate.h [modify] https://crrev.com/97ec68299a62dd2cb000639e7e990235b513eadc/components/arc/intent_helper/arc_intent_helper_bridge.cc
,
Aug 12 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jul 29 2016