Try to avoid swizzle in createImageBitmap(ImageData) |
|||||
Issue descriptionIn the case of premultiplyAlpha = false, creaetImageBitmap(ImageData) creates a SkImage from ImageData directly. Now because ImageData is RBGA format, and in some platform SkImage supports BGRA format, so we have to swizzle the data. We should try to avoid that cost.
,
Nov 29 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 4 2017
,
Dec 6 2017
,
Dec 6 2017
IIUC there is no way that we can avoid swizzling. Even if we avoid swizzling in createImageBitmap(ImageData) and create the SkImage in RGBA mode, assuming that the system uses BGRA order, the image will get converted to BGRA inside Skia whenever it is drawn on to a BGRA surface/canvas. In fact by postponing the conversion to what matches the system expectation, we might end up with multiple swizzlings if the user uses/draws the image multiple times. I think this should be a WontFix.
,
Jan 10 2018
Makes Sense. -> WontFix |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by xidac...@chromium.org
, Nov 29 2016Owner: ----
Status: Available (was: Assigned)