New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632343 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

page load metrics parser blocked on script duration not recorded for xhtml documents

Project Member Reported by bmcquade@chromium.org, Jul 28 2016

Issue description

Our current implementation for recording parser blocked on script duration is in HTMLScriptRunner, which is only instantiated by HTMLDocumentParser. I believe that XHTML documents use XMLDocumentParser, which means we're missing recording of these metrics for xhtml pages. First step is to confirm that this is the case.
 
Components: Blink>HTML>Parser
Yes. c#0 is correct.
Would you describe more about the intended use case of the metric?
Owner: bmcquade@chromium.org
Status: Assigned (was: Untriaged)
The metric is just intended to give high level insight into the amount of time web pages are blocked on loading scripts, to help understand where page load delays come from.

An extension of this metric tracks parser blocking time for doc.written scripts, which is important for the doc.write blocking intervention.

I looked at XMLDocumentParser and it looks like it tracks the pending script directly. Seems like it should be straightforward to instrument that class. Does that sound right to you?

Though this is filed in the parser component, I see it more as a page load metrics bug. I'll assign this to myself for now.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4066a12bab519a1bb7afd04e0a1499c549bd491b

commit 4066a12bab519a1bb7afd04e0a1499c549bd491b
Author: bmcquade <bmcquade@chromium.org>
Date: Fri Aug 12 19:59:04 2016

Track parse time blocked on script in xml documents.

This adds the existing equivalent logic from HTMLDocumentParser to
XMLDocumentParser.

BUG= 632343 

Review-Url: https://codereview.chromium.org/2235733004
Cr-Commit-Position: refs/heads/master@{#411745}

[modify] https://crrev.com/4066a12bab519a1bb7afd04e0a1499c549bd491b/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
[modify] https://crrev.com/4066a12bab519a1bb7afd04e0a1499c549bd491b/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.h

Status: Fixed (was: Assigned)

Sign in to add a comment