Do not allow left trimming on new space pages that need to be swept. |
||||||
Issue descriptionDo not allow left trimming on new space pages that need to be swept. Otherwise it may come to races with the sweeper thread on new to new promotion. Crashes may happen on arbitrary location in V8, i.e. this manifests right now as random memory corruption on the V8 heap.
,
Jul 28 2016
,
Jul 28 2016
,
Jul 29 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 1 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 1 2016
Please try to merge your change to M53 branch 2785 asap so we can take it for this week beta release on Wednesday. Thank you very much.
,
Aug 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/d223ca03ef3318c8dc92c7bd1a25b8e23e7b6de9 commit d223ca03ef3318c8dc92c7bd1a25b8e23e7b6de9 Author: hpayer <hpayer@chromium.org> Date: Tue Aug 02 11:44:40 2016 Merged: [heap] Do not allow left trimming on new space pages that need to be swept. Revision: 76812cc75c7cced77a828eb65351a8b9fb1a7e3f BUG=chromium:630969, chromium:632334 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=mlippautz@chromium.org Review-Url: https://codereview.chromium.org/2200103002 Cr-Commit-Position: refs/branch-heads/5.3@{#33} Cr-Branched-From: 820a23aade5e74a92d794e05a0c2b3597f0da4b5-refs/heads/5.3.332@{#2} Cr-Branched-From: 37538cb2c1b4d75c41af386cb4fedbe5566f5608-refs/heads/master@{#37308} [modify] https://crrev.com/d223ca03ef3318c8dc92c7bd1a25b8e23e7b6de9/src/heap/heap.cc
,
Aug 2 2016
We're cutting M53 Beta RC today for release tomorrow. Please try to merge your change to M53 branch 2785 before 5:30 PM PT today so we can take it for this week beta. Thank you.
,
Aug 3 2016
Per comment #8, this is already merged to M53. If all is done for M53, please remove "Merge-Approved-53" label. Thank you.
,
Aug 4 2016
Removing "Merge-Approved-53" label as it is already merged per comment #8. Please re-request M53 merge if needed. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jul 28 2016