New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632334 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Do not allow left trimming on new space pages that need to be swept.

Project Member Reported by hpayer@chromium.org, Jul 28 2016

Issue description

Do not allow left trimming on new space pages that need to be swept. Otherwise it may come to races with the sweeper thread on new to new promotion.

Crashes may happen on arbitrary location in V8, i.e. this manifests right now as random memory corruption on the V8 heap.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/76812cc75c7cced77a828eb65351a8b9fb1a7e3f

commit 76812cc75c7cced77a828eb65351a8b9fb1a7e3f
Author: hpayer <hpayer@chromium.org>
Date: Thu Jul 28 13:48:09 2016

[heap] Do not allow left trimming on new space pages that need to be swept.

BUG=chromium:630969, chromium:632334 
LOG=n

Review-Url: https://codereview.chromium.org/2189033002
Cr-Commit-Position: refs/heads/master@{#38137}

[modify] https://crrev.com/76812cc75c7cced77a828eb65351a8b9fb1a7e3f/src/heap/heap.cc

Comment 2 by hpayer@chromium.org, Jul 28 2016

Status: Fixed (was: Started)

Comment 3 by hpayer@chromium.org, Jul 28 2016

Labels: Merge-Request-53

Comment 4 by dimu@chromium.org, Jul 29 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 1 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 Deleted

Please try to merge your change to M53 branch 2785 asap so we can take it for this week beta release on Wednesday. Thank you very much.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 2 2016

Labels: merge-merged-5.3
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d223ca03ef3318c8dc92c7bd1a25b8e23e7b6de9

commit d223ca03ef3318c8dc92c7bd1a25b8e23e7b6de9
Author: hpayer <hpayer@chromium.org>
Date: Tue Aug 02 11:44:40 2016

Merged: [heap] Do not allow left trimming on new space pages that need to be swept.

Revision: 76812cc75c7cced77a828eb65351a8b9fb1a7e3f

BUG=chromium:630969, chromium:632334 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=mlippautz@chromium.org

Review-Url: https://codereview.chromium.org/2200103002
Cr-Commit-Position: refs/branch-heads/5.3@{#33}
Cr-Branched-From: 820a23aade5e74a92d794e05a0c2b3597f0da4b5-refs/heads/5.3.332@{#2}
Cr-Branched-From: 37538cb2c1b4d75c41af386cb4fedbe5566f5608-refs/heads/master@{#37308}

[modify] https://crrev.com/d223ca03ef3318c8dc92c7bd1a25b8e23e7b6de9/src/heap/heap.cc

We're cutting M53 Beta RC today for release tomorrow. Please try to merge your change to M53 branch 2785 before 5:30 PM PT today so we can take it for this week beta. Thank you.
Per comment #8, this is already merged to M53. If all is done for M53, please remove "Merge-Approved-53" label. Thank you.
Labels: -Merge-Approved-53
Removing "Merge-Approved-53" label as it is already merged per comment #8. Please re-request M53 merge if needed.

Sign in to add a comment