Regression: Space key doesn't work in Gmail chat window after adding Google input tools extension |
|||||||
Issue descriptionVersion: 54.0.2806.0/8639.0.0 dev channel falco,gnawty,spring. OS: Chrome os Test URL: https://chrome.google.com/webstore/detail/google-input-tools/mclkkofklkfljcocdinagocijmpgbhab?utm_source=chrome-app-launcher-info-dialog What steps will reproduce the problem? (1) Sign in to user >> Add above extension >> Open Gmail chat window >> Try to hit space key and observe. Expected: Should be able to enter space character. Actual: Instead nothing happens on hitting space key. This is a regression issue as it is working fine in 52.0.2743.85/8350.60.0 stable channel daisy. Will provide linux behavior soon.
,
Jul 28 2016
Reproducible on 54.0.2810.2 on Mac OS 10.11.5 as well.
,
Jul 28 2016
CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/52cac9f6a9a12c830f3be0b6961cc3a23c0535e5..8134eeb454ef76c72df8cd7c26f6141072c314cb Suspecting https://codereview.chromium.org/2175163004 from changelog. @joone.hur: Please confirm the behavior and help in re-assigning if it is not related to your change. Unable to to assign to @joone.hur.intel.com, @tkent:Please help in routing to appropriate owner. Thanks.
,
Jul 28 2016
I will take a look at it. Thanks!
,
Jul 28 2016
I don't understand why I was assigned...
,
Jul 29 2016
Here is a fix: https://codereview.chromium.org/2191163002/
,
Jul 29 2016
yosin@ is a virtual owner.
,
Jul 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4dab74137593abb0888e415294aeb80da27362e3 commit 4dab74137593abb0888e415294aeb80da27362e3 Author: joone.hur <joone.hur@intel.com> Date: Fri Jul 29 03:35:48 2016 Add instead of plain space when it is inserted before the empty text node This CL fixes the regression that space key doesn't work in the gmail chat window. BUG= 632300 TEST=editing/inserting/insert-space.html Review-Url: https://codereview.chromium.org/2191163002 Cr-Commit-Position: refs/heads/master@{#408571} [modify] https://crrev.com/4dab74137593abb0888e415294aeb80da27362e3/third_party/WebKit/LayoutTests/editing/inserting/insert-space.html [modify] https://crrev.com/4dab74137593abb0888e415294aeb80da27362e3/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
,
Aug 1 2016
,
Oct 19 2016
Works on ChromeOS minnie M55 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sc00335...@techmahindra.com
, Jul 28 2016