Issue metadata
Sign in to add a comment
|
make use of use_glib and related GN variables explicitly
Reported by
most...@opera.com,
Jul 28 2016
|
||||||||||||||||||||
Issue descriptionThere are a bunch of places in the GN build config that have conditional blocks related to glib, libgio et al, but which don't use the existing GN args/variables (use_glib, use_gio etc). We should use those variables directly, because it makes refactoring easier, makes these dependencies more visible, and also makes it possible to build targets that don't depend on these libraries without GN complaining that eg //build/config/linux:glib does not exist.
,
Jul 28 2016
Is this fixed? And is it just a GN question not related to infra?
,
Jul 28 2016
I have a few open CLs to land before this is fixed. I don't understand the component classifications, but all the work is in .gn files, not gn itself.
,
Jul 28 2016
At the moment, this should be component "Build" (issues with the build files), and not have label "Build-Tools-GN" whichi is for changes to GN itself. This is not an infra thing.
,
Aug 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a395c69f43be191344cb9b198fe8e77f6c4bd17 commit 2a395c69f43be191344cb9b198fe8e77f6c4bd17 Author: mostynb <mostynb@opera.com> Date: Tue Aug 02 16:12:14 2016 make use of existing gn args in ui build config BUG= 632297 Review-Url: https://codereview.chromium.org/2185163003 Cr-Commit-Position: refs/heads/master@{#409203} [modify] https://crrev.com/2a395c69f43be191344cb9b198fe8e77f6c4bd17/build/config/ui.gni [modify] https://crrev.com/2a395c69f43be191344cb9b198fe8e77f6c4bd17/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/2a395c69f43be191344cb9b198fe8e77f6c4bd17/ui/accessibility/BUILD.gn [modify] https://crrev.com/2a395c69f43be191344cb9b198fe8e77f6c4bd17/ui/events/BUILD.gn
,
Aug 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/491846845617b9e94ee2636b28a117b60be4e4cf commit 491846845617b9e94ee2636b28a117b60be4e4cf Author: mostynb <mostynb@opera.com> Date: Tue Aug 02 16:17:56 2016 make use of the use_gio gn arg BUG= 632297 Review-Url: https://codereview.chromium.org/2190793002 Cr-Commit-Position: refs/heads/master@{#409204} [modify] https://crrev.com/491846845617b9e94ee2636b28a117b60be4e4cf/chrome/test/BUILD.gn
,
Aug 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75e8d631af691f5607637bdf7fa3eb3fe9b98c88 commit 75e8d631af691f5607637bdf7fa3eb3fe9b98c88 Author: mostynb <mostynb@opera.com> Date: Tue Aug 02 16:46:53 2016 make use of existing gn args in net/BUILD.gn BUG= 632297 Review-Url: https://codereview.chromium.org/2188043002 Cr-Commit-Position: refs/heads/master@{#409209} [modify] https://crrev.com/75e8d631af691f5607637bdf7fa3eb3fe9b98c88/net/BUILD.gn
,
Aug 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ca5a503b8f28258126226df203bef7fd316dfad commit 9ca5a503b8f28258126226df203bef7fd316dfad Author: raphael.kubo.da.costa <raphael.kubo.da.costa@intel.com> Date: Thu Aug 11 23:35:09 2016 gn: Stop asserting on |use_gconf| when looking for atk. |use_gconf| was added back in commit 2f4a32e98 ("linux gn config should check use_gconf before looking for it with pkg-config") back when the pkg-config calls to atk and gconf were grouped together within a single if check. Since then, commit 95ba4446 ("Move linux pkg_config() calls into separate BUILD.gn files") has split all the pkg-config checks. As atk itself does not depend on gconf, we can drop use_gconf from the assertion in atk's BUILD.gn. R=brettw@chromium.org,dpranke@chromium.org,mostynb@opera.com BUG= 632297 Review-Url: https://codereview.chromium.org/2241513002 Cr-Commit-Position: refs/heads/master@{#411440} [modify] https://crrev.com/9ca5a503b8f28258126226df203bef7fd316dfad/build/config/linux/atk/BUILD.gn
,
Aug 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/984335951bbc9b2d9532db8b8d1161494f79a105 commit 984335951bbc9b2d9532db8b8d1161494f79a105 Author: raphael.kubo.da.costa <raphael.kubo.da.costa@intel.com> Date: Wed Aug 17 20:59:38 2016 gn: Stop making |use_atk| depend on |use_gconf|. This partly reverts commit 2a395c69f ("make use of existing gn args in ui build config"). atk itself does not depend on gconf, and the change introduced in the commit above was likely created before commit 95ba4446 ("Move linux pkg_config() calls into separate BUILD.gn files"), when atk and gconf were part of the same if block in build/config/linux/BUILD.gn. See also: https://codereview.chromium.org/2241513002 R=brettw@chromium.org,dpranke@chromium.org,mostynb@opera.com BUG= 632297 Review-Url: https://codereview.chromium.org/2248043002 Cr-Commit-Position: refs/heads/master@{#412634} [modify] https://crrev.com/984335951bbc9b2d9532db8b8d1161494f79a105/build/config/ui.gni
,
Aug 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/902b5282bf5c0314c801fa29a27ae1e4d39a56bc commit 902b5282bf5c0314c801fa29a27ae1e4d39a56bc Author: mostynb <mostynb@opera.com> Date: Wed Aug 17 23:01:00 2016 remove duplicate atk GN config The atk GN configs were moved to a separate GN file in https://codereview.chromium.org/1909273002 but it appears that the original configs were not removed, and are still referenced. Let's remove the old configs and just use the new ones. And while we're at it, add an assertion to check that glib is enabled when atk is. BUG= 632297 TBR=agrieve@chromium.org Review-Url: https://codereview.chromium.org/2251673004 Cr-Commit-Position: refs/heads/master@{#412680} [modify] https://crrev.com/902b5282bf5c0314c801fa29a27ae1e4d39a56bc/build/config/linux/atk/BUILD.gn [modify] https://crrev.com/902b5282bf5c0314c801fa29a27ae1e4d39a56bc/content/browser/BUILD.gn [modify] https://crrev.com/902b5282bf5c0314c801fa29a27ae1e4d39a56bc/ui/accessibility/BUILD.gn [modify] https://crrev.com/902b5282bf5c0314c801fa29a27ae1e4d39a56bc/ui/views/BUILD.gn
,
Sep 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5c9431b0a1d8714ecf2fe2659f740e5d2d61201 commit e5c9431b0a1d8714ecf2fe2659f740e5d2d61201 Author: mostynb <mostynb@opera.com> Date: Thu Sep 15 01:22:28 2016 //device/media_transfer_protocol depends on dbus The build should fail early if //device/media_transfer_protocol is included with dbus explicitly disabled. BUG= 632297 Review-Url: https://codereview.chromium.org/2333573003 Cr-Commit-Position: refs/heads/master@{#418744} [modify] https://crrev.com/e5c9431b0a1d8714ecf2fe2659f740e5d2d61201/chrome/browser/BUILD.gn [modify] https://crrev.com/e5c9431b0a1d8714ecf2fe2659f740e5d2d61201/components/storage_monitor/BUILD.gn [modify] https://crrev.com/e5c9431b0a1d8714ecf2fe2659f740e5d2d61201/device/media_transfer_protocol/BUILD.gn
,
Sep 15 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 28 2016