New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632285 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"IncidentReportingServiceTest.ClearProcessIncidentOnCleanState" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jul 28 2016

Issue description

"IncidentReportingServiceTest.ClearProcessIncidentOnCleanState" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySAsSBUZsYWtlIj1JbmNpZGVudFJlcG9ydGluZ1NlcnZpY2VUZXN0LkNsZWFyUHJvY2Vzc0luY2lkZW50T25DbGVhblN0YXRlDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by tapted@chromium.org, Jul 29 2016

Cc: mamir@chromium.org fdoray@chromium.org
Owner: roc...@chromium.org
Status: Assigned (was: Untriaged)
failures on linux and mac

IncidentReportingServiceTest.AddIncident (run #1):
[ RUN      ] IncidentReportingServiceTest.AddIncident
[14151:14151:0727/162601:8398789573:FATAL:delayed_callback_runner.cc(18)] Check failed: ::content::BrowserThread::CurrentlyOn(content::BrowserThread::UI). Must be called on Chrome_UIThread; actually called on Unknown Thread.
#0 0x0000046e886e base::debug::StackTrace::StackTrace()
#1 0x0000046fe4ea logging::LogMessage::~LogMessage()
#2 0x0000044baad1 safe_browsing::DelayedCallbackRunner::DelayedCallbackRunner()
#3 0x0000044c072e safe_browsing::IncidentReportingService::IncidentReportingService()
#4 0x00000192fb6f IncidentReportingServiceTest::TestIncidentReportingService::TestIncidentReportingService()
#5 0x0000019261fc IncidentReportingServiceTest::SetFieldTrialAndCreateService()
#6 0x0000019257b6 IncidentReportingServiceTest_AddIncident_Test::TestBody()
#7 0x000003ce7d47 testing::Test::Run()
#8 0x000003ce8a03 testing::TestInfo::Run()
#9 0x000003ce8e93 testing::TestCase::Run()
#10 0x000003cf0069 testing::internal::UnitTestImpl::RunAllTests()
#11 0x000003cefd0e testing::UnitTest::Run()
#12 0x0000039ea1b6 base::TestSuite::Run()
#13 0x0000039eb7a4 base::LaunchUnitTests()
#14 0x0000039e63e6 main
#15 0x7efdeaf2c7ed __libc_start_main
#16 0x0000006835d1 <unknown>



Recent changes
 - https://codereview.chromium.org/2180253003 "Ensure BrowserThread::CurrentlyOn is correct through MessageLoop teardown"
 - https://codereview.chromium.org/2054773002 "Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref"
 - https://codereview.chromium.org/2085673002 "Remove calls to MessageLoop::current() in extensions."

Comment 2 by tapted@chromium.org, Jul 29 2016

 Issue 632288  has been merged into this issue.

Comment 3 by tapted@chromium.org, Jul 29 2016

 Issue 632307  has been merged into this issue.

Comment 4 by tapted@chromium.org, Jul 29 2016

 Issue 632337  has been merged into this issue.

Comment 5 by tapted@chromium.org, Jul 29 2016

 Issue 632348  has been merged into this issue.

Comment 6 by tapted@chromium.org, Jul 29 2016

 Issue 632410  has been merged into this issue.

Comment 7 by tapted@chromium.org, Jul 29 2016

 Issue 632420  has been merged into this issue.

Comment 8 by tapted@chromium.org, Jul 29 2016

 Issue 632421  has been merged into this issue.

Comment 9 by tapted@chromium.org, Jul 29 2016

 Issue 632422  has been merged into this issue.
 Issue 632423  has been merged into this issue.
Status: Fixed (was: Assigned)
I already reverted in r408311 and relanded the patch with a fix in r408411.

I don't think it's possible to hit this flake now. Please reopen if the flake reappears.

Sign in to add a comment