Issue metadata
Sign in to add a comment
|
Regression:Blank chrome://history page is seen upon reloading the page. |
||||||||||||||||||||||
Issue descriptionVersion: 54.0.2810.0 Dev OS: Ubuntu 14.04,Windows Precondition: Make sure to have some history entries. What steps will reproduce the problem? (1)Launch Chrome>>Navigate to chrome://history page>>Right click on tab strip and duplicate page. (2)Click any link and click on back navigation arrow(Please refer video) (3)Now hit Ctrl+r and Observe. Expected:History page should not become blank on reloading. Actual: Instead history page is seen blank upon reloading. This is a regression issue broken in M-54. Will update bisect info soon. Attaching screen-cast for reference.
,
Jul 28 2016
Bisect info: Good build:54.0.2808.0 Dev Bad build:54.0.2810.2 Dev CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/0df063fc467074ee4bbd9d37c04d48c15d572100..70e925bf7b6e6314034bf4af238adc03991f6d15 Suspecting https://codereview.chromium.org/1939253002 from changelog. @enne: Please help in re-assigning if it is not related to your change.
,
Jul 28 2016
Can't repro this on Linux, but I can on Mac. It does look like my change as --disable-begin-frame-scheduling makes it not happen. I'll investigate.
,
Jul 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fae0fb34ab73f12a8be3493f0ec06dbbb32c7b20 commit fae0fb34ab73f12a8be3493f0ec06dbbb32c7b20 Author: enne <enne@chromium.org> Date: Fri Jul 29 22:32:23 2016 Fix bug with blank pages during navigation This bug started after r408172. In some situations when navigating, the SetNeedsBeginFrame messages that is sent from the CompositorExternalBeginFrameSource to the RenderWidgetHostView, but is received by the RenderWidgetHostImpl while the RenderViewHost is swapped out and before it has swapped back in. In these cases, if this message is dropped, the renderer will never tick new frames and the tab will freeze. This appears to be racy, as the renderer finds out that it is visible and sends this message before the view host is swapped in. To fix this race, always allow the SetNeedsBeginFrame message to be received while being swapped out so that the RenderWidgetHostView can be in the correct state when it is swapped in. R=sievers@chromium.org BUG= 632276 Review-Url: https://codereview.chromium.org/2197783002 Cr-Commit-Position: refs/heads/master@{#408787} [modify] https://crrev.com/fae0fb34ab73f12a8be3493f0ec06dbbb32c7b20/content/common/swapped_out_messages.cc
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad648d7d920843e226b5f0aee2cf8e9662412413 commit ad648d7d920843e226b5f0aee2cf8e9662412413 Author: tapted <tapted@chromium.org> Date: Mon Aug 01 01:53:54 2016 Revert of Fix bug with blank pages during navigation (patchset #1 id:1 of https://codereview.chromium.org/2197783002/ ) Reason for revert: Suspected for widespread NaCl plugin failures on waterfall since https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504 Crashes with "Actual: "Plugin crashed. 'NaCl module crashed" It wasn't r408782, so I think it's gotta be this or r408781. Original issue's description: > Fix bug with blank pages during navigation > > This bug started after r408172. In some situations when navigating, the > SetNeedsBeginFrame messages that is sent from the > CompositorExternalBeginFrameSource to the RenderWidgetHostView, but is > received by the RenderWidgetHostImpl while the RenderViewHost is swapped > out and before it has swapped back in. In these cases, if this message > is dropped, the renderer will never tick new frames and the tab will > freeze. This appears to be racy, as the renderer finds out that it is > visible and sends this message before the view host is swapped in. > > To fix this race, always allow the SetNeedsBeginFrame message to be > received while being swapped out so that the RenderWidgetHostView can be > in the correct state when it is swapped in. > > R=sievers@chromium.org > BUG= 632276 > > Committed: https://crrev.com/fae0fb34ab73f12a8be3493f0ec06dbbb32c7b20 > Cr-Commit-Position: refs/heads/master@{#408787} TBR=kenrb@chromium.org,sievers@chromium.org,enne@chromium.org NOTRY=true BUG= 632276 Review-Url: https://codereview.chromium.org/2200593002 Cr-Commit-Position: refs/heads/master@{#408899} [modify] https://crrev.com/ad648d7d920843e226b5f0aee2cf8e9662412413/content/common/swapped_out_messages.cc
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c68f138494f4bdc8a60a6e74eabd52462eb01030 commit c68f138494f4bdc8a60a6e74eabd52462eb01030 Author: tapted <tapted@chromium.org> Date: Mon Aug 01 02:59:05 2016 Reland of Fix bug with blank pages during navigation (patchset #1 id:1 of https://codereview.chromium.org/2200593002/ ) Reason for revert: No dice - NaCl still crashing in https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55553 Original issue's description: > Revert of Fix bug with blank pages during navigation (patchset #1 id:1 of https://codereview.chromium.org/2197783002/ ) > > Reason for revert: > Suspected for widespread NaCl plugin failures on waterfall since > https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/55504 > > Crashes with "Actual: "Plugin crashed. 'NaCl module crashed" > > It wasn't r408782, so I think it's gotta be this or r408781. > > Original issue's description: > > Fix bug with blank pages during navigation > > > > This bug started after r408172. In some situations when navigating, the > > SetNeedsBeginFrame messages that is sent from the > > CompositorExternalBeginFrameSource to the RenderWidgetHostView, but is > > received by the RenderWidgetHostImpl while the RenderViewHost is swapped > > out and before it has swapped back in. In these cases, if this message > > is dropped, the renderer will never tick new frames and the tab will > > freeze. This appears to be racy, as the renderer finds out that it is > > visible and sends this message before the view host is swapped in. > > > > To fix this race, always allow the SetNeedsBeginFrame message to be > > received while being swapped out so that the RenderWidgetHostView can be > > in the correct state when it is swapped in. > > > > R=sievers@chromium.org > > BUG= 632276 > > > > Committed: https://crrev.com/fae0fb34ab73f12a8be3493f0ec06dbbb32c7b20 > > Cr-Commit-Position: refs/heads/master@{#408787} > > TBR=kenrb@chromium.org,sievers@chromium.org,enne@chromium.org > NOTRY=true > BUG= 632276 > > Committed: https://crrev.com/ad648d7d920843e226b5f0aee2cf8e9662412413 > Cr-Commit-Position: refs/heads/master@{#408899} TBR=kenrb@chromium.org,sievers@chromium.org,enne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 632276 Review-Url: https://codereview.chromium.org/2195253002 Cr-Commit-Position: refs/heads/master@{#408902} [modify] https://crrev.com/c68f138494f4bdc8a60a6e74eabd52462eb01030/content/common/swapped_out_messages.cc
,
Aug 2 2016
Tested the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.6 using chrome version 54.0.2816.0 as per the steps #0.History page opened fine upon reloading.Please find the attached screen cast for the same. Adding TE-Verified labels. Thanks,
,
Aug 8 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ajha@chromium.org
, Jul 28 2016Status: Untriaged (was: Unconfirmed)