New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment
link

Issue 632274: Regression:Weird black line is seen on print preview after clicking on pdf page.

Reported by vku...@etouch.net, Jul 28 2016

Issue description

Chrome Version: 54.0.2810.0 (Official Build)Revision 24d606bb2a3e6290b97d9731c1dfd4dbfcb948e7-refs/heads/master@{#408294}(64-bit)
OS:Mac (10.10.5,10.11.4)

What steps will reproduce the problem?
(1)Launch chrome and navigate to any pdf file for e.g https://msu.edu/~urban/sme865/resources/embedded_pdf.html  OR https://msu.edu/~urban/sme865/resources/embedded_pdf.html
(2)Click on Print button from top right and click on change button from destination 
(3)Now click on page i.e outside print overlay 2-3 times,observe

Actual: Weird black line is seen on print preview after clicking on pdf page.

Expected: Weird black line should not be seen on print preview after clicking on pdf page.

This is a regression issue broken in 'M54' and will soon update other info.
 

Comment 1 by vku...@etouch.net, Jul 28 2016

Cc: skau@chromium.org
Labels: hasbisect
Owner: ekaramad@chromium.org
Status: Assigned (was: Unconfirmed)
Correction 
In step 1: Launch chrome and navigate to any pdf file for e.g https://msu.edu/~urban/sme865/resources/embedded_pdf.html  OR http://www.orimi.com/pdf-test.pdf

Manual regression range:
Good Build: 54.0.2809.0 
Bad Build: 54.0.2810.0 

CL:
https://chromium.googlesource.com/chromium/src/+log/54.0.2809.0..54.0.2810.0?pretty=fuller&n=10000
(Unable to narrow down the range since getting all bad chromium builds via tool)

Suspecting:   408179 or 408199 ?
Kindly help to re-assign, if your changes are not cause for this issue.

Note: Issue not seen on Win & Linux OS
Actual_Result.mov
2.4 MB Download
Expected_Result.mov
3.4 MB Download

Comment 2 by msrchandra@chromium.org, Jul 28 2016

Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.

Comment 3 by lfg@chromium.org, Jul 28 2016

Cc: ekaramad@chromium.org
Owner: erikc...@chromium.org
Suspecting https://crrev.com/408286. +erikchen@, can you take a look?

Comment 4 by ekaramad@chromium.org, Jul 28 2016

I could repro this on local build at 408294, but not on Canary.

Comment 5 by erikc...@chromium.org, Jul 28 2016

If this is caused by one of my changes, it would be:
"""
Enable RenderPassDrawQuad promotion to CALayer.
"""

I'm having trouble reproducing this issue (tried two different machines, Canary and Chromium). Can people who have successfully reproduced share their configurations? (macOS version, GPU, etc.)

Comment 6 by ekaramad@chromium.org, Jul 28 2016

GN configuration for release build on a Mac Book Air running El Capitan Version 10.11.6:
is_debug = false
is_component_build = true
enable_google_now = false
enable_nacl = false
use_goma = true
dcheck_always_on = true
is_official_build = true

I checkout out the last commit above at 408294 and tried the PDFs in comment #2.

I could NOT repro this on Canary today.

Comment 7 by erikc...@chromium.org, Jul 28 2016

What GPU?

Comment 8 by ekaramad@chromium.org, Jul 28 2016

Intel HD Graphics 5000 1536 MB.

Comment 9 by erikc...@chromium.org, Jul 28 2016

Cc: erikc...@chromium.org
Owner: ericrk@chromium.org
I'm pretty sure this is related to Ganesh on Mac.

Observations:
1) I was only able to reproduce this on an Intel HD 5000 device, and only with a static Chromium build or Canary (not an official build).

2) Reverting my CLs related to RDPQ doesn't help. Neither does skau's printing CL, nor enne's "begin frame scheduling" CL.

3) The problem never reproduces with --disable-mac-overlays.

4) The flashing black lines that I see are always on tile borders. If you use --show-mac-overlay-borders, the flashing lines up perfectly with the tile borders.

5) I've never reproduced the problem with --disable-gpu-rasterization

The problem isn't deterministic, so I can't say for certain that it's Ganesh, but I tried the following:
a) Launch a problematic build with no flags. See flashing black line.
b) Launch with --disable-gpu-rasterization. Don't see problem.
Repeat (a) & (b) 3 times. Same results.

I know that Ganesh on Mac has issues with HD 3000 and HD 4000, so I wouldn't be surprised if HD 5000 was also problematic...

Comment 10 by erikc...@chromium.org, Jul 28 2016

Cc: vmi...@chromium.org

Comment 11 by ericrk@chromium.org, Jul 29 2016

I'm able to repro. One thing I noticed is that repro wouldn't happen in HiDPI (retina) mode. Forcing my computer into non-retina mode (using a 3rd party util, RDM) allowed me to repro. Not an issue on MBA, but if anyone's trying to repro on a MBP this may help.

Comment 12 by ericrk@chromium.org, Jul 29 2016

Cc: ccameron@chromium.org
After digging further, this is not actually related to GPU raster, but to the tile size being used. It just happens that the tile size used in GPU raster hits this bug. If I switch SW raster to use GPU-Raster sized tiles, then this issue shows up there as well.

I'm able to repro on a number of configurations, assuming I disable HiDPI mode. This includes GeForce 650M, HD4000 and HD5300. Additionally, I was able to reproduce this quite a ways back (I repro'd with a June 1 build, then stopped), so this isn't likely a recent regression.

In the repro case, this issue shows up during an animation where we scale up the layer (and the IOSurfaces making it up). It appears that with certain sizes of IOSurfaces gaps are left between the surfaces when the layer is scaled up (see the attached picture).

We should check whether we have a rounding error that could lead to this. If not (and this is an OS issue), we may be able to modify the rounding used for tiles to pick sizes that avoid this. I was able to reproduce this issue at a number of tile sizes, but rounding to multiples of 32 appears to avoid the issue (we currently round to multiples of 4).

I'll look into this more tomorrow.

+ccameron in case he has any thoughts.
iosurface_spacing.png
163 KB View Download

Comment 13 by ericrk@chromium.org, Jul 29 2016

Discussed with ccameron@ - seems like we should eventually move to using more standard (square) tiles for GPU raster, but as this is a large change. The best option at the moment is probably to round tile sizes to a larger value and try to avoid the rounding error. Local testing seems to indicate that 32 (but not 16) is enough to avoid this issue. From looking at the IOSurface APIs, there doesn't appear to be a required alignment.

SW uses 64 pixel alignment and has never been seen to hit this issue, so we could chose 64 as well.

Comment 14 by vmi...@chromium.org, Jul 29 2016

Could someone confirm the layer positions for this content?  We've seen issues related to huge layer offsets which cause gaps in tiles due to numeric errors in floating point math in the compositor (Issue 623198).

Comment 15 by ericrk@chromium.org, Jul 29 2016

Here's a simpler repro case - will trigger the issue (or a very similar one) with both SW and GPU raster.

Oddly, this seems impacted by solid color vs contentful tiles - not sure if this is part of the issue, or if it just changes things slightly and hides the issue in this repro case.
scale_error.html
311 bytes View Download

Comment 16 by vmi...@chromium.org, Jul 29 2016

So I don't know how CoreAnimation works but I have a hypothesis that both GLRenderer and CA are prone to numerical errors in computing tile coordinates whenever we have either huge coordinates, or funky scales with complex FP32 representations.

To qualify funky, something that takes most of 24bits of FP32 number's mantissa.  This doesn't happen for example with page zoom which is mostly to certain values: 1.0, 1.1, 1.25, 1.5, 1.75, etc..

What I notice on the msu.edu page is the offending layer has a scale transform of 1.019786f or 0x3f828859 as HEX.  This is a "funky" scale with 24 full bits of significant data in the mantissa, very prone to numerical errors.  We could truncate (round) these to make them less funky.

Similarly rounding tile coordinates helps too.

Here's a test...
  A is the "bottom" coordinate of tile "i".
  B is the "top" coordinate of tile "i+1".
  A and B should match.

 tile_height = 425.000000 (000001A9)
 scale = 1.019786 (3F828859)
 i0 A 43D8B45C B 43D8B45C
 i1 A 4458B45C B 4458B45C
 i2 A 44A28745 B 44A28745
 i3 A 44D8B45C B 44D8B45C
 i4 A 450770BA B 450770B9 <<< DIFFERENT
 i5 A 45228744 B 45228745 <<< DIFFERENT
 i6 A 453D9DD0 B 453D9DD0
 i7 A 4558B45C B 4558B45C
 i8 A 4573CAE8 B 4573CAE7 <<< DIFFERENT
 i9 A 458770B9 B 458770B9

 tile_height = 448.000000 (000001C0)
 scale = 1.019786 (3F828859)
 i0 A 43E46E9C B 43E46E9C
 i1 A 44646E9C B 44646E9C
 i2 A 44AB52F5 B 44AB52F5
 i3 A 44E46E9C B 44E46E9C
 i4 A 450EC522 B 450EC521 <<< DIFFERENT
 i5 A 452B52F4 B 452B52F5 <<< DIFFERENT
 i6 A 4547E0C8 B 4547E0C8
 i7 A 45646E9C B 45646E9C
 i8 A 45807E38 B 45807E38
 i9 A 458EC522 B 458EC521 <<< DIFFERENT

 tile_height = 448.000000 (000001C0)
 scale = 1.019785 (3F828850)
 i0 A 43E46E8C B 43E46E8C
 i1 A 44646E8C B 44646E8C
 i2 A 44AB52E9 B 44AB52E9
 i3 A 44E46E8C B 44E46E8C
 i4 A 450EC518 B 450EC518
 i5 A 452B52EA B 452B52E9 <<< DIFFERENT
 i6 A 4547E0BA B 4547E0BA
 i7 A 45646E8C B 45646E8C
 i8 A 45807E2F B 45807E2F
 i9 A 458EC518 B 458EC518

 tile_height = 448.000000 (000001C0)
 scale = 1.019775 (3F828800)
 i0 A 43E46E00 B 43E46E00
 i1 A 44646E00 B 44646E00
 i2 A 44AB5280 B 44AB5280
 i3 A 44E46E00 B 44E46E00
 i4 A 450EC4C0 B 450EC4C0
 i5 A 452B5280 B 452B5280
 i6 A 4547E040 B 4547E040
 i7 A 45646E00 B 45646E00
 i8 A 45807DE0 B 45807DE0
 i9 A 458EC4C0 B 458EC4C0

Comment 17 by vmi...@chromium.org, Jul 29 2016

Cc: enne@chromium.org

Comment 18 by ericrk@chromium.org, Jul 29 2016

Hmm - I think the secondary repro case I posted earlier is likely a different (but similar) bug, still a rounding error, but in this case just showing a difference between solid-color and regular tiles.

Comment 19 by msrchandra@chromium.org, Aug 8 2016

Labels: -ReleaseBlock-Stable
Re-tested the issue on Latest Chrome Canary# 54.0.2822.0 on Mac OS X 10.11.5 and is no more reproducible. Removing blocker label.
Thank You.

Comment 20 by erikc...@chromium.org, Aug 15 2016

Labels: ReleaseBlock-Stable
This seems like it should still be a blocker...

Comment 21 by bustamante@chromium.org, Aug 16 2016

Does this repro?  Per #19 we should close this bug unless it's still happening.

Comment 22 by ericrk@chromium.org, Aug 16 2016

This still repros for me. Have a fix in progress. Will update shortly.

Comment 23 by bugdroid1@chromium.org, Aug 18 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3

commit dfe9acda5549bd8c3442c411ffc4f8c76c0977f3
Author: ericrk <ericrk@chromium.org>
Date: Wed Aug 17 23:55:52 2016

Round GPU tiles to multiple of 64 to work around CA scaling issues

When scaling tiles using Core Animation, certain tile sizes / scale
factors appear to cause rounding issues and seams between tiles.

Rounding tiles to a multiple of 64 works around the
most obvious case of this, which is seen on the print preview screen.

BUG= 632274 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel

Review-Url: https://codereview.chromium.org/2251583002
Cr-Commit-Position: refs/heads/master@{#412698}

[modify] https://crrev.com/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3/third_party/WebKit/LayoutTests/TestExpectations

Comment 24 by bugdroid1@chromium.org, Aug 18 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e65bebf6c1baa0f8985a044f17833cea31845cea

commit e65bebf6c1baa0f8985a044f17833cea31845cea
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu Aug 18 01:41:20 2016

Auto-rebaseline for r412698

https://chromium.googlesource.com/chromium/src/+/dfe9acda5

BUG= 632274 
TBR=ericrk@chromium.org

Review URL: https://codereview.chromium.org/2251293002 .

Cr-Commit-Position: refs/heads/master@{#412721}

[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/12-55-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/182-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/2-dht-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/23-55-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/55-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-group-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-layer-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-group-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-layer-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/12-55-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/182-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/2-dht-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/23-55-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/55-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/color-profile-group-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/color-profile-layer-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png

Comment 25 by bugdroid1@chromium.org, Aug 18 2016

Project Member
Labels: merge-merged-2832
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e65bebf6c1baa0f8985a044f17833cea31845cea

commit e65bebf6c1baa0f8985a044f17833cea31845cea
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu Aug 18 01:41:20 2016

Auto-rebaseline for r412698

https://chromium.googlesource.com/chromium/src/+/dfe9acda5

BUG= 632274 
TBR=ericrk@chromium.org

Review URL: https://codereview.chromium.org/2251293002 .

Cr-Commit-Position: refs/heads/master@{#412721}

[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/12-55-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/182-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/2-dht-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/23-55-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/55-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-group-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-layer-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-group-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-layer-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/12-55-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/182-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/2-dht-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/23-55-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/55-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/color-profile-group-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/color-profile-layer-expected.png
[modify] https://crrev.com/e65bebf6c1baa0f8985a044f17833cea31845cea/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png

Comment 26 by bugdroid1@chromium.org, Aug 18 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3766281bcba2f7df11bf722c41c1c7eaf2bf0984

commit 3766281bcba2f7df11bf722c41c1c7eaf2bf0984
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu Aug 18 10:57:10 2016

Auto-rebaseline for r412762

https://chromium.googlesource.com/chromium/src/+/524ac838e

BUG= 632274 
TBR=rjwright@chromium.org

Review URL: https://codereview.chromium.org/2254133003 .

Cr-Commit-Position: refs/heads/master@{#412796}

[modify] https://crrev.com/3766281bcba2f7df11bf722c41c1c7eaf2bf0984/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/3766281bcba2f7df11bf722c41c1c7eaf2bf0984/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/12-55-expected.png
[modify] https://crrev.com/3766281bcba2f7df11bf722c41c1c7eaf2bf0984/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/182-expected.png
[modify] https://crrev.com/3766281bcba2f7df11bf722c41c1c7eaf2bf0984/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/2-dht-expected.png
[modify] https://crrev.com/3766281bcba2f7df11bf722c41c1c7eaf2bf0984/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/23-55-expected.png
[modify] https://crrev.com/3766281bcba2f7df11bf722c41c1c7eaf2bf0984/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/55-expected.png
[modify] https://crrev.com/3766281bcba2f7df11bf722c41c1c7eaf2bf0984/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/12-55-expected.png
[modify] https://crrev.com/3766281bcba2f7df11bf722c41c1c7eaf2bf0984/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/182-expected.png
[modify] https://crrev.com/3766281bcba2f7df11bf722c41c1c7eaf2bf0984/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/2-dht-expected.png
[modify] https://crrev.com/3766281bcba2f7df11bf722c41c1c7eaf2bf0984/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/23-55-expected.png
[modify] https://crrev.com/3766281bcba2f7df11bf722c41c1c7eaf2bf0984/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/55-expected.png

Comment 27 by bugdroid1@chromium.org, Aug 18 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fb4bd62e5d6e7c2aab32268659b20f02c164295

commit 8fb4bd62e5d6e7c2aab32268659b20f02c164295
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu Aug 18 12:04:52 2016

Auto-rebaseline for r412776

https://chromium.googlesource.com/chromium/src/+/197723886

BUG= 632274 
TBR=guidou@chromium.org

Review URL: https://codereview.chromium.org/2257493005 .

Cr-Commit-Position: refs/heads/master@{#412800}

[modify] https://crrev.com/8fb4bd62e5d6e7c2aab32268659b20f02c164295/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8fb4bd62e5d6e7c2aab32268659b20f02c164295/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-group-expected.png
[modify] https://crrev.com/8fb4bd62e5d6e7c2aab32268659b20f02c164295/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/8fb4bd62e5d6e7c2aab32268659b20f02c164295/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-layer-expected.png
[modify] https://crrev.com/8fb4bd62e5d6e7c2aab32268659b20f02c164295/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/8fb4bd62e5d6e7c2aab32268659b20f02c164295/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/8fb4bd62e5d6e7c2aab32268659b20f02c164295/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/8fb4bd62e5d6e7c2aab32268659b20f02c164295/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-group-expected.png
[modify] https://crrev.com/8fb4bd62e5d6e7c2aab32268659b20f02c164295/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/8fb4bd62e5d6e7c2aab32268659b20f02c164295/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-layer-expected.png
[modify] https://crrev.com/8fb4bd62e5d6e7c2aab32268659b20f02c164295/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/8fb4bd62e5d6e7c2aab32268659b20f02c164295/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/color-profile-group-expected.png
[modify] https://crrev.com/8fb4bd62e5d6e7c2aab32268659b20f02c164295/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/8fb4bd62e5d6e7c2aab32268659b20f02c164295/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/color-profile-layer-expected.png
[modify] https://crrev.com/8fb4bd62e5d6e7c2aab32268659b20f02c164295/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png

Comment 28 by bugdroid1@chromium.org, Aug 18 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08e75ec90d1ccdee72727cb4996dd269ad485c98

commit 08e75ec90d1ccdee72727cb4996dd269ad485c98
Author: ericrk <ericrk@chromium.org>
Date: Thu Aug 18 19:57:08 2016

Round GPU tiles to multiple of 64 to work around CA scaling issues

When scaling tiles using Core Animation, certain tile sizes / scale
factors appear to cause rounding issues and seams between tiles.

Rounding tiles to a multiple of 64 works around the
most obvious case of this, which is seen on the print preview screen.

BUG= 632274 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel

Committed: https://crrev.com/dfe9acda5549bd8c3442c411ffc4f8c76c0977f3
Review-Url: https://codereview.chromium.org/2251583002
Cr-Original-Commit-Position: refs/heads/master@{#412698}
Cr-Commit-Position: refs/heads/master@{#412917}

[modify] https://crrev.com/08e75ec90d1ccdee72727cb4996dd269ad485c98/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/08e75ec90d1ccdee72727cb4996dd269ad485c98/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/08e75ec90d1ccdee72727cb4996dd269ad485c98/third_party/WebKit/LayoutTests/TestExpectations

Comment 29 by ericrk@chromium.org, Aug 18 2016

Labels: Merge-Request-53 M-53

Comment 30 by bugdroid1@chromium.org, Aug 18 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04b34c5b44ca02422c6d2af075e144abab670ff6

commit 04b34c5b44ca02422c6d2af075e144abab670ff6
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu Aug 18 22:15:57 2016

Auto-rebaseline for r412917

https://chromium.googlesource.com/chromium/src/+/08e75ec90

BUG= 632274 
TBR=ericrk@chromium.org

Review URL: https://codereview.chromium.org/2262553002 .

Cr-Commit-Position: refs/heads/master@{#412955}

[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/12-55-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/182-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/2-dht-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/23-55-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/55-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-group-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-layer-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-group-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-image-canvas-pattern-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-layer-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-svg-fill-text-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/12-55-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/182-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/2-dht-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/23-55-expected.png
[modify] https://crrev.com/04b34c5b44ca02422c6d2af075e144abab670ff6/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/55-expected.png

Comment 31 by dimu@chromium.org, Aug 19 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)

Comment 32 by gov...@chromium.org, Aug 19 2016

Please try to merge your change to M53 branch 2785 today before 4:00 PM PT on Monday so we can pick it up for next week LAST M53 beta release. Thank you.

Comment 33 by bugdroid1@chromium.org, Aug 20 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55f181c683f26d1d43f264367363790a802e096d

commit 55f181c683f26d1d43f264367363790a802e096d
Author: ericrk <ericrk@chromium.org>
Date: Sat Aug 20 02:34:50 2016

Change GPU Tile rounding to 32

Rounding to 64 was done to match SW, but this leads to android
memory regressions. Use 32 instead, which still fixes the Core
Animation issue, but doesn’t regress memory as much.

BUG= 632274 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2258343002
Cr-Commit-Position: refs/heads/master@{#413310}

[modify] https://crrev.com/55f181c683f26d1d43f264367363790a802e096d/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/55f181c683f26d1d43f264367363790a802e096d/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/55f181c683f26d1d43f264367363790a802e096d/third_party/WebKit/LayoutTests/TestExpectations

Comment 35 by bugdroid1@chromium.org, Aug 22 2016

Project Member
Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73b770a74b832456dc2d64bc3820fa300c14e457

commit 73b770a74b832456dc2d64bc3820fa300c14e457
Author: Eric Karl <ericrk@chromium.org>
Date: Mon Aug 22 17:44:16 2016

Change GPU Tile rounding to 32

Rounding to 64 was done to match SW, but this leads to android
memory regressions. Use 32 instead, which still fixes the Core
Animation issue, but doesn’t regress memory as much.

BUG= 632274 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2258343002
Cr-Commit-Position: refs/heads/master@{#413310}
(cherry picked from commit 55f181c683f26d1d43f264367363790a802e096d)

Review URL: https://codereview.chromium.org/2268643002 .

Cr-Commit-Position: refs/branch-heads/2785@{#706}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/73b770a74b832456dc2d64bc3820fa300c14e457/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/73b770a74b832456dc2d64bc3820fa300c14e457/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/73b770a74b832456dc2d64bc3820fa300c14e457/third_party/WebKit/LayoutTests/TestExpectations

Comment 36 by gov...@chromium.org, Aug 22 2016

A friendly reminder that M53 Stable is launching VERY soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP (before 5:00 PM PT, Tuesday) so we can take it for this week LAST Beta release for Desktop. Thank you!

Note: Merge has to happen by Friday, August 26th, 5:00 PM PST in order to make into the desktop Stable final build cut.

Comment 37 by ericrk@chromium.org, Aug 23 2016

Status: Fixed (was: Assigned)

Comment 38 by tkonch...@chromium.org, Aug 24 2016

Cc: tkonch...@chromium.org
Labels: TE-Verified-M53 TE-Verified-53.0.2785.80
Tested the same on mac 10.11.6 chrome version 53.0.2785.80 - Weird black line is not seen on print preview after clicking on pdf page

Please find the screencast

Adding TE verified labels
632274.mov
16.1 MB Download

Sign in to add a comment