Non-regression: Abnormal behavior is seen on clicking New folder button continuously in Save as dialog |
|||||||||||||||||||||||||
Issue descriptionVersion: 54.0.2806.0/8639.0.0 dev channel falco,gnawty,spring. OS: Chrome os What steps will reproduce the problem? (1) Sign in to user >> Right click on any image/link and select save as from context menu (2) Now in "Save file as" dialog box click New folder continuously until you see "The directory named "Newfolder(x)" already existes. Please choose a different name. >> Click on Ok button (3) Now click on Open button and observe Here there are many issues. 1. After clicking on Open button both folders and Nothing to see here message is seen. 2. Try scrolling down and observe -- Some folders are seen vanished on scrolling. 3. Observe number of folders in left navigation bar and in right area[ Some folders are seen missing in right]. 4. Click on thumbnail view/list view button and observe for folders Raising this as Non-regression issue as same behavior is seen in 47.0.2526.106/7520.63.0 stable channel daisy. @fukino: Please confirm the behavior.
,
Aug 18 2016
Confirmed the issue. The "NEW FOLDER" button should not be clickable until renaming folder is done. This is the root cause of these issues. I'll fix it.
,
Aug 18 2016
Issue 638842 can also triggers the issue. I'll fix Issue 638842 too (by a separate CL.)
,
Aug 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fd6345280201363f55fc62ab6509842fa241042 commit 7fd6345280201363f55fc62ab6509842fa241042 Author: fukino <fukino@chromium.org> Date: Thu Aug 18 13:31:25 2016 Files app: Ignores pointer events on buttons on dialog footer. We should ignore pointer events on disabled buttons. It prevents unexpected command dispatches, and it is consistent with paper-button. BUG= 632270 TEST=manually Review-Url: https://codereview.chromium.org/2256143002 Cr-Commit-Position: refs/heads/master@{#412812} [modify] https://crrev.com/7fd6345280201363f55fc62ab6509842fa241042/ui/file_manager/file_manager/foreground/css/file_manager.css
,
Aug 23 2016
Checked the issue on 54.0.2831.0/8731.0.0 (Official Build) dev-channel daisy as per steps mentioned in Comment#0 and is still reproducible. @fukino: Could you please tell which build contains the fix. Thanks!
,
Aug 23 2016
Issue 638842 can cause the same issue, and it isn't fixed yet. After Issue 638842 is fixed, I'll mark this issue fixed too.
,
Sep 8 2016
,
Sep 8 2016
,
Oct 28 2016
,
Dec 8 2016
,
Dec 8 2016
,
Feb 24 2018
,
Feb 28 2018
,
Feb 28 2018
,
Mar 20 2018
Able to repro.
,
Apr 19 2018
,
Nov 7
,
Nov 21
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fed0f06fe21141b9998c48ecd4085145e5375c3 commit 9fed0f06fe21141b9998c48ecd4085145e5375c3 Author: Sam McNally <sammc@chromium.org> Date: Wed Nov 21 10:02:58 2018 Add mutual exclusion to new-folder command execution. Rapidly clicking on the new folder button in the files app acting as a save-as dialog can cause multiple flows through that process (from pressing the button through to completing the rename) to run concurrently. This can cause some strange effects: - reporting that the directory already exists, despite the name intending to be unique; - getting stuck a state renaming a newly-created directory that hasn't been rendered into the file list, causing the app to be effectively unresponsive. Avoid these problems by disallowing execution of the new-folder command while another is in progress. Bug: 632270 Change-Id: I48eb43197403bf85ac78e42a6361c972499b008c Reviewed-on: https://chromium-review.googlesource.com/c/1345687 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#609978} [modify] https://crrev.com/9fed0f06fe21141b9998c48ecd4085145e5375c3/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
,
Nov 21
,
Nov 27
Issue 824703 has been merged into this issue. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by durga.behera@chromium.org
, Jul 28 2016