New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 632269 link

Starred by 4 users
Status: Fixed
Owner:
dominickn@chromium.org
Closed: Nov 2017
Cc:
█ kcaratt...@chromium.org
emilyschechter@chromium.org
battre@chromium.org
█ raymes@chromium.org
█ tsergeant@chromium.org
█ f...@chromium.org
benwells@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Team-Security-UX

Blocking:
issue 760319


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

Permission prompt UX experiments

Project Member Reported by dominickn@chromium.org, Jul 28 2016 
This is a bug which summarises upcoming experiments with permission prompt UX, including:

 - auto-blocking prompts after X dismissals
 - adding optional persistence via a checkbox in prompts
 - changing the emphasis of the origin in the prompt

Comment 1 by battre@chromium.org, Aug 2 2016

Cc: battre@chromium.org

Comment 2 by dominickn@chromium.org, Aug 10 2016 

Screenshot attached of a permission prompt on Android with a "Remember my decision" toggle.

One implication of toggling persistence off is that when a user navigates, the permission decision is forgotten and if the site asks for permission again, another prompt will be shown. Perhaps this will encourage users to make a permanent decision?
Screenshot_20160808-174859.png
106 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6947d75c181dc3f7484b77c25ba053cbda75fbe1

commit 6947d75c181dc3f7484b77c25ba053cbda75fbe1
Author: dominickn <dominickn@chromium.org>
Date: Wed Aug 10 02:00:06 2016

Add a feature which, when enabled, blocks permissions after X prompt dismissals.

This CL implements automatic permission blocking after a user has
dismissed a prompt a certain number of times (3 by default). This is
gated behind a feature which is disabled by default. The number of
dismissals required to trigger the blocking is controllable via a
variation parameter. Additional unittests are added to ensure this
behaves as expected, with and without custom parameters from
variations.

This CL also adds a hook to BrowsingDataRemover to remove the
counts when the user clears their site data. Unittests for this are
also implemented.

At each dismiss|ignore of a permission prompt, the number
of preceding dismissals|ignores is logged to UMA so we can
sample how many users are repeatedly dismissing prompts or
repeatedly ignoring prompts.

It is intended to gather metrics (and potentially experiment with)
the dismissal switch starting with M54 on stable to observe whether
it improves permission prompt UX and decision rates.

BUG= 632269 

Review-Url: https://codereview.chromium.org/2184823007
Cr-Commit-Position: refs/heads/master@{#410920}

[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/browser/browsing_data/browsing_data_remover.cc
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/browser/permissions/permission_context_base.h
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/browser/permissions/permission_context_base_unittest.cc
[add] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/browser/permissions/permission_decision_auto_blocker.cc
[add] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/browser/permissions/permission_decision_auto_blocker.h
[add] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/browser/permissions/permission_infobar_delegate.cc
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/browser/permissions/permission_request_impl.cc
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/browser/permissions/permission_request_impl.h
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/browser/permissions/permission_uma_util.h
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/chrome_browser.gypi
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/common/chrome_features.cc
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/chrome/common/chrome_features.h
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/components/content_settings/core/browser/website_settings_registry.cc
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/components/content_settings/core/common/content_settings.cc
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/components/content_settings/core/common/content_settings_types.h
[modify] https://crrev.com/6947d75c181dc3f7484b77c25ba053cbda75fbe1/tools/metrics/histograms/histograms.xml

Comment 4 by f...@chromium.org, Aug 15 2016 

woo! exciting to see this experiment land!
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6957a9ca3f6db210572d6b54dcbcf69baeb978fd

commit 6957a9ca3f6db210572d6b54dcbcf69baeb978fd
Author: dominickn <dominickn@chromium.org>
Date: Tue Aug 16 06:06:36 2016

Add a feature to display a persistence toggle for permission prompts on Android.

This CL adds a disabled by default feature which shows a "Remember my
decision" toggle on permission prompts on Android. This is designed to
test whether a more explicit representation of permission persistence
(and better control over it) will encourage users to make decisions on
these prompts more often. It is intended to experiment with this
feature from M54.

A new PermissionInfoBar class is added to implement the optional
toggle. Permission-specific code in ConfirmInfoBar is moved into the
new class, which will also be beneficial in the future if permission
prompts stop being infobars. The permission decision is changed
from a boolean allowed/not allowed to the PermissionAction enum
already used for permission metrics reporting.

New metrics to measure the toggle position of prompts which are
granted or denied are also added in this CL to measure whether or
not users actually interact with the toggle (or if merely seeing it
is sufficient to change the wider permission action metrics).

The toggle is explicitly disabled for all permissions except
geolocation, which currently generates the most prompts on Android.

A subsequent CL will implement a corresponding checkbox for
desktop permission prompts using the same feature. The desktop
permission decision will also be changed to a PermissionAction.

BUG= 632269 

Review-Url: https://codereview.chromium.org/2226633002
Cr-Commit-Position: refs/heads/master@{#412177}

[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/android/java/res/values/ids.xml
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/android/java/src/org/chromium/chrome/browser/infobar/GroupedPermissionInfoBar.java
[add] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/android/java_sources.gni
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/geolocation/geolocation_infobar_delegate_android.h
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/media/midi_permission_infobar_delegate_android.cc
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/media/protected_media_identifier_infobar_delegate_android.cc
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/notifications/notification_permission_infobar_delegate.cc
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/notifications/notification_permission_infobar_delegate.h
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/permissions/permission_context_base_unittest.cc
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/permissions/permission_infobar_delegate.cc
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/permissions/permission_infobar_delegate.h
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/permissions/permission_queue_controller.cc
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/permissions/permission_queue_controller.h
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/permissions/permission_uma_util.h
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/permissions/permission_util.h
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/ui/android/infobars/confirm_infobar.cc
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/ui/android/infobars/confirm_infobar.h
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/ui/android/infobars/infobar_android.h
[add] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/ui/android/infobars/permission_infobar.cc
[add] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/browser/ui/android/infobars/permission_infobar.h
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/chrome_browser.gypi
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/common/chrome_features.cc
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/chrome/common/chrome_features.h
[modify] https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd/tools/metrics/histograms/histograms.xml

Comment 6 by dominickn@chromium.org, Aug 16 2016 

@emilyschechter: should we start looking at the launch approvals required for M54? I can create independent bugs for the separate experiments if needed.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fddca1b8dc2abf1733e1ce4640e915d1c19aa16

commit 0fddca1b8dc2abf1733e1ce4640e915d1c19aa16
Author: dominickn <dominickn@chromium.org>
Date: Wed Aug 17 23:48:20 2016

Add tests for the geolocation prompt with persistence switch on Android.

This CL explicitly enables the persistence toggle for geolocation
prompts on Android, and tests geolocation requests with the toggle on
and off.

BUG= 632269 

Review-Url: https://codereview.chromium.org/2251673002
Cr-Commit-Position: refs/heads/master@{#412695}

[modify] https://crrev.com/0fddca1b8dc2abf1733e1ce4640e915d1c19aa16/chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6da2b3835157a2178a5951ff42f2e1a7d3404608

commit 6da2b3835157a2178a5951ff42f2e1a7d3404608
Author: dominickn <dominickn@chromium.org>
Date: Tue Aug 23 20:21:30 2016

Add prior dismissal and ignore count metrics for all permission actions.

This CL removes the recently added Permission.Prompt.DismissCount and
Permission.Prompt.IgnoreCount metrics, and replaces them with
equivalents over all permission actions (Accept, Deny, Dismiss, and
Ignore). The metrics are now defined strictly as the number of prompt
dismissals and ignores prior to (rather than inclusive of) the current
action for consistency with permission action reporting. Additional
histogram tests are added to verify that the metrics are recorded.

BUG= 632269 , 638076 

Review-Url: https://codereview.chromium.org/2250993002
Cr-Commit-Position: refs/heads/master@{#413827}

[modify] https://crrev.com/6da2b3835157a2178a5951ff42f2e1a7d3404608/chrome/browser/permissions/permission_context_base_unittest.cc
[modify] https://crrev.com/6da2b3835157a2178a5951ff42f2e1a7d3404608/chrome/browser/permissions/permission_decision_auto_blocker.cc
[modify] https://crrev.com/6da2b3835157a2178a5951ff42f2e1a7d3404608/chrome/browser/permissions/permission_decision_auto_blocker.h
[modify] https://crrev.com/6da2b3835157a2178a5951ff42f2e1a7d3404608/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/6da2b3835157a2178a5951ff42f2e1a7d3404608/chrome/browser/permissions/permission_uma_util.h
[modify] https://crrev.com/6da2b3835157a2178a5951ff42f2e1a7d3404608/tools/metrics/histograms/histograms.xml
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fea9c39c10d391e8b03b77b39b889c54a96a9b5c

commit fea9c39c10d391e8b03b77b39b889c54a96a9b5c
Author: dominickn <dominickn@chromium.org>
Date: Wed Aug 24 03:32:37 2016

Enable the optional permission prompt persistence toggle on grouped infobars

This CL adds support for the feature enabling a persistence toggle on
permission prompts to grouped permission infobars. The toggle is only
shown if an enabling feature is active. Grouped bars are used exclusively
for media permissions, so this change allows the toggle to be shown
when a single and multiple media permissions are requested.

New Android UI tests for responding to the permission prompts triggered
by getUserMedia are added to verify the toggle behaviour. The persistence
boolean in media_stream_devices_controller is renamed in preparation for
upstreaming it into PermissionRequest.

BUG= 632269 

Review-Url: https://codereview.chromium.org/2254763002
Cr-Commit-Position: refs/heads/master@{#413970}

[modify] https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c/chrome/android/BUILD.gn
[modify] https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c/chrome/android/java/src/org/chromium/chrome/browser/infobar/GroupedPermissionInfoBar.java
[modify] https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java
[modify] https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c/chrome/android/java_sources.gni
[add] https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/MediaPermissionsTest.java
[modify] https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c/chrome/browser/media/media_stream_devices_controller.cc
[modify] https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c/chrome/browser/media/media_stream_devices_controller.h
[modify] https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c/chrome/browser/media/media_stream_infobar_delegate_android.cc
[modify] https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c/chrome/browser/media/media_stream_infobar_delegate_android.h
[modify] https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c/chrome/browser/permissions/grouped_permission_infobar_delegate.cc
[modify] https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c/chrome/browser/permissions/grouped_permission_infobar_delegate.h
[modify] https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c/chrome/browser/ui/android/infobars/grouped_permission_infobar.cc
[modify] https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c/chrome/browser/ui/android/infobars/grouped_permission_infobar.h
[add] https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c/content/test/data/android/media_permissions.html
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1350bf5a9407c705530515b61ac1dfcbc0830cb

commit c1350bf5a9407c705530515b61ac1dfcbc0830cb
Author: bauerb <bauerb@chromium.org>
Date: Wed Aug 24 11:49:25 2016

Revert of Enable the optional permission prompt persistence toggle on grouped infobars (patchset #12 id:220001 of https://codereview.chromium.org/2254763002/ )

Reason for revert:
Breaks on Android testers (https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/30964)

BUG= 640580 

Original issue's description:
> Enable the optional permission prompt persistence toggle on grouped infobars
>
> This CL adds support for the feature enabling a persistence toggle on
> permission prompts to grouped permission infobars. The toggle is only
> shown if an enabling feature is active. Grouped bars are used exclusively
> for media permissions, so this change allows the toggle to be shown
> when a single and multiple media permissions are requested.
>
> New Android UI tests for responding to the permission prompts triggered
> by getUserMedia are added to verify the toggle behaviour. The persistence
> boolean in media_stream_devices_controller is renamed in preparation for
> upstreaming it into PermissionRequest.
>
> BUG= 632269 
>
> Committed: https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c
> Cr-Commit-Position: refs/heads/master@{#413970}

TBR=dfalcantara@chromium.org,raymes@chromium.org,kcarattini@chromium.org,xhwang@chromium.org,dominickn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 632269 

Review-Url: https://codereview.chromium.org/2277733002
Cr-Commit-Position: refs/heads/master@{#414047}

[modify] https://crrev.com/c1350bf5a9407c705530515b61ac1dfcbc0830cb/chrome/android/BUILD.gn
[modify] https://crrev.com/c1350bf5a9407c705530515b61ac1dfcbc0830cb/chrome/android/java/src/org/chromium/chrome/browser/infobar/GroupedPermissionInfoBar.java
[modify] https://crrev.com/c1350bf5a9407c705530515b61ac1dfcbc0830cb/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java
[modify] https://crrev.com/c1350bf5a9407c705530515b61ac1dfcbc0830cb/chrome/android/java_sources.gni
[delete] https://crrev.com/9459688bc2e14e90d28550e7a8d32e85033de01b/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/MediaPermissionsTest.java
[modify] https://crrev.com/c1350bf5a9407c705530515b61ac1dfcbc0830cb/chrome/browser/media/media_stream_devices_controller.cc
[modify] https://crrev.com/c1350bf5a9407c705530515b61ac1dfcbc0830cb/chrome/browser/media/media_stream_devices_controller.h
[modify] https://crrev.com/c1350bf5a9407c705530515b61ac1dfcbc0830cb/chrome/browser/media/media_stream_infobar_delegate_android.cc
[modify] https://crrev.com/c1350bf5a9407c705530515b61ac1dfcbc0830cb/chrome/browser/media/media_stream_infobar_delegate_android.h
[modify] https://crrev.com/c1350bf5a9407c705530515b61ac1dfcbc0830cb/chrome/browser/permissions/grouped_permission_infobar_delegate.cc
[modify] https://crrev.com/c1350bf5a9407c705530515b61ac1dfcbc0830cb/chrome/browser/permissions/grouped_permission_infobar_delegate.h
[modify] https://crrev.com/c1350bf5a9407c705530515b61ac1dfcbc0830cb/chrome/browser/ui/android/infobars/grouped_permission_infobar.cc
[modify] https://crrev.com/c1350bf5a9407c705530515b61ac1dfcbc0830cb/chrome/browser/ui/android/infobars/grouped_permission_infobar.h
[delete] https://crrev.com/9459688bc2e14e90d28550e7a8d32e85033de01b/content/test/data/android/media_permissions.html
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23b2a5192ee77dd842b3e79575d586743364b32

commit c23b2a5192ee77dd842b3e79575d586743364b32
Author: dominickn <dominickn@chromium.org>
Date: Mon Sep 12 05:32:42 2016

Enable the optional permission prompt persistence toggle on grouped infobars

This CL adds support for the feature enabling a persistence toggle on
permission prompts to grouped permission infobars. The toggle is only
shown if an enabling feature is active. Grouped bars are used exclusively
for media permissions, so this change allows the toggle to be shown
when a single and multiple media permissions are requested.

New Android UI tests for responding to the permission prompts triggered
by getUserMedia are added to verify the toggle behaviour. The persistence
boolean in media_stream_devices_controller is renamed in preparation for
upstreaming it into PermissionRequest.

BUG= 632269 

Committed: https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c
Review-Url: https://codereview.chromium.org/2254763002
Cr-Original-Commit-Position: refs/heads/master@{#413970}
Cr-Commit-Position: refs/heads/master@{#417870}

[modify] https://crrev.com/c23b2a5192ee77dd842b3e79575d586743364b32/chrome/android/BUILD.gn
[modify] https://crrev.com/c23b2a5192ee77dd842b3e79575d586743364b32/chrome/android/java/src/org/chromium/chrome/browser/infobar/GroupedPermissionInfoBar.java
[modify] https://crrev.com/c23b2a5192ee77dd842b3e79575d586743364b32/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java
[modify] https://crrev.com/c23b2a5192ee77dd842b3e79575d586743364b32/chrome/android/java_sources.gni
[add] https://crrev.com/c23b2a5192ee77dd842b3e79575d586743364b32/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/MediaPermissionsTest.java
[modify] https://crrev.com/c23b2a5192ee77dd842b3e79575d586743364b32/chrome/browser/media/webrtc/media_stream_devices_controller.cc
[modify] https://crrev.com/c23b2a5192ee77dd842b3e79575d586743364b32/chrome/browser/media/webrtc/media_stream_devices_controller.h
[modify] https://crrev.com/c23b2a5192ee77dd842b3e79575d586743364b32/chrome/browser/media/webrtc/media_stream_infobar_delegate_android.cc
[modify] https://crrev.com/c23b2a5192ee77dd842b3e79575d586743364b32/chrome/browser/media/webrtc/media_stream_infobar_delegate_android.h
[modify] https://crrev.com/c23b2a5192ee77dd842b3e79575d586743364b32/chrome/browser/permissions/grouped_permission_infobar_delegate.cc
[modify] https://crrev.com/c23b2a5192ee77dd842b3e79575d586743364b32/chrome/browser/permissions/grouped_permission_infobar_delegate.h
[modify] https://crrev.com/c23b2a5192ee77dd842b3e79575d586743364b32/chrome/browser/ui/android/infobars/grouped_permission_infobar.cc
[modify] https://crrev.com/c23b2a5192ee77dd842b3e79575d586743364b32/chrome/browser/ui/android/infobars/grouped_permission_infobar.h
[add] https://crrev.com/c23b2a5192ee77dd842b3e79575d586743364b32/content/test/data/android/media_permissions.html
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee

commit a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee
Author: dominickn <dominickn@chromium.org>
Date: Mon Sep 12 07:00:46 2016

Revert of Enable the optional permission prompt persistence toggle on grouped infobars (patchset #13 id:240001 of https://codereview.chromium.org/2254763002/ )

Reason for revert:
This still breaks the Android Tests bot.

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/31799

Original issue's description:
> Enable the optional permission prompt persistence toggle on grouped infobars
>
> This CL adds support for the feature enabling a persistence toggle on
> permission prompts to grouped permission infobars. The toggle is only
> shown if an enabling feature is active. Grouped bars are used exclusively
> for media permissions, so this change allows the toggle to be shown
> when a single and multiple media permissions are requested.
>
> New Android UI tests for responding to the permission prompts triggered
> by getUserMedia are added to verify the toggle behaviour. The persistence
> boolean in media_stream_devices_controller is renamed in preparation for
> upstreaming it into PermissionRequest.
>
> BUG= 632269 
>
> Committed: https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c
> Committed: https://crrev.com/c23b2a5192ee77dd842b3e79575d586743364b32
> Cr-Original-Commit-Position: refs/heads/master@{#413970}
> Cr-Commit-Position: refs/heads/master@{#417870}

TBR=dfalcantara@chromium.org,raymes@chromium.org,kcarattini@chromium.org,xhwang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 632269 

Review-Url: https://codereview.chromium.org/2332663002
Cr-Commit-Position: refs/heads/master@{#417881}

[modify] https://crrev.com/a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee/chrome/android/BUILD.gn
[modify] https://crrev.com/a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee/chrome/android/java/src/org/chromium/chrome/browser/infobar/GroupedPermissionInfoBar.java
[modify] https://crrev.com/a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java
[modify] https://crrev.com/a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee/chrome/android/java_sources.gni
[delete] https://crrev.com/cd61c6bf95b3770211a18cc6f24dd990b9c3bcb4/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/MediaPermissionsTest.java
[modify] https://crrev.com/a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee/chrome/browser/media/webrtc/media_stream_devices_controller.cc
[modify] https://crrev.com/a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee/chrome/browser/media/webrtc/media_stream_devices_controller.h
[modify] https://crrev.com/a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee/chrome/browser/media/webrtc/media_stream_infobar_delegate_android.cc
[modify] https://crrev.com/a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee/chrome/browser/media/webrtc/media_stream_infobar_delegate_android.h
[modify] https://crrev.com/a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee/chrome/browser/permissions/grouped_permission_infobar_delegate.cc
[modify] https://crrev.com/a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee/chrome/browser/permissions/grouped_permission_infobar_delegate.h
[modify] https://crrev.com/a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee/chrome/browser/ui/android/infobars/grouped_permission_infobar.cc
[modify] https://crrev.com/a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee/chrome/browser/ui/android/infobars/grouped_permission_infobar.h
[delete] https://crrev.com/cd61c6bf95b3770211a18cc6f24dd990b9c3bcb4/content/test/data/android/media_permissions.html
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd008ac9abf59ac99681381b297e00652c285246

commit fd008ac9abf59ac99681381b297e00652c285246
Author: dominickn <dominickn@chromium.org>
Date: Mon Sep 12 23:45:41 2016

Enable the optional permission prompt persistence toggle on grouped infobars

This CL adds support for the feature enabling a persistence toggle on
permission prompts to grouped permission infobars. The toggle is only
shown if an enabling feature is active. Grouped bars are used exclusively
for media permissions, so this change allows the toggle to be shown
when a single and multiple media permissions are requested.

New Android UI tests for responding to the permission prompts triggered
by getUserMedia are added to verify the toggle behaviour. The persistence
boolean in media_stream_devices_controller is renamed in preparation for
upstreaming it into PermissionRequest.

BUG= 632269 

Review-Url: https://codereview.chromium.org/2254763002
Cr-Commit-Position: refs/heads/master@{#418107}

[modify] https://crrev.com/fd008ac9abf59ac99681381b297e00652c285246/chrome/android/BUILD.gn
[modify] https://crrev.com/fd008ac9abf59ac99681381b297e00652c285246/chrome/android/java/src/org/chromium/chrome/browser/infobar/GroupedPermissionInfoBar.java
[modify] https://crrev.com/fd008ac9abf59ac99681381b297e00652c285246/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java
[modify] https://crrev.com/fd008ac9abf59ac99681381b297e00652c285246/chrome/android/java_sources.gni
[add] https://crrev.com/fd008ac9abf59ac99681381b297e00652c285246/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/MediaPermissionsTest.java
[modify] https://crrev.com/fd008ac9abf59ac99681381b297e00652c285246/chrome/browser/media/webrtc/media_stream_devices_controller.cc
[modify] https://crrev.com/fd008ac9abf59ac99681381b297e00652c285246/chrome/browser/media/webrtc/media_stream_devices_controller.h
[modify] https://crrev.com/fd008ac9abf59ac99681381b297e00652c285246/chrome/browser/media/webrtc/media_stream_infobar_delegate_android.cc
[modify] https://crrev.com/fd008ac9abf59ac99681381b297e00652c285246/chrome/browser/media/webrtc/media_stream_infobar_delegate_android.h
[modify] https://crrev.com/fd008ac9abf59ac99681381b297e00652c285246/chrome/browser/permissions/grouped_permission_infobar_delegate.cc
[modify] https://crrev.com/fd008ac9abf59ac99681381b297e00652c285246/chrome/browser/permissions/grouped_permission_infobar_delegate.h
[modify] https://crrev.com/fd008ac9abf59ac99681381b297e00652c285246/chrome/browser/ui/android/infobars/grouped_permission_infobar.cc
[modify] https://crrev.com/fd008ac9abf59ac99681381b297e00652c285246/chrome/browser/ui/android/infobars/grouped_permission_infobar.h
[add] https://crrev.com/fd008ac9abf59ac99681381b297e00652c285246/content/test/data/android/media_permissions.html
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4e446a9c0944eb6748eceaf036f94dfc17acbb4

commit d4e446a9c0944eb6748eceaf036f94dfc17acbb4
Author: dominickn <dominickn@chromium.org>
Date: Tue Sep 13 07:44:13 2016

Add a feature-controlled persistence checkbox to geolocation prompts on desktop Views platforms.

This CL allows geolocation permission prompts to show a checkbox to
allow the user to optionally persist their decision. It is intended to
use this to gather metrics on whether users are more likely to make
a decision on a permission prompt when presented with more information
regarding how long the decision will last.

Additional tests in the permission layer are added to verify the
optional persistence.

BUG= 632269 

Review-Url: https://codereview.chromium.org/2258763002
Cr-Commit-Position: refs/heads/master@{#418189}

[modify] https://crrev.com/d4e446a9c0944eb6748eceaf036f94dfc17acbb4/chrome/app/generated_resources.grd
[modify] https://crrev.com/d4e446a9c0944eb6748eceaf036f94dfc17acbb4/chrome/browser/media/webrtc/media_stream_devices_controller.cc
[modify] https://crrev.com/d4e446a9c0944eb6748eceaf036f94dfc17acbb4/chrome/browser/media/webrtc/media_stream_devices_controller.h
[modify] https://crrev.com/d4e446a9c0944eb6748eceaf036f94dfc17acbb4/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/d4e446a9c0944eb6748eceaf036f94dfc17acbb4/chrome/browser/permissions/permission_context_base_unittest.cc
[modify] https://crrev.com/d4e446a9c0944eb6748eceaf036f94dfc17acbb4/chrome/browser/permissions/permission_request.cc
[modify] https://crrev.com/d4e446a9c0944eb6748eceaf036f94dfc17acbb4/chrome/browser/permissions/permission_request.h
[modify] https://crrev.com/d4e446a9c0944eb6748eceaf036f94dfc17acbb4/chrome/browser/permissions/permission_request_impl.cc
[modify] https://crrev.com/d4e446a9c0944eb6748eceaf036f94dfc17acbb4/chrome/browser/permissions/permission_request_impl.h
[modify] https://crrev.com/d4e446a9c0944eb6748eceaf036f94dfc17acbb4/chrome/browser/permissions/permission_request_manager.cc
[modify] https://crrev.com/d4e446a9c0944eb6748eceaf036f94dfc17acbb4/chrome/browser/permissions/permission_request_manager.h
[modify] https://crrev.com/d4e446a9c0944eb6748eceaf036f94dfc17acbb4/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
[modify] https://crrev.com/d4e446a9c0944eb6748eceaf036f94dfc17acbb4/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
[modify] https://crrev.com/d4e446a9c0944eb6748eceaf036f94dfc17acbb4/chrome/browser/ui/views/website_settings/permission_prompt_impl.h
[modify] https://crrev.com/d4e446a9c0944eb6748eceaf036f94dfc17acbb4/chrome/browser/ui/website_settings/permission_bubble_browser_test_util.h
[modify] https://crrev.com/d4e446a9c0944eb6748eceaf036f94dfc17acbb4/chrome/browser/ui/website_settings/permission_prompt.h

Comment 15 by dominickn@chromium.org, Sep 15 2016

Labels: Merge-Request-54
Requesting merge of #13 and #14 to M54.

#13 originally landed before M54 branch point, but was reverted several times due to a confusing issue where the tests it introduced failed on one set of builders. #14 depended on #13, so it couldn't land until the first one stuck.

Both have made it through to Canary now.

Comment 16 by dimu@chromium.org, Sep 15 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 15 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02449fec721e22762d322bc204274677d01bd035

commit 02449fec721e22762d322bc204274677d01bd035
Author: Dominick Ng <dominickn@chromium.org>
Date: Thu Sep 15 04:15:47 2016

Enable the optional permission prompt persistence toggle on grouped infobars

This CL adds support for the feature enabling a persistence toggle on
permission prompts to grouped permission infobars. The toggle is only
shown if an enabling feature is active. Grouped bars are used exclusively
for media permissions, so this change allows the toggle to be shown
when a single and multiple media permissions are requested.

New Android UI tests for responding to the permission prompts triggered
by getUserMedia are added to verify the toggle behaviour. The persistence
boolean in media_stream_devices_controller is renamed in preparation for
upstreaming it into PermissionRequest.

BUG= 632269 

Review-Url: https://codereview.chromium.org/2254763002
Cr-Commit-Position: refs/heads/master@{#418107}
(cherry picked from commit fd008ac9abf59ac99681381b297e00652c285246)

Review URL: https://codereview.chromium.org/2342003002 .

Cr-Commit-Position: refs/branch-heads/2840@{#373}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/android/BUILD.gn
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/android/java/src/org/chromium/chrome/browser/infobar/GroupedPermissionInfoBar.java
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/android/java_sources.gni
[add] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/MediaPermissionsTest.java
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/browser/media/media_stream_devices_controller.cc
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/browser/media/media_stream_devices_controller.h
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/browser/media/media_stream_infobar_delegate_android.cc
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/browser/media/media_stream_infobar_delegate_android.h
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/browser/permissions/grouped_permission_infobar_delegate.cc
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/browser/permissions/grouped_permission_infobar_delegate.h
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/browser/ui/android/infobars/grouped_permission_infobar.cc
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/browser/ui/android/infobars/grouped_permission_infobar.h
[add] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/content/test/data/android/media_permissions.html
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2726ec8f91d0c790aa924daf017675d3ebbe164

commit c2726ec8f91d0c790aa924daf017675d3ebbe164
Author: dominickn <dominickn@chromium.org>
Date: Thu Sep 15 12:15:39 2016

Improve permission persistence tests.

This CL adds a browser test for desktop geolocation where persistence is
toggled off, ensuring that the underlying content setting isn't changed.
Additional checks of the content setting are added to the existing grant
and block tests.

This CL also simplifies the feature list setting used in the
PermissionContextBase test.

BUG= 632269 

Review-Url: https://codereview.chromium.org/2338173002
Cr-Commit-Position: refs/heads/master@{#418841}

[modify] https://crrev.com/c2726ec8f91d0c790aa924daf017675d3ebbe164/chrome/browser/geolocation/geolocation_browsertest.cc
[modify] https://crrev.com/c2726ec8f91d0c790aa924daf017675d3ebbe164/chrome/browser/permissions/permission_context_base_unittest.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58c416bd91c9279110d61da469184449365038fd

commit 58c416bd91c9279110d61da469184449365038fd
Author: Dominick Ng <dominickn@chromium.org>
Date: Fri Sep 16 02:01:25 2016

Add a feature-controlled persistence checkbox to geolocation prompts on desktop Views platforms.

This CL allows geolocation permission prompts to show a checkbox to
allow the user to optionally persist their decision. It is intended to
use this to gather metrics on whether users are more likely to make
a decision on a permission prompt when presented with more information
regarding how long the decision will last.

Additional tests in the permission layer are added to verify the
optional persistence.

BUG= 632269 

Review-Url: https://codereview.chromium.org/2258763002
Cr-Commit-Position: refs/heads/master@{#418189}
(cherry picked from commit d4e446a9c0944eb6748eceaf036f94dfc17acbb4)

Review URL: https://codereview.chromium.org/2342233003 .

Cr-Commit-Position: refs/branch-heads/2840@{#386}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/app/generated_resources.grd
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/media/media_stream_devices_controller.cc
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/media/media_stream_devices_controller.h
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/permissions/permission_context_base_unittest.cc
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/permissions/permission_request.cc
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/permissions/permission_request.h
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/permissions/permission_request_impl.cc
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/permissions/permission_request_impl.h
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/permissions/permission_request_manager.cc
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/permissions/permission_request_manager.h
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/ui/views/website_settings/permission_prompt_impl.h
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/ui/website_settings/permission_bubble_browser_test_util.h
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/ui/website_settings/permission_prompt.h
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02449fec721e22762d322bc204274677d01bd035

commit 02449fec721e22762d322bc204274677d01bd035
Author: Dominick Ng <dominickn@chromium.org>
Date: Thu Sep 15 04:15:47 2016

Enable the optional permission prompt persistence toggle on grouped infobars

This CL adds support for the feature enabling a persistence toggle on
permission prompts to grouped permission infobars. The toggle is only
shown if an enabling feature is active. Grouped bars are used exclusively
for media permissions, so this change allows the toggle to be shown
when a single and multiple media permissions are requested.

New Android UI tests for responding to the permission prompts triggered
by getUserMedia are added to verify the toggle behaviour. The persistence
boolean in media_stream_devices_controller is renamed in preparation for
upstreaming it into PermissionRequest.

BUG= 632269 

Review-Url: https://codereview.chromium.org/2254763002
Cr-Commit-Position: refs/heads/master@{#418107}
(cherry picked from commit fd008ac9abf59ac99681381b297e00652c285246)

Review URL: https://codereview.chromium.org/2342003002 .

Cr-Commit-Position: refs/branch-heads/2840@{#373}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/android/BUILD.gn
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/android/java/src/org/chromium/chrome/browser/infobar/GroupedPermissionInfoBar.java
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/android/java_sources.gni
[add] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/MediaPermissionsTest.java
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/browser/media/media_stream_devices_controller.cc
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/browser/media/media_stream_devices_controller.h
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/browser/media/media_stream_infobar_delegate_android.cc
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/browser/media/media_stream_infobar_delegate_android.h
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/browser/permissions/grouped_permission_infobar_delegate.cc
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/browser/permissions/grouped_permission_infobar_delegate.h
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/browser/ui/android/infobars/grouped_permission_infobar.cc
[modify] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/chrome/browser/ui/android/infobars/grouped_permission_infobar.h
[add] https://crrev.com/02449fec721e22762d322bc204274677d01bd035/content/test/data/android/media_permissions.html
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58c416bd91c9279110d61da469184449365038fd

commit 58c416bd91c9279110d61da469184449365038fd
Author: Dominick Ng <dominickn@chromium.org>
Date: Fri Sep 16 02:01:25 2016

Add a feature-controlled persistence checkbox to geolocation prompts on desktop Views platforms.

This CL allows geolocation permission prompts to show a checkbox to
allow the user to optionally persist their decision. It is intended to
use this to gather metrics on whether users are more likely to make
a decision on a permission prompt when presented with more information
regarding how long the decision will last.

Additional tests in the permission layer are added to verify the
optional persistence.

BUG= 632269 

Review-Url: https://codereview.chromium.org/2258763002
Cr-Commit-Position: refs/heads/master@{#418189}
(cherry picked from commit d4e446a9c0944eb6748eceaf036f94dfc17acbb4)

Review URL: https://codereview.chromium.org/2342233003 .

Cr-Commit-Position: refs/branch-heads/2840@{#386}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/app/generated_resources.grd
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/media/media_stream_devices_controller.cc
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/media/media_stream_devices_controller.h
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/permissions/permission_context_base_unittest.cc
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/permissions/permission_request.cc
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/permissions/permission_request.h
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/permissions/permission_request_impl.cc
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/permissions/permission_request_impl.h
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/permissions/permission_request_manager.cc
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/permissions/permission_request_manager.h
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/ui/views/website_settings/permission_prompt_impl.h
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/ui/website_settings/permission_bubble_browser_test_util.h
[modify] https://crrev.com/58c416bd91c9279110d61da469184449365038fd/chrome/browser/ui/website_settings/permission_prompt.h

Comment 22 by raymes@chromium.org, Nov 3 2016

Components: -UI>Browser>Permissions UI>Browser>Permissions>Prompts

Comment 23 by lgar...@chromium.org, Nov 23 2016

Components: UI>Browser>Omnibox>SecurityIndicators

Comment 25 by perezju@chromium.org, Sep 5 2017

Blocking: 760319

Comment 26 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 27 by dominickn@chromium.org, Nov 14 2017

Status: Fixed (was: Started)
We have concluded experiments on prompts for now so I'm closing this bug. :)
►

Sign in to add a comment