New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632265 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unable to open Synced tabs History

Project Member Reported by mm00333...@techmahindra.com, Jul 28 2016

Issue description

Version: 54.0.2810.0
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1)Launch chrome -> Sign in to chrome so that history of other devices is synced 
(2)Now Go to chrome://history page ->click on "Synced Tabs"
(3) Click on Any link  and observe 

Expected: Should be able to open Synced tabs History 
Actual: Instead Unable to open Synced tabs History 

This is Regression Issue broken in M-54
will provide Bisect Info soon

 
Labels: OS-Mac OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Windows-7 and Mac OS 10.11.5 using chrome latest Dev M54-54.0.2810.0. Observed the synced tabs under chrome://history goes unresponsive.
Labels: -Needs-Bisect ReleaseBlock-Stable
Owner: calamity@chromium.org
Status: Assigned (was: Untriaged)
This is Regression Issue Broken in M-54

Manual good and Bad Builds:
Good Build: 54.0.2809.0
Bad Build:  54.0.2810.0

Note : Unable to provide narrow bisect as sign in to chrome in chromium builds is not possible, hence providing Manual change log info.

MANUAL CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/54.0.2809.0..54.0.2810.0?pretty=fuller&n=10000

Suspecting https://codereview.chromium.org/2172563002 from Manual Changelog

@calamity :  Please feel free to re-assign if its not related to your change

Note: 
1.Issue is also seen on Windows OS
2.Adding Stable Blocker as this is a Recent Regression on M54.
Please feel free to remove if not required
Actual_Tabs.ogv
1.4 MB View Download
Expected_Tabs.ogv
1.4 MB View Download
Labels: -ReleaseBlock-Stable ReleaseBlock-Beta
Issue is also seen on latest Build 54.0.2810.2.
Adding Beta Blocker as this is a Recent Regression on M54.
Please feel free to remove if not required
Labels: Proj-MaterialDesign-WebUI
Owner: tsergeant@chromium.org
Status: Started (was: Assigned)
Cc: calamity@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92d6c18fcb5614c9d3abc85ce54c1c619b42f535

commit 92d6c18fcb5614c9d3abc85ce54c1c619b42f535
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Jul 29 05:53:24 2016

MD History: Fix clicking on synced tab links

A small error in event handling code meant it was no longer possible to
click on synced tabs. This CL fixes the regression and adds a test.

BUG= 632265 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2195593002
Cr-Commit-Position: refs/heads/master@{#408586}

[modify] https://crrev.com/92d6c18fcb5614c9d3abc85ce54c1c619b42f535/chrome/browser/resources/md_history/synced_device_card.js
[modify] https://crrev.com/92d6c18fcb5614c9d3abc85ce54c1c619b42f535/chrome/test/data/webui/md_history/history_synced_tabs_test.js

Status: Fixed (was: Started)

Comment 9 by ajha@chromium.org, Aug 2 2016

Labels: TE-Verified-M54 TE-Verified-54.0.2816.0
Verified the fix on the latest M-54(54.0.2816.0) on Windows-7, Mac OS 10.11.5 and Linux Ubuntu 14.04. This is working as intended and synced tabs are opening on mouse click. 

Sign in to add a comment