MacViews: Clicking the scrolltrack to scroll scrolls indefinitely |
||
Issue descriptionChrome Version : 53.0.2785.21 OS Version: OS X 10.11.6 What steps will reproduce the problem? 1. chrome://flags/#mac-views-native-dialogs Enabled 2. Open Task Manager, add tabs so it can scroll 3. Click the scroll track What is the expected result? Should scroll a single page. What happens instead of that? Scrolls a page then, after a delay, keeps scrolling. Later attempts to scroll result in jank. started: https://codereview.chromium.org/2192443003
,
Aug 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2f76449767bc5a1e426bba55ae1c52aab69ff75 commit c2f76449767bc5a1e426bba55ae1c52aab69ff75 Author: tapted <tapted@chromium.org> Date: Tue Aug 02 01:26:31 2016 MacViews: Fix scrolling when clicking on the views::ScrollView scroll track Currently the mouse up event is lost, resulting in the repeating timer never resetting. CocoaScrollBar just needs to invoke super::OnMouseReleased(). Sets up views::ScrollView for event testing, and adds a test. BUG= 632261 Review-Url: https://codereview.chromium.org/2192443003 Cr-Commit-Position: refs/heads/master@{#409114} [modify] https://crrev.com/c2f76449767bc5a1e426bba55ae1c52aab69ff75/ui/views/controls/scroll_view.h [modify] https://crrev.com/c2f76449767bc5a1e426bba55ae1c52aab69ff75/ui/views/controls/scroll_view_unittest.cc [modify] https://crrev.com/c2f76449767bc5a1e426bba55ae1c52aab69ff75/ui/views/controls/scrollbar/base_scroll_bar.h [modify] https://crrev.com/c2f76449767bc5a1e426bba55ae1c52aab69ff75/ui/views/controls/scrollbar/cocoa_scroll_bar.mm [modify] https://crrev.com/c2f76449767bc5a1e426bba55ae1c52aab69ff75/ui/views/controls/scrollbar/native_scroll_bar.h [modify] https://crrev.com/c2f76449767bc5a1e426bba55ae1c52aab69ff75/ui/views/repeat_controller.h
,
Aug 2 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by tapted@chromium.org
, Jul 28 2016Labels: Proj-MacViews