New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 632260 link

Starred by 3 users
Status: WontFix
Owner:
mahmadi@chromium.org
Closed: Aug 2016
Cc:
ajha@chromium.org
ew...@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
bettes@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Default Focus on option is seen Missing in "Import an existing supervised user" overlay

Project Member Reported by mm00333...@techmahindra.com, Jul 28 2016 
Version: 54.0.2808.0
OS: Ubuntu 14.04,Windows

Precondition: 
1.Enable 'Material Design User Manager' flag from 'chrome://flags'

What steps will reproduce the problem?
(1)Launch chrome -> Sign into Profile-> click on avatar icon 
(2)Now click on 'Switch person' option for User Manager window-> Select 'ADD PERSON' -> Now Check the 'Supervise this person...' checkbox ->Select account 
(3)Now click on "Import an existing supervised user" link  and observe for focus(Please refer  Video)

Expected: Default Focus on option should be seen 
Actual: Instead Focus is seen missing

This is Regression Issue Broken in M-52

Manual good and Bad Builds:
Good Build: 52.0.2741.0
Bad Build:  52.0.2742.0

Note : Unable to provide narrow bisect as sign in to chrome in chromium builds is not possible, hence providing Manual change log info.

MANUAL CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/52.0.2741.0..52.0.2742.0?pretty=fuller&n=10000

Suspecting https://codereview.chromium.org/1989993002 from Manual Changelog

@mahmadi :  Please confirm whether the behavior is intended or not
Actual_Focus.png
182 KB View Download
Actual_Focus.ogv
1.8 MB View Download
Expected_Focus.png
186 KB View Download
Expected_Focus.ogv
1.5 MB View Download

Comment 1 by mm00333...@techmahindra.com, Jul 28 2016 

Correction in Manual good and Bad Builds:
Good Build: 53.0.2763.0
Bad Build:  53.0.2764.0

MANUAL CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/53.0.2763.0..53.0.2764.0?pretty=fuller&n=10000

Suspecting https://codereview.chromium.org/2024233003 from Manual Changelog

@mahmadi :  Please confirm whether the behavior is intended or not

Comment 2 by brajkumar@chromium.org, Jul 28 2016

Labels: hasbisect OS-Mac
Able to reproduce the issue on Mac OS using chrome latest Dev M54-54.0.2808.0. Observed default focus is missing under import supervised user option.

Comment 3 by mm00333...@techmahindra.com, Jul 28 2016 

Issue is also seen on latest Build 54.0.2810.2

Comment 4 by mahmadi@chromium.org, Aug 1 2016

Status: Started (was: Assigned)

Comment 5 Deleted

Comment 6 by mahmadi@chromium.org, Aug 2 2016

Cc: ew...@chromium.org
ewald@, the default focus was never something we explicitly implemented. With Polymer having been updated this doesn't seem to work anymore. Do you think we need it?

Comment 7 by ew...@chromium.org, Aug 2 2016

Cc: bettes@chromium.org
No, I don't think we need default focus in this dialogue.

+Alan, are you okay with no default focus?

Comment 8 by bettes@chromium.org, Aug 5 2016 

Talked it over with Moe. Our consensus is the following: 

- do not focus on the list by default, but rather the dialog itself initially
- pressing tab focuses the close-x first, tab again for the list -- first user in the list is focused

- focus and select states will abide by default polymer behavior which is grey bkg on focus and bolded font weight for selected. https://elements.polymer-project.org/elements/paper-listbox?view=demo:demo/index.html

Comment 9 by mahmadi@chromium.org, Aug 8 2016

Status: WontFix (was: Started)
►

Sign in to add a comment