New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 632256 link

Starred by 2 users
Status: Fixed
Owner:
shimazu@chromium.org
Closed: Jul 2016
Cc:
█ bke...@mozilla.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

http/tests/serviceworker/activation.html fails to call unregister()

Project Member Reported by nhiroki@chromium.org, Jul 28 2016 
This was reported by bkelly@mozilla.com in  issue 616331 

> FYI, asuth caught a bug in the test during review.  On line 55 of activation.html it says:
>
>         add_result_callback(() => registration.unregister);
>
> This should probably call unregister() instead of returning the unregister function.

https://bugs.chromium.org/p/chromium/issues/detail?id=616331#c22

Comment 1 by nhiroki@chromium.org, Jul 28 2016

Owner: shimazu@chromium.org
Status: Assigned (was: Available)
shimazu@, can you take a look at this?

Comment 2 by shimazu@chromium.org, Jul 28 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88da30c52b97f4aefe60c35f37bc1a62c9ab7d30

commit 88da30c52b97f4aefe60c35f37bc1a62c9ab7d30
Author: shimazu <shimazu@chromium.org>
Date: Fri Jul 29 04:14:44 2016

ServiceWorker: Unregister SW after finishing activation.html

Calling registration.unregister instead of returning
registration.unregister

BUG= 632256 
TEST=./third_party/WebKit/Tools/Scripts/run-webkit-tests -f -t Release http/tests/serviceworker/activation.html

Review-Url: https://codereview.chromium.org/2190853003
Cr-Commit-Position: refs/heads/master@{#408573}

[modify] https://crrev.com/88da30c52b97f4aefe60c35f37bc1a62c9ab7d30/third_party/WebKit/LayoutTests/http/tests/serviceworker/activation.html

Comment 4 by shimazu@chromium.org, Jul 29 2016

Status: Fixed (was: Started)
►

Sign in to add a comment