New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632251 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Not on Chrome
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Scrollbars visible in item overflow menu in chrome://history

Reported by dchau...@etouch.net, Jul 28 2016

Issue description

Chrome Version: 54.0.2809.0 (Official Build)12fd360cfa20b6ca7784225e58bf10647b721002-refs/heads/master@{#408012} 32/64-bit.
OS: Windows (7,8,10), Mac (10.10.5, 10.11.5), Linux (Ubuntu 14.04 LTS).

Precondition: Navigate to few webpages such that history get created in chrome://history page.

What steps will reproduce the problem?
1. Launch chrome and navigate chrome;//history page.
2. Click on 'Action' icon of any URL and observe.

Unnecessary horizontal and vertical scroll bar appears for a moment on 'Action' drop down list.
Horizontal and vertical scroll bar should not appear on 'Action' drop down list.

Note: To reproduce the issue frequently repeat the step-3, 3-4 times.

This is a regression issue, broken in M-54 series, below is bisect info.

Good build: 54.0.2808.0.
Bad build: 54.0.2809.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/ddc3a45d3da9e14b5001004df38044634a5d7435..473c692fac754376f0b4feb4ba9a2ae0e1472180?pretty=fuller&n=100

Suspecting: r407689

Kindly review the attached screen-cast for reference.
 
Actual screenshot.png
97.9 KB View Download
Actual behavior.mp4
669 KB View Download
Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.

Comment 2 by dbeam@chromium.org, Jul 29 2016

Cc: calamity@chromium.org dbeam@chromium.org valdrin@google.com
Owner: ----
Status: Available (was: Assigned)
<paper-menu>/<iron-overlay> or whatever this is should probably be hiding its overflow while showing
Labels: Proj-MaterialDesign-WebUI
Cc: -tsergeant@chromium.org
Owner: tsergeant@chromium.org
Status: Assigned (was: Available)
Summary: Regression: Scrollbars visible in item overflow menu in chrome://history (was: Regression: Weird behavior of 'Action' drop down list is observed on 'History' page.)
Re #2:

<iron-dropdown> does try to hide overlay while animating. The problem is that it doesn't reliably cancel any current animations when starting a new one. As a result, starting/cancelling animations in rapid succession causes the element to get confused about whether or not it is animating.

On top of that, since the animations change the height/width of the dropdown, it's possible to cause some wacky glitches to happen based off the height/width being incorrect when the menu is opened.
I'm still seeing some interleaving of the two animations, though. I'm not 100% sure why.

Instrumenting neon-animation-runner-behavior to log when animations start and end, I see:

neon-animation-runner-behavior-extracted.js:72 start animation: close
neon-animation-runner-behavior-extracted.js:72 start animation: open
neon-animation-runner-behavior-extracted.js:91 finish animation: close
neon-animation-runner-behavior-extracted.js:91 finish animation: open

The easist way to reproduce this on chrome://history is:

1. Click menu button, wait for animation to finish
2. Move mouse to hover over a different menu button
3. Press escape
3. During close animation, click menu button
Retested the above issue on Windows-10 machine using Canary chrome version 54.0.2822.0 (Official Build). It's still reproducible.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e022b8b94971d07b93ed758b259a0ed31da9a015

commit e022b8b94971d07b93ed758b259a0ed31da9a015
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Aug 09 02:52:14 2016

MD WebUI: Simplify cr-shared-menu exit animation

The current menu exit animation has the menu fade out while shrinking
width and height. However, the shrinking is barely visible and causes
visual glitches when quickly closing/reopening the menu.

This change does not completely fix either of the linked bugs, but it
greatly lessens their effect.

BUG= 632251 , 631840 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2222013003
Cr-Commit-Position: refs/heads/master@{#410553}

[modify] https://crrev.com/e022b8b94971d07b93ed758b259a0ed31da9a015/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js

Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Status: Started (was: Assigned)
The CL in #9 seems to reduce the amount of craziness that can happen when repeatedly opening and closing the menu. It still doesn't completely solve the problem, but I'm reducing the priority to not block launch.
Status: WontFix (was: Started)
The menu no longer has an animation, so this issue is obsolete.

Sign in to add a comment