BackoffTimer.Basic is failing on DrMemory bots |
|||
Issue descriptionThis seems to have started with this build: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%283%29/builds/10816 Sample failure: BackoffTimer.Basic: c:\b\build\slave\drm-cr\build\src\remoting\host\backoff_timer_unittest.cc(38): error: The difference between 10 and mock_timer->GetCurrentDelay().InMillisecondsF() is 5.1989999999999998, which exceeds 1, where 10 evaluates to 10, mock_timer->GetCurrentDelay().InMillisecondsF() evaluates to 4.8010000000000002, and 1 evaluates to 1.
,
Jul 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28f28f6dcdac72141c58abeaeb5c1854bf078ac7 commit 28f28f6dcdac72141c58abeaeb5c1854bf078ac7 Author: benwells <benwells@chromium.org> Date: Thu Jul 28 07:47:53 2016 Disable two tests under DrMemory. TBR=jyasskin BUG=632264, 632248 Review-Url: https://codereview.chromium.org/2188973002 Cr-Commit-Position: refs/heads/master@{#408356} [modify] https://crrev.com/28f28f6dcdac72141c58abeaeb5c1854bf078ac7/tools/valgrind/gtest_exclude/components_unittests.gtest-drmemory_win32.txt [modify] https://crrev.com/28f28f6dcdac72141c58abeaeb5c1854bf078ac7/tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt
,
Jul 28 2016
Looks like the BackoffTimer is not passing a mock TickClock to the BackoffEntry, so if there is >1ms between firing our mock timer and checking the current delay then the returned delay may be too short.
,
May 24 2017
AFAIK we no longer have any DrMemory bots and this test doesn't fail anywhere else. |
|||
►
Sign in to add a comment |
|||
Comment 1 by benwells@chromium.org
, Jul 28 2016