New issue
Advanced search Search tips

Issue 632231 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.4%-15.9% regression in top_10_mobile_memory at 407805:407993

Project Member Reported by kouhei@chromium.org, Jul 28 2016

Issue description

See the link to graphs below.
 

Comment 1 by kouhei@chromium.org, Jul 28 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=632231

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgusb8wQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICghtyXrgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICghvSBpAsM


Bot(s) for this bug's original alert(s):

android-nexus5
chromium-rel-mac-retina
chromium-rel-win7-dual
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Aug 17 2016


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@407915  7274231  49741.9  12  good
chromium@407969  7286891  38709.7  15  bad

Bisect job ran on: android_nexus6_perf_bisect
Bug ID: 632231

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests top_10_mobile_memory
Test Metric: memory:chrome:all_processes:reported_by_chrome:v8:allocated_objects_size_max/http___m.youtube.com_results?q_science
Relative Change: 0.57%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2484
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004130514185704752


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5832023244013568

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Aug 17 2016

Cc: ishell@chromium.org
Owner: ishell@chromium.org

=== Auto-CCing suspected CL author ishell@chromium.org ===

Hi ishell@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [ic] Avoid memory wasting when allocating names table of type feedback metadata.
Author  : ishell
Commit description:
  
BUG= chromium:625894 

Review-Url: https://codereview.chromium.org/2181303002
Cr-Commit-Position: refs/heads/master@{#38047}
Commit  : 2fec36d9adba268c148c3ab28b8ab412021a82f3
Date    : Tue Jul 26 12:01:38 2016


===== TESTED REVISIONS =====
Revision                       Mean      Std Dev  N   Good?
chromium@407817                11166240  257366   12  good
chromium@407817,v8@1d2793f877  11122800  86073.3  5   good
chromium@407817,v8@2fec36d9ad  11446249  51515.4  5   bad    <--
chromium@407817,v8@7e1867d664  11474893  65081.4  5   bad
chromium@407817,v8@bec00d246c  11460521  64653.4  5   bad
chromium@407818                11505785  77000.6  5   bad
chromium@407819                11481434  48523.6  12  bad
chromium@407820                11516962  52175.5  12  bad
chromium@407822                11476574  91412.9  12  bad
chromium@407830                11491430  53910.8  12  bad
chromium@407836                11469745  52224.6  12  bad
chromium@407854                11468788  80085.1  12  bad

Bisect job ran on: mac_10_11_perf_bisect
Bug ID: 632231

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests top_10_mobile_memory
Test Metric: memory:chrome:all_processes:reported_by_chrome:v8:allocated_objects_size_avg/http___yandex.ru_touchsearch?text_science
Relative Change: 1.34%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/835
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004130526458763200


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6400608597180416

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
ishell@, based on your CL description, seems like you intend to improve memory? However, the bisect says that your CL regress memory benchmark.

Can you check to see if the regression is intentional?
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c56222c9bd279c8a94697e21ed8ce1e0813c6347

commit c56222c9bd279c8a94697e21ed8ce1e0813c6347
Author: ishell <ishell@chromium.org>
Date: Wed Oct 05 17:55:26 2016

[ic] Avoid feedback metadata names table reallocations.

An attempt to fix memory regression (r38047) caused another regression
because custom capacity chosen for names dictionary implied reallocations
during initialization in some cases.

BUG= chromium:625894 , chromium:632231 

Review-Url: https://codereview.chromium.org/2394873002
Cr-Commit-Position: refs/heads/master@{#40006}

[modify] https://crrev.com/c56222c9bd279c8a94697e21ed8ce1e0813c6347/src/type-feedback-vector.cc

#7 should fix the regression caused by https://codereview.chromium.org/2181303002. Let's see if it helps.
Cc: -ishell@chromium.org mvstan...@chromium.org verwa...@chromium.org
Owner: ----
perf fixit: unassigning owner for sheriff-owned bugs to clarify that these are triaged by a rotation.
Cc: ishell@chromium.org
Status: Untriaged (was: Assigned)
Can the perf sheriff rerun bisect to verify this was fixed?
Hmmm, it seems like the regressed metric [1] is no longer reported the same way so I cannot really verify if the fixed has indeed addressed the regression.

Memory metrics have been renamed in the past so I suspect it is possible to find an equivalent metric and observe the improvement that coincides with #7.

perezju@ any idea what is the equivalent metric? can you check the above please.

[1] memory:chrome:all_processes:reported_by_chrome:v8:effective_size_max 
Status: WontFix (was: Untriaged)
This alert was found before M-60 branched. Closing as WontFix as this is believed to either be invalid or non-reproducible.

Sign in to add a comment