[GN][Windows][Host] remoting_desktop.exe binary doesn't have uiaccess specified |
||||
Issue descriptionIn our GYP builds, remoting_desktop.exe is marked as 'requireAdministrator' and uiaccess is set to true. In our GN builds, we pull in a manifest which specifies requireAdministrator, however uiaccess is set to false. Based on comments in desktop_session_win.cc, we need to set both of these values to allow us to inject ALT+TAB on Win8 and higher. We should check a Win8+ build with a GN CRD Host and see if ALT+TAB is working correctly. If it is, then let's fix the comment, otherwsie we should update the GN build params.
,
Sep 27 2016
Looks like UiAccess is required (along with running as either SYSTEM or current user). Since the previous config (GYP) specified 'requireAdministrator', we should do that here as well.
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bfc7617064035d439530f76feeb91244f96cb93 commit 8bfc7617064035d439530f76feeb91244f96cb93 Author: joedow <joedow@chromium.org> Date: Thu Sep 29 02:09:52 2016 Add UiAccess manifest flag back to remoting_desktop.exe During the GN migration, one of the required manifest flags was not included in remoting_desktop.exe. We need to add this back to allow us to inject ALT+TAB remotely. BUG= 632221 Review-Url: https://codereview.chromium.org/2370293002 Cr-Commit-Position: refs/heads/master@{#421719} [modify] https://crrev.com/8bfc7617064035d439530f76feeb91244f96cb93/remoting/host/win/BUILD.gn [add] https://crrev.com/8bfc7617064035d439530f76feeb91244f96cb93/remoting/host/win/enable_uiaccess_require_admin.manifest
,
Sep 29 2016
Can you verify Alt + Tab is working correctly on Win8+ now with this fix? Thanks!
,
Sep 30 2016
Alt Tab works fine in Win8 and Win10. Verified with ToT host 55.0.2876.0 |
||||
►
Sign in to add a comment |
||||
Comment 1 by jamiewa...@chromium.org
, Jul 28 2016Status: Assigned (was: Untriaged)