Issue metadata
Sign in to add a comment
|
Certificate reporting: report client timestamp at the time the interstitial is constructed |
||||||||||||||||||||||||
Issue descriptionSafe Browsing Extended Reporting certificate reports contain the local system time at the time the report is sent (which is when the interstitial is dismissed). However, this sometimes makes things confusing on the analysis side, because if the user fixes the clock while being shown a bad-clock interstitial, the report will show an accurate client timestamp, rather than the inaccurate time that caused the error. To help with this, we should add a field (initial_client_timestamp?) to the certificate reports to record the local system time when the interstitial is first constructed.
,
Nov 22 2016
,
Nov 22 2016
,
Nov 23 2016
,
Nov 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6255265704c19083d47fb1500ee869f872dd546d commit 6255265704c19083d47fb1500ee869f872dd546d Author: estark <estark@chromium.org> Date: Thu Nov 24 15:44:39 2016 Record the time when the interstitial is constructed In Safe Browsing Extended Reporting reports, send the timestamp at which the interstitial was constructed, in addition to the timestamp of the report being sent. This will be helpful in cases where the user fixes the clock while the interstitial is showing (so that we can see the client clock time that actually triggered the date error). BUG= 632218 Review-Url: https://codereview.chromium.org/2524903004 Cr-Commit-Position: refs/heads/master@{#434331} [modify] https://crrev.com/6255265704c19083d47fb1500ee869f872dd546d/chrome/browser/ssl/bad_clock_blocking_page.cc [modify] https://crrev.com/6255265704c19083d47fb1500ee869f872dd546d/chrome/browser/ssl/bad_clock_blocking_page.h [modify] https://crrev.com/6255265704c19083d47fb1500ee869f872dd546d/chrome/browser/ssl/captive_portal_blocking_page.cc [modify] https://crrev.com/6255265704c19083d47fb1500ee869f872dd546d/chrome/browser/ssl/cert_report_helper.cc [modify] https://crrev.com/6255265704c19083d47fb1500ee869f872dd546d/chrome/browser/ssl/cert_report_helper.h [modify] https://crrev.com/6255265704c19083d47fb1500ee869f872dd546d/chrome/browser/ssl/ssl_blocking_page.cc [modify] https://crrev.com/6255265704c19083d47fb1500ee869f872dd546d/components/certificate_reporting/cert_logger.proto [modify] https://crrev.com/6255265704c19083d47fb1500ee869f872dd546d/components/certificate_reporting/error_report.cc [modify] https://crrev.com/6255265704c19083d47fb1500ee869f872dd546d/components/certificate_reporting/error_report.h [modify] https://crrev.com/6255265704c19083d47fb1500ee869f872dd546d/components/certificate_reporting/error_report_unittest.cc
,
Dec 7 2016
,
Dec 13 2016
,
Dec 15 2016
Requesting a merge for the commit in comment 5
,
Dec 15 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9acee6d2c7c5e3deaa441f2a29e08a660e2860bc commit 9acee6d2c7c5e3deaa441f2a29e08a660e2860bc Author: Emily Stark <estark@google.com> Date: Thu Dec 15 01:46:29 2016 Record the time when the interstitial is constructed In Safe Browsing Extended Reporting reports, send the timestamp at which the interstitial was constructed, in addition to the timestamp of the report being sent. This will be helpful in cases where the user fixes the clock while the interstitial is showing (so that we can see the client clock time that actually triggered the date error). BUG= 632218 Review-Url: https://codereview.chromium.org/2524903004 Cr-Commit-Position: refs/heads/master@{#434331} (cherry picked from commit 6255265704c19083d47fb1500ee869f872dd546d) Review-Url: https://codereview.chromium.org/2575233003 . Cr-Commit-Position: refs/branch-heads/2924@{#504} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/9acee6d2c7c5e3deaa441f2a29e08a660e2860bc/chrome/browser/ssl/bad_clock_blocking_page.cc [modify] https://crrev.com/9acee6d2c7c5e3deaa441f2a29e08a660e2860bc/chrome/browser/ssl/bad_clock_blocking_page.h [modify] https://crrev.com/9acee6d2c7c5e3deaa441f2a29e08a660e2860bc/chrome/browser/ssl/captive_portal_blocking_page.cc [modify] https://crrev.com/9acee6d2c7c5e3deaa441f2a29e08a660e2860bc/chrome/browser/ssl/cert_report_helper.cc [modify] https://crrev.com/9acee6d2c7c5e3deaa441f2a29e08a660e2860bc/chrome/browser/ssl/cert_report_helper.h [modify] https://crrev.com/9acee6d2c7c5e3deaa441f2a29e08a660e2860bc/chrome/browser/ssl/ssl_blocking_page.cc [modify] https://crrev.com/9acee6d2c7c5e3deaa441f2a29e08a660e2860bc/components/certificate_reporting/cert_logger.proto [modify] https://crrev.com/9acee6d2c7c5e3deaa441f2a29e08a660e2860bc/components/certificate_reporting/error_report.cc [modify] https://crrev.com/9acee6d2c7c5e3deaa441f2a29e08a660e2860bc/components/certificate_reporting/error_report.h [modify] https://crrev.com/9acee6d2c7c5e3deaa441f2a29e08a660e2860bc/components/certificate_reporting/error_report_unittest.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by raymes@chromium.org
, Sep 6 2016