New issue
Advanced search Search tips

Issue 632211 link

Starred by 2 users
Status: Archived
Owner:
msw@chromium.org
Closed: Feb 2017
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Mash should install TestShellDelegate in tests

Project Member Reported by sky@chromium.org, Jul 27 2016 
This is what ash does, and many of the tests rely on TestShellDelegate's behavior.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e

commit aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e
Author: sky <sky@chromium.org>
Date: Wed Aug 03 00:14:55 2016

Get AcceleratorControllerTest working with mash

A couple of tests have been commented or disabled because of current
lacking functionality in mash. Bugs are filed for all the cases.

BUG= 612331 , 632208 ,632209, 630683 , 632211 , 632180 , 632189 , 632192 , 632200 , 632201 
TEST=AcceleratorControllerTest* in mash_unittests
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2203003003
Cr-Commit-Position: refs/heads/master@{#409393}

[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/BUILD.gn
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/accelerators/accelerator_controller_registrar.h
[add] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/accelerators/accelerator_controller_registrar_test_api.cc
[add] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/accelerators/accelerator_controller_registrar_test_api.h
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/bridge/wm_root_window_controller_mus.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/bridge/wm_shell_mus.h
[add] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/bridge/wm_shell_mus_test_api.h
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/property_util.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/property_util.h
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/test/wm_test_helper.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/test/ash_md_test_base.h
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/test/ash_test_helper.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ui/views/mus/native_widget_mus.cc

Comment 2 by sky@chromium.org, Aug 24 2016

Labels: Proj-Mustash-Mash

Comment 3 by dtapu...@chromium.org, Sep 2 2016

Components: MUS

Comment 4 by rjkroege@chromium.org, Oct 4 2016

Labels: Proj-Mustash

Comment 5 by rjkroege@chromium.org, Oct 4 2016

Components: Internals>MUS

Comment 6 by msw@chromium.org, Feb 14 2017

Owner: msw@chromium.org
Status: Fixed (was: Untriaged)
This was fixed by https://codereview.chromium.org/2688353005/

Comment 7 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Comment 11 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService

Comment 12 by lafo...@chromium.org, Feb 26 2018

Components: -MUS
►

Sign in to add a comment