New issue
Advanced search Search tips

Issue 632210 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

HTTP auth dialog text should all be 1pt larger

Project Member Reported by shrike@chromium.org, Jul 27 2016

Issue description

Buttons are OK but the text is smaller than it is currently.

Assigning to tapted@ who mentioned font size issues in MacViews sync.

 
HTTPAuthCocoa.png
79.3 KB View Download
HTTPAuthViews.png
60.1 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e644cd132e1d7b288e0d2bbb9ea34e9a0a50ab6

commit 5e644cd132e1d7b288e0d2bbb9ea34e9a0a50ab6
Author: tapted <tapted@chromium.org>
Date: Wed Aug 03 21:49:30 2016

MacViews: Bump up the default font sizes for dialogs to 12pt.

Previously we used 11pt ([NSFont smallSystemFontSize]), to be consistent
with the Cocoa bookmarks bubble. However, other Cocoa dialogs are using
12pt, and the latest cross-platform UI specs are converging on 12pt.
(There's also general agreement that 11pt it too small).

Since the "Base" font on Mac is [NSFont systemFontSize] -- 13pt -- we
still need to adjust it compared to other platforms in
ui/base/default_style.h. Cocoa UI isn't using these constants yet, so
this only affects MacViews dialogs.

BUG= 632210 ,  564879 ,  630478 

Review-Url: https://codereview.chromium.org/2200833006
Cr-Commit-Position: refs/heads/master@{#409633}

[modify] https://crrev.com/5e644cd132e1d7b288e0d2bbb9ea34e9a0a50ab6/ui/base/default_style.h

Comment 2 by tapted@chromium.org, Aug 11 2016

Status: Fixed (was: Assigned)

Sign in to add a comment