New issue
Advanced search Search tips

Issue 632201 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 632200

Blocking:
issue 693114



Sign in to add a comment

DeprecatedAcceleratorTester tests disabled

Project Member Reported by sky@chromium.org, Jul 27 2016

Issue description

They need WmTestBase::UnblockUserSession to be implemented.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e

commit aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e
Author: sky <sky@chromium.org>
Date: Wed Aug 03 00:14:55 2016

Get AcceleratorControllerTest working with mash

A couple of tests have been commented or disabled because of current
lacking functionality in mash. Bugs are filed for all the cases.

BUG= 612331 , 632208 ,632209, 630683 , 632211 , 632180 , 632189 , 632192 , 632200 , 632201 
TEST=AcceleratorControllerTest* in mash_unittests
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2203003003
Cr-Commit-Position: refs/heads/master@{#409393}

[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/BUILD.gn
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/accelerators/accelerator_controller_registrar.h
[add] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/accelerators/accelerator_controller_registrar_test_api.cc
[add] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/accelerators/accelerator_controller_registrar_test_api.h
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/bridge/wm_root_window_controller_mus.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/bridge/wm_shell_mus.h
[add] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/bridge/wm_shell_mus_test_api.h
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/property_util.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/property_util.h
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/mus/test/wm_test_helper.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/test/ash_md_test_base.h
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ash/test/ash_test_helper.cc
[modify] https://crrev.com/aec2890d8c57c6b2b9b149b3d9eac2db5a4f014e/ui/views/mus/native_widget_mus.cc

Comment 2 by sky@chromium.org, Aug 24 2016

Labels: Proj-Mustash-Mash

Comment 3 by sky@chromium.org, Mar 7 2017

Blocking: 693114
This still fails, but it looks like it's because of metrics not being recorded now.
Status: Fixed (was: Untriaged)
Seems to work now.

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 6 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment