Earl Grey tests are marked as failed, but the logs say pass |
||||
Issue descriptionAbout 6 out of the past 200 tests run on the web shell state that testPluginPlaceholderObjectOnly failed, but the logs show that it passed. Here is some output from FYI (I don't know if the messed up text means anything): Test Case '-[PluginPlaceholderTest testPluginPlaceholderObjectOnly]' started. 2016-07-27 02:18:41.049 ios_web_shell_test_host[10673:30733] Adjusting repeatCount to 8.375000 for animation <CAKeyframeAnimation: 0x7fcf3b24bb50> 2016-07-27 02:18:41.060 ios_web_shell_test_host[10673:30733] Adjusting repeatCount to 8.375000 for animation <CAKeyframeAnimation: 0x7fcf38f490c0> Test Case '-[PluginPlaceholderTest testPluginPlaceholderObjectOnly]' pass** TEST SUCCEEDED ** ed (0.061 seconds). https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/7565/steps/ios_web_shell_test_host%20%28iPhone%205s%20iOS%209.0%29/logs/stdio
,
Jul 29 2016
Issue 627861 has been merged into this issue.
,
Jul 29 2016
This happens because "** TEST SUCCEEDED **" happens to be printed out in the middle of the sentence "passed (0.061 seconds)". It breaks the regular expression check if a test passes, and makes the test be marked as crash since the script doesn't get the final status of the test. Same reason for 627861.
,
Aug 1 2016
,
Aug 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/cc1d77c36468f1393c7c538b33717b42ac940a0d commit cc1d77c36468f1393c7c538b33717b42ac940a0d Author: huangml <huangml@google.com> Date: Wed Aug 03 00:33:02 2016 Set UNbufferIO env for Earlgrey tests outputs. The test outputs are sometimes out of order due to the buffer thing. "** TEST SUCCEEDED **" is printed out randomly. UnBuffer to avoid this. BUG= 632190 Review-Url: https://codereview.chromium.org/2206633002 [modify] https://crrev.com/cc1d77c36468f1393c7c538b33717b42ac940a0d/scripts/slave/ios/test_runner.py
,
Aug 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/cc1d77c36468f1393c7c538b33717b42ac940a0d commit cc1d77c36468f1393c7c538b33717b42ac940a0d Author: huangml <huangml@google.com> Date: Wed Aug 03 00:33:02 2016 Set UNbufferIO env for Earlgrey tests outputs. The test outputs are sometimes out of order due to the buffer thing. "** TEST SUCCEEDED **" is printed out randomly. UnBuffer to avoid this. BUG= 632190 Review-Url: https://codereview.chromium.org/2206633002 [modify] https://crrev.com/cc1d77c36468f1393c7c538b33717b42ac940a0d/scripts/slave/ios/test_runner.py
,
Aug 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/cc1d77c36468f1393c7c538b33717b42ac940a0d commit cc1d77c36468f1393c7c538b33717b42ac940a0d Author: huangml <huangml@google.com> Date: Wed Aug 03 00:33:02 2016 Set UNbufferIO env for Earlgrey tests outputs. The test outputs are sometimes out of order due to the buffer thing. "** TEST SUCCEEDED **" is printed out randomly. UnBuffer to avoid this. BUG= 632190 Review-Url: https://codereview.chromium.org/2206633002 [modify] https://crrev.com/cc1d77c36468f1393c7c538b33717b42ac940a0d/scripts/slave/ios/test_runner.py
,
Aug 3 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/bc938c4ac691cd923d6edcd0dbdc885927d844ae commit bc938c4ac691cd923d6edcd0dbdc885927d844ae Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Aug 03 00:38:02 2016
,
Aug 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/8b9aa4b6a1eaaf30e5862082e2607b9de688191a commit 8b9aa4b6a1eaaf30e5862082e2607b9de688191a Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Aug 03 03:46:48 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/0d87fb2a274f1d15065418c850ef5fbcb57e21db Use test-without-building for earlgrey devices. (huangml@google.com) https://crrev.com/920aa7caf0f9a4c0ef085e54d975c694de9c48ba Support passing custom environment variables to iOS tests (smut@google.com) https://crrev.com/5c02a7a94e5137970749d06a889b7505867beeac [libfuzzer] Partial revert of crrev.com/2189613004 and crrev.com/2194453004. (mmoroz@chromium.org) https://crrev.com/cc1d77c36468f1393c7c538b33717b42ac940a0d Set UNbufferIO env for Earlgrey tests outputs. (huangml@google.com) https://crrev.com/6104f52be20b2d623d772c4be3eed412fb738322 Specify app_path --path-variable when generating isolate.gen.json for iOS (smut@google.com) https://crrev.com/5f09b0dfb843330ad62b20fc2a779092a6664cdb Append -e before the app name when passing -e to iossim (smut@google.com) https://crrev.com/574a58b2911bbd6b3ce52a448f8e6095b7119686 Fix to use GOMA_SERVICE_ACCOUNT_JSON_FILE in recipe_modules/goma (tikuta@chromium.org) R=ochang@chromium.org,huangml@google.com,smut@google.com,dpranke@chromium.org,mmoroz@chromium.org,aizatsky@chromium.org,tikuta@chromium.org BUG= 632190 ,631289,633642,598405 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2205183002 [modify] https://crrev.com/8b9aa4b6a1eaaf30e5862082e2607b9de688191a/infra/config/recipes.cfg
,
Aug 7 2017
is this still a problem? Should this be closed in some way?
,
Aug 7 2017
This issue is fixed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by baxley@chromium.org
, Jul 27 2016