New issue
Advanced search Search tips

Issue 632187 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 632189
issue 679062



Sign in to add a comment

Port LockStateController to work with mash

Project Member Reported by sky@chromium.org, Jul 27 2016

Issue description

We'll need this, there are likely a bunch of supporting classes needed too.
 

Comment 1 by sky@chromium.org, Jul 27 2016

Blocking: 632189

Comment 2 by sky@chromium.org, Aug 24 2016

Labels: Proj-Mustash-Mash
Components: MUS
Labels: Proj-Mustash
Components: Internals>MUS

Comment 6 by derat@chromium.org, Jan 11 2017

Blocking: 679062

Comment 7 by derat@chromium.org, Jan 24 2017

Owner: derat@chromium.org
Status: Started (was: Untriaged)
This is instantiated now that mash creates an ash::Shell. It has some segfaults caused by assumptions that CursorManager is available, which I'm fixing. After that, the shutdown animation and shutdown itself appear to work. I suspect that screen-locking is completely broken, but that's unsurprising right now.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6250a0ced3c3b8d41214af299502af4dfefd850

commit c6250a0ced3c3b8d41214af299502af4dfefd850
Author: derat <derat@chromium.org>
Date: Wed Jan 25 05:51:53 2017

mash: Make the power button shut the system down.

Now that ash::Shell is instantiated in mash, let
LockStateController ask powerd to shut the system down when
requested. Also fix various crashes in LockStateController
due to CursorManager being uninitialized in mash and
remove WmShell::RequestShutdown() in favor of calling
LockStateController::RequestShutdown() directly.

BUG= 679062 , 632187 

Review-Url: https://codereview.chromium.org/2652093002
Cr-Commit-Position: refs/heads/master@{#445962}

[modify] https://crrev.com/c6250a0ced3c3b8d41214af299502af4dfefd850/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/c6250a0ced3c3b8d41214af299502af4dfefd850/ash/aura/wm_shell_aura.h
[modify] https://crrev.com/c6250a0ced3c3b8d41214af299502af4dfefd850/ash/common/system/date/date_default_view.cc
[modify] https://crrev.com/c6250a0ced3c3b8d41214af299502af4dfefd850/ash/common/system/tiles/tiles_default_view.cc
[modify] https://crrev.com/c6250a0ced3c3b8d41214af299502af4dfefd850/ash/common/wm_shell.h
[modify] https://crrev.com/c6250a0ced3c3b8d41214af299502af4dfefd850/ash/mus/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/c6250a0ced3c3b8d41214af299502af4dfefd850/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/c6250a0ced3c3b8d41214af299502af4dfefd850/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/c6250a0ced3c3b8d41214af299502af4dfefd850/ash/shell.cc
[modify] https://crrev.com/c6250a0ced3c3b8d41214af299502af4dfefd850/ash/wm/lock_state_controller.cc

Comment 9 by derat@chromium.org, Feb 15 2017

Status: Fixed (was: Started)
I'm closing this, as it's instantiated now and I think it makes more sense to have bugs tracking the missing functionality (which I think we already have; see e.g.  issue 679450 ).

Comment 10 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 11 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 13 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Sign in to add a comment