New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632178 link

Starred by 15 users

Issue metadata

Status: Fixed
Merged: issue 631485
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Video playback (HTML5) stops/breaks. Produces glitches, black boxes, flickering on OSX 10.9.5 / Mavericks

Reported by sebastia...@gmail.com, Jul 27 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/601.7.7 (KHTML, like Gecko) Version/9.1.2 Safari/537.86.7

Example URL:

Steps to reproduce the problem:
1. Go to youtube or netflix 
2. play any video
3. wait for some time (~5 to 15min possible!)

What is the expected behavior?
Normal video playback.

What went wrong?
Video playback (HTML5) stops/breaks. Will produces glitches, black boxes, flickering.

Did this work before? Yes Chrome Version 51.0.2704.106

Is it a problem with Flash or HTML5? HTML5

Does this work in other browsers? Yes 

Chrome version: 52.0.2743.85  Channel: stable
OS Version: OS X 10.9.5
Flash Version: Shockwave Flash 22.0 r0

No problems on OSX 10.11 El Capitan. This was introduces with recent Chrome update to Version 52.0.2743.85. No problems before. Tested it with old version. Works fine again. (disabled autoupdate).
 
Yes! Definitively seems related to https://bugs.chromium.org/p/chromium/issues/detail?id=631485. Thanks! Will stick with 51.x for now. Can one merge this issue into the other one?
Mergedinto: 631485
Status: Duplicate (was: Unconfirmed)
Cc: abodenha@chromium.org danakj@chromium.org rookrishna@chromium.org abod...@chromium.org ccameron@chromium.org ananthak@chromium.org dhadd...@chromium.org vollick@chromium.org ericrk@chromium.org
 Issue 611310  has been merged into this issue.
Labels: M-53
Owner: ccameron@chromium.org
Status: Started (was: Duplicate)
Un-merging this, since it is a unique bug.

The relevant context is that the issue goes away when we flush the AVSampleBufferDisplayLayer before each call to enqueue a new sample

Description of fix:
- https://bugs.chromium.org/p/chromium/issues/detail?id=631485#c54
Confirmation that it works:
- https://bugs.chromium.org/p/chromium/issues/detail?id=631485#c55

This has been fixed in M52 by disabling AVSampleBufferDisplayLayer (sadness). I'll fix up the flushing behavior and merge it into M53.

Project Member

Comment 6 by sheriffbot@chromium.org, Aug 5 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Merge-Request-53
Requesting merge to M53.

The fix for this was made for M52 in https://bugs.chromium.org/p/chromium/issues/detail?id=631485#c58, but needs to be merged and restricted to 10.9
Labels: -M-54 ReleaseBlock-Stable M-53
Adding RBS 53, because I forgot the merge

Comment 9 by gov...@chromium.org, Aug 20 2016

Labels: -Merge-Request-53 Merge-Approved-53
Approving merge to M53 branch 2785 for cl listed at #7. Please merge before Monday, 5:00 PM PT so we can take it for next week M53 LAST beta release. Thank you.
A friendly reminder that M53 Stable is launching VERY soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP (before 5:00 PM PT, Tuesday) so we can take it for this week LAST Beta release for Desktop. Thank you!

Note: Merge has to happen by Friday, August 26th, 5:00 PM PST in order to make into the desktop Stable final build cut. 
Oops, I landed https://codereview.chromium.org/2269473002/ against issue 631485. This is good to go for M53. Needs a proper blacklist for M54.
Labels: -Merge-Approved-53
Thank you ccameron@.

Removing "Merge-Approved-53" and applying "merge-merged-2785" label per comment #11.
Labels: merge-merged-2785
Labels: -M-53 M-54
->54
 Issue 638215  has been merged into this issue.
Do we need a merge to M54 branch? 
Yes, I need to do this!
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f33642d15eb090f26cf37c40b04f2ba62a95e243

commit f33642d15eb090f26cf37c40b04f2ba62a95e243
Author: ccameron <ccameron@chromium.org>
Date: Fri Sep 23 02:09:54 2016

Mac video: Add blacklist entry for AVSampleBufferDisplayLayer

This leaks IOSurfaces on 10.9. Include 10.10 in the blacklist because it
has not been sufficiently tested.

BUG= 632178 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2366433002
Cr-Commit-Position: refs/heads/master@{#420543}

[modify] https://crrev.com/f33642d15eb090f26cf37c40b04f2ba62a95e243/gpu/config/gpu_driver_bug_list_json.cc
[modify] https://crrev.com/f33642d15eb090f26cf37c40b04f2ba62a95e243/gpu/config/gpu_driver_bug_workaround_type.h
[modify] https://crrev.com/f33642d15eb090f26cf37c40b04f2ba62a95e243/gpu/ipc/service/image_transport_surface_overlay_mac.mm
[modify] https://crrev.com/f33642d15eb090f26cf37c40b04f2ba62a95e243/ui/accelerated_widget_mac/ca_layer_tree_coordinator.h
[modify] https://crrev.com/f33642d15eb090f26cf37c40b04f2ba62a95e243/ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm
[modify] https://crrev.com/f33642d15eb090f26cf37c40b04f2ba62a95e243/ui/accelerated_widget_mac/ca_layer_tree_unittest_mac.mm
[modify] https://crrev.com/f33642d15eb090f26cf37c40b04f2ba62a95e243/ui/accelerated_widget_mac/ca_renderer_layer_tree.h
[modify] https://crrev.com/f33642d15eb090f26cf37c40b04f2ba62a95e243/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm

Labels: TE-NeedsTriageFromMTV
Currently 10.9.5 / Mavericks version is not available with Chrome-TE HYD team, So requesting MTV TE team to look in to this issue for verification.
Labels: -TE-NeedsTriageFromMTV
The CL is already merged to M53, so please request a merge to M54 ASAP. We are planning to cut the RC cut @ 4.00PM PST,09/27(Tuesday).
Labels: Merge-Request-53

Comment 22 by dimu@chromium.org, Sep 27 2016

Labels: -Merge-Request-53 Merge-Review-53 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M53), manual review required.
Labels: -Merge-Review-53 Merge-Request-54
Whoops, meant M54

Comment 24 by dimu@chromium.org, Sep 27 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Status: Fixed (was: Started)
Merged to M54 in https://codereview.chromium.org/2366433002
Labels: -Merge-Approved-54 Merge-Merged
Labels: merge-merged-2840
Cc: ranjitkan@chromium.org
Labels: TE-Verified-54.0.2840.41 TE-Verified-M54
Rechecked this on chrome version 54.0.2840.41 on MAC 10.11.6. Played some videos in Netflix and on youtube. Videos with length more than 20 to 25 minutes were played. 

No glitches, black boxes or flickering was observed. Adding TE-Verified labels.
Project Member

Comment 29 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39c18b9eb123aa7e478249c5f71a4259285bcac8

commit 39c18b9eb123aa7e478249c5f71a4259285bcac8
Author: Christopher Cameron <ccameron@chromium.org>
Date: Tue Sep 27 21:31:27 2016

Mac video: Add blacklist entry for AVSampleBufferDisplayLayer

This leaks IOSurfaces on 10.9. Include 10.10 in the blacklist because it
has not been sufficiently tested.

BUG= 632178 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2366433002
Cr-Commit-Position: refs/heads/master@{#420543}
(cherry picked from commit f33642d15eb090f26cf37c40b04f2ba62a95e243)

Review URL: https://codereview.chromium.org/2372343002 .

Cr-Commit-Position: refs/branch-heads/2840@{#555}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/39c18b9eb123aa7e478249c5f71a4259285bcac8/gpu/config/gpu_driver_bug_list_json.cc
[modify] https://crrev.com/39c18b9eb123aa7e478249c5f71a4259285bcac8/gpu/config/gpu_driver_bug_workaround_type.h
[modify] https://crrev.com/39c18b9eb123aa7e478249c5f71a4259285bcac8/gpu/ipc/service/image_transport_surface_overlay_mac.mm
[modify] https://crrev.com/39c18b9eb123aa7e478249c5f71a4259285bcac8/ui/accelerated_widget_mac/ca_layer_tree_coordinator.h
[modify] https://crrev.com/39c18b9eb123aa7e478249c5f71a4259285bcac8/ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm
[modify] https://crrev.com/39c18b9eb123aa7e478249c5f71a4259285bcac8/ui/accelerated_widget_mac/ca_layer_tree_unittest_mac.mm
[modify] https://crrev.com/39c18b9eb123aa7e478249c5f71a4259285bcac8/ui/accelerated_widget_mac/ca_renderer_layer_tree.h
[modify] https://crrev.com/39c18b9eb123aa7e478249c5f71a4259285bcac8/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm

Cc: rtoy@chromium.org
 Issue 646271  has been merged into this issue.
Cc: rnimmagadda@chromium.org manoranj...@chromium.org ligim...@chromium.org
 Issue 632741  has been merged into this issue.
Project Member

Comment 32 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6a6d7c3849e22f549937a42ad4a0177c06fa1df

commit b6a6d7c3849e22f549937a42ad4a0177c06fa1df
Author: ccameron <ccameron@chromium.org>
Date: Fri Sep 30 18:58:45 2016

color: Set GpuMemoryBuffer color spaces for Canvas

Change Canvas2DLayerBridge::ImageInfo to hold the
gfx::GpuMemoryBuffer, instead of going through the
glCreateGpuMemoryBufferImageCHROMIUM function.
This GL function will be deleted in the future.

Call gfx::GpuMemoryBuffer::SetColorSpaceForScanout,
which inform CoreAnimation of the IOSurface's color
space.

Add a gfx::ColorSpace::FromSkColorSpace stub.

BUG= 632178 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2364633003
Cr-Commit-Position: refs/heads/master@{#422167}

[modify] https://crrev.com/b6a6d7c3849e22f549937a42ad4a0177c06fa1df/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/b6a6d7c3849e22f549937a42ad4a0177c06fa1df/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/b6a6d7c3849e22f549937a42ad4a0177c06fa1df/gpu/ipc/common/surface_handle.h
[modify] https://crrev.com/b6a6d7c3849e22f549937a42ad4a0177c06fa1df/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/b6a6d7c3849e22f549937a42ad4a0177c06fa1df/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/b6a6d7c3849e22f549937a42ad4a0177c06fa1df/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h
[modify] https://crrev.com/b6a6d7c3849e22f549937a42ad4a0177c06fa1df/third_party/WebKit/Source/platform/graphics/DEPS
[modify] https://crrev.com/b6a6d7c3849e22f549937a42ad4a0177c06fa1df/third_party/WebKit/public/platform/Platform.h
[modify] https://crrev.com/b6a6d7c3849e22f549937a42ad4a0177c06fa1df/ui/gfx/color_space.cc
[modify] https://crrev.com/b6a6d7c3849e22f549937a42ad4a0177c06fa1df/ui/gfx/color_space.h
[modify] https://crrev.com/b6a6d7c3849e22f549937a42ad4a0177c06fa1df/ui/gfx/native_widget_types.h

Project Member

Comment 33 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39c18b9eb123aa7e478249c5f71a4259285bcac8

commit 39c18b9eb123aa7e478249c5f71a4259285bcac8
Author: Christopher Cameron <ccameron@chromium.org>
Date: Tue Sep 27 21:31:27 2016

Mac video: Add blacklist entry for AVSampleBufferDisplayLayer

This leaks IOSurfaces on 10.9. Include 10.10 in the blacklist because it
has not been sufficiently tested.

BUG= 632178 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2366433002
Cr-Commit-Position: refs/heads/master@{#420543}
(cherry picked from commit f33642d15eb090f26cf37c40b04f2ba62a95e243)

Review URL: https://codereview.chromium.org/2372343002 .

Cr-Commit-Position: refs/branch-heads/2840@{#555}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/39c18b9eb123aa7e478249c5f71a4259285bcac8/gpu/config/gpu_driver_bug_list_json.cc
[modify] https://crrev.com/39c18b9eb123aa7e478249c5f71a4259285bcac8/gpu/config/gpu_driver_bug_workaround_type.h
[modify] https://crrev.com/39c18b9eb123aa7e478249c5f71a4259285bcac8/gpu/ipc/service/image_transport_surface_overlay_mac.mm
[modify] https://crrev.com/39c18b9eb123aa7e478249c5f71a4259285bcac8/ui/accelerated_widget_mac/ca_layer_tree_coordinator.h
[modify] https://crrev.com/39c18b9eb123aa7e478249c5f71a4259285bcac8/ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm
[modify] https://crrev.com/39c18b9eb123aa7e478249c5f71a4259285bcac8/ui/accelerated_widget_mac/ca_layer_tree_unittest_mac.mm
[modify] https://crrev.com/39c18b9eb123aa7e478249c5f71a4259285bcac8/ui/accelerated_widget_mac/ca_renderer_layer_tree.h
[modify] https://crrev.com/39c18b9eb123aa7e478249c5f71a4259285bcac8/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm

Sign in to add a comment