Hover state on inactive tab should be a bit more subtle |
||||||
Issue descriptionHas we discussed, let's make the shiny hover state a bit less shiny on incognito mode by reducing the alpha. We discussed 50% less visible but let's adjust based on actual implementation. The point is to get it as subtle as in normal mode.
,
Nov 16 2016
,
Nov 16 2016
I like this improvement a lot. Is it the same opacity value as the one in default theming ?
,
Nov 16 2016
,
Nov 16 2016
Great! And no, it is not. The opacity for default is actually 100%, and the code was setting the incognito alpha to 50%. What you're seeing is 30% opacity.
,
Nov 16 2016
thanks! I like it. If Alan is ok with it let's ship that :)
,
Nov 16 2016
Great! bettes@ - what do you think?
,
Nov 28 2016
Yeah looks good to me!
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87bb820f87298f13f33592b21210c9c2d19a6333 commit 87bb820f87298f13f33592b21210c9c2d19a6333 Author: shrike <shrike@chromium.org> Date: Mon Nov 28 23:10:19 2016 [Mac][Material Design] Adjust incognito hover glow. As requested by sgabriel@, this cl reduces the hover "glow" when mousing over an incognito tab. R=avi@chromium.org BUG= 632160 Review-Url: https://codereview.chromium.org/2506843002 Cr-Commit-Position: refs/heads/master@{#434766} [modify] https://crrev.com/87bb820f87298f13f33592b21210c9c2d19a6333/chrome/browser/ui/cocoa/tabs/tab_view.mm
,
Nov 29 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by shrike@chromium.org
, Nov 16 2016Owner: sgabr...@chromium.org
Status: Started (was: Assigned)
77.1 KB
77.1 KB Download
107 KB
107 KB Download