New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632155 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Trace can't be returned as stream when start-up tracing is used

Project Member Reported by caseq@chromium.org, Jul 27 2016

Issue description

Currently, the only way to specify that the trace should be returned as a stream is via "transferMode" parameter of Tracing.start protocol command.

When start-up tracing is used, we don't issue Tracing.start, so the trace is always returned in a "legacy" event-based mode.

 

Comment 1 by caseq@chromium.org, Jul 27 2016

Components: Platform>DevTools>Performance>Tracing
Labels: -Pri-3 OS-All Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e886e3aeb93dd1786d6c3323a2cbd2aa8d99b407

commit e886e3aeb93dd1786d6c3323a2cbd2aa8d99b407
Author: caseq <caseq@chromium.org>
Date: Thu Jul 28 00:57:28 2016

DevTools: update transfer mode in Tracing.start when using start-up tracing

BUG= 632155 

This allows clients to issue Tracing.start when tracing is already running, but only if it is runnins as a result of start-up tracing being active.
When this is the case, the only action we perform is updating the transfer mode, as Tracing.start is currently the only way to specify it.

Review-Url: https://codereview.chromium.org/2180423004
Cr-Commit-Position: refs/heads/master@{#408301}

[modify] https://crrev.com/e886e3aeb93dd1786d6c3323a2cbd2aa8d99b407/content/browser/devtools/protocol/tracing_handler.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f1cf4b80b8ed5af50b57fbe798af81a223a808c

commit 6f1cf4b80b8ed5af50b57fbe798af81a223a808c
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Thu Jul 28 19:38:48 2016

Roll src/third_party/catapult/ f3f785423..6b0563110 (2 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f3f7854232b5..6b0563110dd8

$ git log f3f785423..6b0563110 --date=short --no-merges --format='%ad %ae %s'

BUG= 632155 

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2189983003
Cr-Commit-Position: refs/heads/master@{#408455}

[modify] https://crrev.com/6f1cf4b80b8ed5af50b57fbe798af81a223a808c/DEPS

Comment 4 by caseq@chromium.org, Jul 29 2016

Status: Fixed (was: Started)

Sign in to add a comment