New issue
Advanced search Search tips

Issue 632143 link

Starred by 2 users
Status: Fixed
Owner:
dougarnett@chromium.org
Closed: Aug 2016
Cc:
dougarnett@chromium.org
petewil@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Offline Pages] Queued pages that have failed show as "Started" in offline-internals page instead of as "Failed"

Project Member Reported by dougarnett@chromium.org, Jul 27 2016 
Check if we are updating SavePageRequest status for failures.

I have some pages that have failed with Request Status 5 - Prerendering Failed. They have gone through their retry attempts. They are still in the request queue (TODO to purge) and have a Started status instead of a Failed status.

Seems like we should change status upon each failure but certainly after retries exhausted we need to get this status updated. 

This may become more important if we provide query support for queued items to 1P API.

Comment 1 by dougarnett@chromium.org, Jul 29 2016

Cc: petewil@chromium.org
Owner: dougarnett@chromium.org

Comment 2 by dougarnett@chromium.org, Jul 29 2016

Components: UI>Browser>Offline
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34ad8d1edc48ea257af035c270432475bac09755

commit 34ad8d1edc48ea257af035c270432475bac09755
Author: dougarnett <dougarnett@chromium.org>
Date: Thu Aug 04 20:12:01 2016

[Offline Pages] Moves Coordinator to using MarkAttemptStarted/MarkAttemptCompleted API.
This does fix the basic issue with the internals page showing STARTED status incorrectly
although we will be removing this Status separately.

Also adds new MarkAttemptAborted method for dealing with attempts we cancel because
chrome transitions to the foreground. [I imaging adding Pause support might also be reason to MarkAttemptAborted.]
BUG= 632143 

Review-Url: https://codereview.chromium.org/2209813002
Cr-Commit-Position: refs/heads/master@{#409881}

[modify] https://crrev.com/34ad8d1edc48ea257af035c270432475bac09755/chrome/browser/android/offline_pages/prerendering_offliner.cc
[modify] https://crrev.com/34ad8d1edc48ea257af035c270432475bac09755/components/offline_pages/background/offliner.h
[modify] https://crrev.com/34ad8d1edc48ea257af035c270432475bac09755/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/34ad8d1edc48ea257af035c270432475bac09755/components/offline_pages/background/request_coordinator.h
[modify] https://crrev.com/34ad8d1edc48ea257af035c270432475bac09755/components/offline_pages/background/request_coordinator_event_logger.cc
[modify] https://crrev.com/34ad8d1edc48ea257af035c270432475bac09755/components/offline_pages/background/request_coordinator_event_logger.h
[modify] https://crrev.com/34ad8d1edc48ea257af035c270432475bac09755/components/offline_pages/background/request_coordinator_event_logger_unittest.cc
[modify] https://crrev.com/34ad8d1edc48ea257af035c270432475bac09755/components/offline_pages/background/request_coordinator_unittest.cc
[modify] https://crrev.com/34ad8d1edc48ea257af035c270432475bac09755/components/offline_pages/background/request_queue.h
[modify] https://crrev.com/34ad8d1edc48ea257af035c270432475bac09755/components/offline_pages/background/save_page_request.cc
[modify] https://crrev.com/34ad8d1edc48ea257af035c270432475bac09755/components/offline_pages/background/save_page_request.h
[modify] https://crrev.com/34ad8d1edc48ea257af035c270432475bac09755/components/offline_pages/background/save_page_request_unittest.cc

Comment 4 by dougarnett@chromium.org, Aug 6 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment