[Findit] Grouping build failures doesn't work correctly because suspected tuples are being compared incorrectly |
|||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS x86_64 8172.62.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36 Steps to reproduce the problem: What is the expected behavior? Similar build failures with the same suspected tuples should be grouped together. Some build failures may not be, because try_job_util._GetMatchingGroup() compares a list to a tuple. This can be solved by comparing objects of the same type (lists to lists, or tuples to tuples) What went wrong? Suspected tuples are being compared incorrectly (Google Cloud Datastore converts tuples as lists, so we end up comparing two different types) Did this work before? N/A Chrome version: 51.0.2704.106 Channel: n/a OS Version: 8172.62.0 Flash Version: Shockwave Flash 22.0 r0
,
Jul 28 2016
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/9f0bd313ad2d8251f974e2f3764f76b87b21be63 commit 9f0bd313ad2d8251f974e2f3764f76b87b21be63 Author: josiahk <josiahk@google.com> Date: Mon Aug 01 22:02:21 2016 Compare lists to lists instead of lists to tuples, and change tests BUG= 632130 Review-Url: https://codereview.chromium.org/2179283009 [modify] https://crrev.com/9f0bd313ad2d8251f974e2f3764f76b87b21be63/appengine/findit/handlers/triage_analysis.py [modify] https://crrev.com/9f0bd313ad2d8251f974e2f3764f76b87b21be63/appengine/findit/waterfall/test/try_job_util_test.py [modify] https://crrev.com/9f0bd313ad2d8251f974e2f3764f76b87b21be63/appengine/findit/waterfall/try_job_util.py
,
Aug 22 2016
,
Apr 24 2017
Is this bug done? If so, please close.
,
Apr 25 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by chanli@chromium.org
, Jul 27 2016Components: Tools>Test>FindIt
Status: Started (was: Unconfirmed)