New issue
Advanced search Search tips

Issue 632113 link

Starred by 2 users
Status: Duplicate
Merged: issue 570456
Owner:
llozano@chromium.org
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Fix remaining 'cros lint' errors in toolchain-utils

Project Member Reported by cmt...@chromium.org, Jul 27 2016 
Please fix the following 'cros lint' errors:


/toolchain-utils/crosperf/suite_runner_unittest.py
************* Module suite_runner_unittest
W:229, 4: Access to a protected member _logger of a client class (protected-access)
W:236, 4: No exception type(s) specified (bare-except)
W:306, 4: Access to a protected member _logger of a client class (protected-access)
W:316, 4: No exception type(s) specified (bare-except)
W:326, 4: No exception type(s) specified (bare-except)
W:336, 4: No exception type(s) specified (bare-except)

toolchain-utils/crosperf/experiment_runner.py
************* Module experiment_runner
W:137,54: Access to a protected member _logger of a client class (protected-access)
R:  1, 0: Missing "from __future__ import print_function" line (missing-print-function)
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/70204447c3c103508f1b8e58d59a9b8f165e1c21

commit 70204447c3c103508f1b8e58d59a9b8f165e1c21
Author: Luis A. Lozano <llozano@google.com>
Date: Fri Dec 16 07:34:01 2016

Fix some lint warning in suite_runner*.

BUG= chromium:632113 
TEST=run_tests

Change-Id: I9fe070420153f5ae175db86961c95b1686ea7c8f
Reviewed-on: https://chromium-review.googlesource.com/421107
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Commit-Queue: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/70204447c3c103508f1b8e58d59a9b8f165e1c21/crosperf/suite_runner.py
[modify] https://crrev.com/70204447c3c103508f1b8e58d59a9b8f165e1c21/crosperf/suite_runner_unittest.py

Comment 2 by manojgupta@chromium.org, Sep 29 2017

Mergedinto: 570456
Status: Duplicate (was: Assigned)
►

Sign in to add a comment