New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632109 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Fix remaining 'cros lint' errors in toolchain-utils (3 of 5)

Project Member Reported by cmt...@chromium.org, Jul 27 2016

Issue description

Please fix the following 'cros lint' errors:

toolchain-utils/crosperf/download_images_buildid_test.py
************* Module download_images_buildid_test
R:  1, 0: Shebang should be #!/usr/bin/python2 or #!/usr/bin/python3 (bad-shebang)
C:  1, 0: Modules should have docstrings (even a one liner) (module-missing-docstring)
W:  5, 0: Uses of a deprecated module 'optparse' (deprecated-module)
C: 18, 0: Classes should have docstrings (even a one liner) (class-missing-docstring)
C: 83, 2: Second line should be blank (docstring-second-line-blank)
R:  1, 0: Missing "from __future__ import print_function" line (missing-print-function)

toolchain-utils/crosperf/image_checksummer.py
************* Module image_checksummer
C:  1, 0: Modules should have docstrings (even a one liner) (module-missing-docstring)
C: 11, 0: Classes should have docstrings (even a one liner) (class-missing-docstring)
C: 13, 2: Classes should have docstrings (even a one liner) (class-missing-docstring)
R:  1, 0: Missing "from __future__ import print_function" line (missing-print-function)


toolchain-utils/crosperf/mock_instance.py
************* Module mock_instance
W:  8, 0: Unused MockBenchmarkRun imported from benchmark_run (unused-import)
W: 10, 0: Unused MockMachineManager imported from machine_manager (unused-import)
W: 11, 0: Unused MockResultsCache imported from results_cache (unused-import)
R:  1, 0: Missing "from __future__ import print_function" line (missing-print-function)



 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/toolchain-utils/+/0c6b64a92171fc48773c6f83fcff4ee8e07b013b

commit 0c6b64a92171fc48773c6f83fcff4ee8e07b013b
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Fri Jul 29 20:17:07 2016

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/toolchain-utils/+/90c7d37553ae22cfce56bc7423fc9735f271fc6f

commit 90c7d37553ae22cfce56bc7423fc9735f271fc6f
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Fri Jul 29 21:30:11 2016

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/toolchain-utils/+/685ed888ddb849232644b20a2d9cb72be403aac3

commit 685ed888ddb849232644b20a2d9cb72be403aac3
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Fri Jul 29 21:36:33 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/toolchain-utils/+/a4effef8ac1f221419ced5833c01a6d9f6f26d5f

commit a4effef8ac1f221419ced5833c01a6d9f6f26d5f
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Fri Jul 29 21:39:33 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/toolchain-utils/+/34da9b80e2858b6ed6f76c9a23be6ce7df580ace

commit 34da9b80e2858b6ed6f76c9a23be6ce7df580ace
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Fri Jul 29 21:49:31 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/toolchain-utils/+/40ca64bca93984da431ff83739467553bcf7882e

commit 40ca64bca93984da431ff83739467553bcf7882e
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Fri Jul 29 21:55:25 2016

Status: Fixed (was: Assigned)
Labels: VerifyIn-54

Comment 9 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 10 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 11 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 12 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 13 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 14 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61
Status: Verified (was: Fixed)
Closing. Please reopen it if its not fixed. Thanks!

Sign in to add a comment