New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632108 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Fix remaining 'cros lint' errors in toolchain-utils (2 of 5)

Project Member Reported by cmt...@chromium.org, Jul 27 2016

Issue description

Please fix the following 'cros lint' errors in toolchain-utils:


toolchain-utils/crosperf/flag_test_unittest.py
************* Module flag_test_unittest
R:  1, 0: Shebang should be #!/usr/bin/python2 or #!/usr/bin/python3 (bad-shebang)
C:  1, 0: Modules should have docstrings (even a one liner) (module-missing-docstring)
C: 10, 0: Classes should have docstrings (even a one liner) (class-missing-docstring)
W: 15,25: Access to a protected member _is_test of a client class (protected-access)
W: 16,25: Access to a protected member _is_test of a client class (protected-access)
W: 33,25: Access to a protected member _is_test of a client class (protected-access)
W: 34,25: Access to a protected member _is_test of a client class (protected-access)
R:  1, 0: Missing "from __future__ import print_function" line (missing-print-function)

toolchain-utils/crosperf/experiment_file_unittest.py
************* Module experiment_file_unittest
R:  1, 0: Shebang should be #!/usr/bin/python2 or #!/usr/bin/python3 (bad-shebang)
C:  1, 0: Modules should have docstrings (even a one liner) (module-missing-docstring)
C: 86, 0: Classes should have docstrings (even a one liner) (class-missing-docstring)
R:  1, 0: Missing "from __future__ import print_function" line (missing-print-function)


toolchain-utils/crosperf/experiment_file.py
************* Module experiment_file
C:  1, 0: Modules should have docstrings (even a one liner) (module-missing-docstring)
W:  8, 0: Unused Settings imported from settings (unused-import)
R:  1, 0: Missing "from __future__ import print_function" line (missing-print-function)





 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/toolchain-utils/+/12d0f2398963f4b9eaded60786422a455f199e45

commit 12d0f2398963f4b9eaded60786422a455f199e45
Author: Yunlian Jiang <yunlian@chromium.org>
Date: Fri Jul 29 22:48:50 2016

Status: Fixed (was: Assigned)
Labels: VerifyIn-54

Comment 4 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 5 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 6 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58
Status: Verified (was: Fixed)

Sign in to add a comment