New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632106 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not currently working on Chromium
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 632100



Sign in to add a comment

bluetooth: Remove bluetooth bad flags warning

Project Member Reported by scheib@chromium.org, Jul 27 2016

Issue description

When chrome://flags/#enable-web-bluetooth is used today it produces a scary  message about the security when using the flag.

This is no longer needed, because the chooser UI has now been implemented.

See:
https://cs.chromium.org/chromium/src/chrome/browser/ui/startup/bad_flags_prompt.cc?type=cs&q=kenablewebbluetooth+f:bad_flags&sq=package:chromium&l=94
 

Comment 1 by scheib@chromium.org, Jul 27 2016

Owner: scheib@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c2ad05d80370b0054011b9bcf80e922aec02a81

commit 7c2ad05d80370b0054011b9bcf80e922aec02a81
Author: scheib <scheib@chromium.org>
Date: Thu Aug 04 01:59:16 2016

bluetooth: Remove Web Bluetooth from Bad Flags Prompt.

Initially the --enable-web-bluetooth flag was considered risky because
the chooser UI had not yet been implemented -- thus not giving users
an affordance to accept or deny the request. The first device found
was always returned, premission presumed.

Now the chooser UI is implemented on all platforms, and
--enable-web-bluetooth no longer needs to be considered a bad flag.

This partially reverts
 "bluetooth: Add a WebBluetooth command line flag"
 https://codereview.chromium.org/1134473003

BUG= 632106 

Review-Url: https://codereview.chromium.org/2192573002
Cr-Commit-Position: refs/heads/master@{#409702}

[modify] https://crrev.com/7c2ad05d80370b0054011b9bcf80e922aec02a81/chrome/browser/ui/startup/bad_flags_prompt.cc

Status: Fixed (was: Started)

Sign in to add a comment