New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632098 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Fix remaining 'cros lint' errors in toolchain-utils

Project Member Reported by cmt...@chromium.org, Jul 27 2016

Issue description

Please fix the following 'cros lint' errors in toolchain-utils:

toolchain-utils/crosperf/machine_image_manager.py
************* Module machine_image_manager
C:  1, 0: Modules should have docstrings (even a one liner) (module-missing-docstring)
W:146,25: Unused variable 'd' (unused-variable)
C:193, 2: Section names should be "Args:", "Returns:", "Yields:", and "Raises:": offset:2: {        Arguments:} (docstring-section-name)
W:218,29: Access to a protected member _label_brl_map of a client class (protected-access)
W:272,11: Unused variable 'l' (unused-variable)
W:280,11: Unused variable 'd' (unused-variable)
C:283, 2: Leading whitespace in docstring (excess or missing): offset:0: { Search matrix for d with N. } (docstring-leading-whitespace)
C:283, 2: Trailing whitespace in docstring: offset:1: { Search matrix for d with N. } (docstring-trailing-whitespace)

../work/toolchain-utils/crosperf/download_images.py
************* Module download_images
C:  1, 0: Modules should have docstrings (even a one liner) (module-missing-docstring)
E: 10, 0: No name 'command_executer' in module 'utils' (no-name-in-module)
C: 17, 0: Classes should have docstrings (even a one liner) (class-missing-docstring)
W: 31, 4: Unused variable 'retval' (unused-variable)
R:  1, 0: Missing "from __future__ import print_function" line (missing-print-function)


../work/toolchain-utils/crosperf/results_organizer_unittest.py
************* Module results_organizer_unittest
R:  1, 0: Shebang should be #!/usr/bin/python2 or #!/usr/bin/python3 (bad-shebang)
C:  1, 0: Second line should be blank (docstring-second-line-blank)
C:  1, 0: Closing triple quotes should not be cuddled (docstring-cuddled-quotes)
C: 69, 0: Classes should have docstrings (even a one liner) (class-missing-docstring)
R:  1, 0: Missing "from __future__ import print_function" line (missing-print-function)



 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/toolchain-utils/+/2e307b303ac37c3e971086f23da2df25fef2c1b4

commit 2e307b303ac37c3e971086f23da2df25fef2c1b4
Author: Ting-Yuan Huang <laszio@google.com>
Date: Tue Aug 02 21:02:02 2016

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/toolchain-utils/+/2e307b303ac37c3e971086f23da2df25fef2c1b4

commit 2e307b303ac37c3e971086f23da2df25fef2c1b4
Author: Ting-Yuan Huang <laszio@google.com>
Date: Tue Aug 02 21:02:02 2016

Status: Fixed (was: Assigned)
Labels: VerifyIn-54

Comment 5 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 6 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 7 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61
Status: Verified (was: Fixed)
Closing. Please reopen it if its not fixed. Thanks!

Sign in to add a comment