Issue 632093 link

Starred by 2 users

Issue metadata

Status:	Archived
Owner:	█ kevcheng@chromium.org Last visit > 30 days ago
Closed:	Aug 2016
Components:	Infra>Client>ChromeOS
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
VerifyIn-54 VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Servo verification fails with the new servod upstart job

Reported by jrbarnette@chromium.org, Jul 27 2016

Issue description

When constructing a ServoHost object, we normally call
the `verify()` method.  That method includes calling
`_check_servod()`, which includes this code:
        try:
            self.run('test -f /var/lib/servod/config')
        except (error.AutoservRunError, error.AutoservSSHTimeout) as e:
            # ...

With the new servod upstart job, the "servod/config" file no
longer exists.  Typically, it will be named "servod/config_9999"
instead.

This only happens with a servo image that's freshly installed,
so it's primarily affecting only new deployments.

chromeos4-row8-rack9-host11.log
22.8 KB View Download

Comment 1 by jrbarnette@chromium.org, Jul 27 2016

Components: Infra>Client>ChromeOS
Labels: -Pri-3 Pri-1
Owner: kevcheng@chromium.org
Status: Available (was: Unconfirmed)

We've rolled back the servo update that enabled the new
upstart job, so this problem won't be affecting the lab
for a little while.

I think the fix is to adjust the servo verification code
so that when we re-update to the new servo image, this
check will work with the new or the old job.

Comment 2 by jrbarnette@chromium.org, Jul 27 2016

The attached log file is from a failing deployment.

The actual name of the failing method is `_check_servo_config()`.
Here's the traceback, FWIW:
Traceback (most recent call last):
  File "/usr/local/google/home/rbaddo/chromiumos/new_lab_tools/src/third_party/autotest/files/site_utils/deployment/install.py", line 457, in _install_dut
    _install_and_record(afe, hostname, arguments)
  File "/usr/local/google/home/rbaddo/chromiumos/new_lab_tools/src/third_party/autotest/files/site_utils/deployment/install.py", line 403, in _install_and_record
    _install_test_image(hostname, arguments)
  File "/usr/local/google/home/rbaddo/chromiumos/new_lab_tools/src/third_party/autotest/files/site_utils/deployment/install.py", line 354, in _install_test_image
    _check_servo(host)
  File "/usr/local/google/home/rbaddo/chromiumos/new_lab_tools/src/third_party/autotest/files/site_utils/deployment/install.py", line 232, in _check_servo
    servo_host.verify()
  File "/usr/local/google/home/rbaddo/chromiumos/new_lab_tools/src/third_party/autotest/files/client/common_lib/hosts/base_classes.py", line 331, in verify
    self.verify_software()
  File "/usr/local/google/home/rbaddo/chromiumos/new_lab_tools/src/third_party/autotest/files/server/hosts/servo_host.py", line 568, in verify_software
    self._check_servo_config()
  File "/usr/local/google/home/rbaddo/chromiumos/new_lab_tools/src/third_party/autotest/files/server/hosts/servo_host.py", line 349, in _check_servo_config
    (self.hostname, e))
ServoHostVerifyFailure: Servo config file check failed for chromeos4-row8-rack9-host11-servo: command execution error

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cdece6ba5b0e651a6b9350d19e8c429bbbf70680

commit cdece6ba5b0e651a6b9350d19e8c429bbbf70680
Author: Kevin Cheng <kevcheng@chromium.org>
Date: Wed Jul 27 19:55:01 2016

[autotest] Update servo_host verify to check for multiple servod configs.

The updated servod upstart job creates the servod config file using the
nomenclature "config_$PORT" and we need to update the verify to
accommodate for that change (and also check for the old style config
file).

BUG= chromium:632093 
TEST=Locally on moblab that files are detected (either one) and if both
are not there, will fail as expected.

Change-Id: Iddee4d0c0eb4cde3e9d5402a321e8eb383d848d8
Reviewed-on: https://chromium-review.googlesource.com/363910
Commit-Ready: Kevin Cheng <kevcheng@chromium.org>
Tested-by: Kevin Cheng <kevcheng@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/cdece6ba5b0e651a6b9350d19e8c429bbbf70680/server/hosts/servo_host.py