New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632083 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[ARC++ WM] Update arc++ tasks with correct display/workspace metrics once when rotating display

Project Member Reported by osh...@chromium.org, Jul 27 2016

Issue description

chrome side bug for b/30258710
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80d20b2f6bc5a6aa8e0caa37f517aef783d3186d

commit 80d20b2f6bc5a6aa8e0caa37f517aef783d3186d
Author: oshima <oshima@chromium.org>
Date: Mon Aug 01 23:46:45 2016

Add configuration_changed event and set_background_opacity request.

* remote shell API version is updated to 9.

* Send the current primary display info because primary display is dynamic and can change or even go away.

* This also fixed a bug where a underlay wasn't created when it started maximized.

BUG= 632083 
TEST=tested on new and old impl on android side. Updated unit test.

Review-Url: https://codereview.chromium.org/2189073003
Cr-Commit-Position: refs/heads/master@{#409089}

[modify] https://crrev.com/80d20b2f6bc5a6aa8e0caa37f517aef783d3186d/components/exo/shell_surface.cc
[modify] https://crrev.com/80d20b2f6bc5a6aa8e0caa37f517aef783d3186d/components/exo/shell_surface.h
[modify] https://crrev.com/80d20b2f6bc5a6aa8e0caa37f517aef783d3186d/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/80d20b2f6bc5a6aa8e0caa37f517aef783d3186d/components/exo/wayland/server.cc
[modify] https://crrev.com/80d20b2f6bc5a6aa8e0caa37f517aef783d3186d/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h
[modify] https://crrev.com/80d20b2f6bc5a6aa8e0caa37f517aef783d3186d/third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h
[modify] https://crrev.com/80d20b2f6bc5a6aa8e0caa37f517aef783d3186d/third_party/wayland-protocols/protocol/remote-shell-protocol.c
[modify] https://crrev.com/80d20b2f6bc5a6aa8e0caa37f517aef783d3186d/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml

Labels: Merge-Request-53

Comment 3 by dimu@chromium.org, Aug 2 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Status: Fixed (was: Started)
It's merged in https://codereview.chromium.org/2204063002/, but git failed to update the CL. 
Labels: -Merge-Approved-53 Merge-Merged
Cc: steve...@chromium.org khmel@chromium.org posciak@chromium.org bhthompson@chromium.org
CC: [sheriffs and TPM].

The cherry pick looks causing build breakage.
Revision: 53.0.2785.45

../../components/exo/wayland/server.cc: In member function 'virtual void exo::wayland::{anonymous}::WaylandRemoteShell::OnDisplayWorkAreaInsetsChanged()':
../../components/exo/wayland/server.cc:1617:66: error: 'SendConfigure' was not declared in this scope
  void OnDisplayWorkAreaInsetsChanged() override { SendConfigure(); }
Please feel free to revert. I'll test it locally and reland again.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 3 2016

Labels: merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f38962edfcc46c2dc91b426ce24fa43993529cc

commit 9f38962edfcc46c2dc91b426ce24fa43993529cc
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Wed Aug 03 14:04:27 2016

Resolve conflict in exo/wayland/server.cc in m53 branch

The method OnDisplayWorkareInsetsChanged has been removed on ToT, so this method wasn't updated in the original CL.

BUG= 632083 
TBR=hidehiko@chromium.org

Review URL: https://codereview.chromium.org/2203393002 .

Cr-Commit-Position: refs/branch-heads/2785@{#484}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/9f38962edfcc46c2dc91b426ce24fa43993529cc/components/exo/wayland/server.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a9853c91d1c2cb9ac862373603b1304859a6e35

commit 9a9853c91d1c2cb9ac862373603b1304859a6e35
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Wed Aug 03 22:41:09 2016

Resolve conflict in exo/wayland/server.cc in m53 branch

The method OnDisplayWorkareInsetsChanged has been removed on ToT, so this method wasn't updated in the original CL.

BUG= 632083 
TBR=hidehiko@chromium.org

Cr-Commit-Position: refs/branch-heads/2785@{#484}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/9f38962edfcc46c2dc91b426ce24fa43993529cc/components/exo/wayland/server.cc

Review URL: https://codereview.chromium.org/2203393002 .

Cr-Commit-Position: refs/branch-heads/2785@{#491}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/9a9853c91d1c2cb9ac862373603b1304859a6e35/components/exo/wayland/server.cc

Comment 11 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 12 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 13 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 14 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 16 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment