Issue 632071 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	jamescook@chromium.org
Closed:	Jul 2016
Cc:	msw@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
mash VerifyIn-54 VerifyIn-55 VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Blocking:
issue 615155

mash shelf: Convert ShelfButton to wm common types

Project Member Reported by jamescook@chromium.org, Jul 27 2016

Issue description

There's not much to be done here, but it could stand to be converted from Shelf* to WmShelf*

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8274f0b783fa6272dd093f2c76b47a624bb036b

commit a8274f0b783fa6272dd093f2c76b47a624bb036b
Author: jamescook <jamescook@chromium.org>
Date: Wed Jul 27 20:18:28 2016

mash: Migrate ShelfButton* to wm common types

* Convert from Shelf to WmShelf
* Move to //ash/common/shelf

BUG= 632071 
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2187953002
Cr-Commit-Position: refs/heads/master@{#408224}

[modify] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/ash.gyp
[modify] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/aura/wm_shelf_aura.h
[modify] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/common/shelf/DEPS
[rename] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/common/shelf/shelf_button.cc
[rename] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/common/shelf/shelf_button.h
[rename] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/common/shelf/shelf_button_pressed_metric_tracker.cc
[rename] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/common/shelf/shelf_button_pressed_metric_tracker.h
[rename] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/common/shelf/shelf_button_pressed_metric_tracker_unittest.cc
[modify] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/common/shelf/wm_shelf.h
[modify] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/mus/bridge/wm_shelf_mus.cc
[modify] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/mus/bridge/wm_shelf_mus.h
[modify] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/shelf/shelf.h
[modify] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/shelf/shelf_unittest.cc
[modify] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/shelf/shelf_view.cc
[modify] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/shelf/shelf_view.h
[modify] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/test/shelf_button_pressed_metric_tracker_test_api.h
[modify] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/test/shelf_view_test_api.cc
[modify] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc