Deprecate and remove pre-TBM memory benchmarks/metrics |
|||||||||||||||
Issue descriptionNow that system_health memory benchmarks are running both for desktop and mobile, we can now safely deprecate the benchmarks: - memory.mobile_memory - memory.top_7_stress Will send out an announcement and remove them if no concerns are raised. Also wrote a doc (readable by @chromium.org) on the larger plan to deprecate the pre-TBM memory metrics: https://docs.google.com/a/chromium.org/document/d/1AJ4GvwauT3LNHtEDEvai5DcXNzdX-ANziI3Mu6_Nvrk/edit?usp=sharing
,
Jul 27 2016
,
Aug 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa8eea695d0c9a705b21bac31ef01eaf4d9e638f commit fa8eea695d0c9a705b21bac31ef01eaf4d9e638f Author: perezju <perezju@chromium.org> Date: Wed Aug 03 18:35:14 2016 [tools/perf] Remove deprecated memory.* benchmarks Remove the benchmarks: - memory.mobile_memory - memory.top_7_stress Also remove the (now unused) memory.Memory page test. BUG= 632021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2197153002 Cr-Commit-Position: refs/heads/master@{#409577} [modify] https://crrev.com/fa8eea695d0c9a705b21bac31ef01eaf4d9e638f/tools/perf/benchmarks/benchmark_smoke_unittest.py [delete] https://crrev.com/09668775e4444502eb38f0253b80be94f2245440/tools/perf/benchmarks/memory.py [delete] https://crrev.com/09668775e4444502eb38f0253b80be94f2245440/tools/perf/measurements/memory.py
,
Aug 9 2016
,
Aug 10 2016
Is there any more work that needs to be done on this? It's blocking a P1 bug, so raising priority to match.
,
Aug 12 2016
,
Sep 2 2016
Sent deprecation announcement https://groups.google.com/a/chromium.org/forum/#!topic/telemetry-announce/HSEYuAzHLSQ
,
Sep 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1d8aaf9fae713d96348e869877aa9c00970a71b commit c1d8aaf9fae713d96348e869877aa9c00970a71b Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Fri Sep 02 16:37:40 2016 Roll src/third_party/catapult/ 6256ea38c..54acca7c4 (1 commit). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6256ea38cc13..54acca7c4f74 $ git log 6256ea38c..54acca7c4 --date=short --no-merges --format='%ad %ae %s' 2016-09-02 perezju [Telemetry] Schedule platform.GetMemoryStats for deprecation BUG= 632021 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2306883003 Cr-Commit-Position: refs/heads/master@{#416281} [modify] https://crrev.com/c1d8aaf9fae713d96348e869877aa9c00970a71b/DEPS
,
Oct 5 2016
,
Oct 5 2016
,
Nov 25 2016
Nothing to do on our side other than waiting for the blocker bugs to be addressed by other folks (deleting the remaining benchmarks). rebump the priority on this once they get resolved.
,
Nov 30 2016
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/559df8d5a6074fe7697d5ba6be68053dfd389888 commit 559df8d5a6074fe7697d5ba6be68053dfd389888 Author: Gurchetan Singh <gurchetansingh@google.com> Date: Mon Apr 17 22:49:21 2017 telemetry_Benchmarks: remove unused benchmarks The following benchmarks have been deleted: memory.top_7_stress (see http://crrev.com/2197153002) tab_switching.top_10 (see http://crrev.com/2761363004) Let's remove them there too. BUG= chromium:689388 , chromium:632021 TEST=commit-queue Change-Id: I63412461026c129cb4dfbb0a723732475670accb Reviewed-on: https://chromium-review.googlesource.com/479408 Reviewed-by: Ilja H. Friedel <ihf@chromium.org> Trybot-Ready: Ilja H. Friedel <ihf@chromium.org> Tested-by: Ilja H. Friedel <ihf@chromium.org> [modify] https://crrev.com/559df8d5a6074fe7697d5ba6be68053dfd389888/server/site_tests/telemetry_Benchmarks/generate_controlfiles.py [delete] https://crrev.com/ee6f508da1fb689392d9079d20383dfb6cf2137c/server/site_tests/telemetry_Benchmarks/control.memory.top_7_stress [delete] https://crrev.com/ee6f508da1fb689392d9079d20383dfb6cf2137c/server/site_tests/telemetry_Benchmarks/control.tab_switching.top_10
,
Jul 14 2017
,
Jul 14 2017
,
Jul 17 2017
,
Oct 30 2017
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04940300e3c098edd27ba3360113f54836fa7bcb commit 04940300e3c098edd27ba3360113f54836fa7bcb Author: Juan A. Navarro Perez <perezju@chromium.org> Date: Mon Oct 30 18:35:55 2017 [tools/perf] Remove obsolete memory.MemoryMetric The metric is no longer used, should be dead code now. Bug: 632021 Change-Id: Ic6615654a74128b2782ae93fbf7c05dc95e4aaa9 Reviewed-on: https://chromium-review.googlesource.com/744201 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#512537} [delete] https://crrev.com/f1b815290d83b4fbe74c6b194d0c822efca7f361/tools/perf/metrics/memory.py [modify] https://crrev.com/04940300e3c098edd27ba3360113f54836fa7bcb/tools/perf/metrics/system_memory.py
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d260b6a278276c6d63d27efbf2f69f1286d98b5b commit d260b6a278276c6d63d27efbf2f69f1286d98b5b Author: Juan A. Navarro Perez <perezju@chromium.org> Date: Mon Oct 30 20:18:51 2017 [tools/perf] Remove indexeddb_perf dead code Nothing appears to be using this pageset_data. Benchmark was deleted at: https://chromium-review.googlesource.com/684416 Bug: 632021 Change-Id: Ic9f1ff242f97e79ac9faec80a7e98fba9dbc39be Reviewed-on: https://chromium-review.googlesource.com/744202 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#512596} [modify] https://crrev.com/d260b6a278276c6d63d27efbf2f69f1286d98b5b/tools/perf/BUILD.gn [delete] https://crrev.com/45e4bb98c866851103042960ad147c63425d6798/tools/perf/page_sets/indexeddb_perf/endure/app-worker.js [delete] https://crrev.com/45e4bb98c866851103042960ad147c63425d6798/tools/perf/page_sets/indexeddb_perf/endure/app.html [delete] https://crrev.com/45e4bb98c866851103042960ad147c63425d6798/tools/perf/page_sets/indexeddb_perf/endure/app.js [delete] https://crrev.com/45e4bb98c866851103042960ad147c63425d6798/tools/perf/page_sets/indexeddb_perf/perf_shared.js [delete] https://crrev.com/45e4bb98c866851103042960ad147c63425d6798/tools/perf/page_sets/indexeddb_perf/perf_test.html [delete] https://crrev.com/45e4bb98c866851103042960ad147c63425d6798/tools/perf/page_sets/indexeddb_perf/perf_test.js
,
Oct 31 2017
Nearly there, only remains a legacy system_memory.SystemMemoryMetric, whose last few clients are: - media.media_cns_cases (to be removed in issue 676345 ) - a few media pages based on BeginningToEndPlayPage Usage of the legacy metric is gated through: https://cs.chromium.org/search/?q=%5C.add_browser_metrics
,
Nov 9 2017
media_cns_cases is deleted. The BeginningToEndPlayPage now is hooked up to TBMv2 in all cases and the self.add_browser_metrics is deleted from it (it was dead code anyway: https://chromium-review.googlesource.com/c/chromium/src/+/759318). Seems like you're ready to delete system_memory.py!
,
Nov 9 2017
Wow, this is a 1 year and a half clean up bug, infra is just... hard :-)
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2ddf5029df138e244203446c8bd81b81d09f909 commit d2ddf5029df138e244203446c8bd81b81d09f909 Author: Caleb Rouleau <crouleau@chromium.org> Date: Thu Nov 09 03:14:17 2017 [Telemetry] Remove dead code from media_cases.py. I think this used to be used for back when we had a legacy benchmark, but our current benchmark is TBMv2, so we can't configure which metrics to generate in which cases anymore. Bug: 632021 Change-Id: I5c9c3ce7c823c59984fd4989194d389be0569986 Reviewed-on: https://chromium-review.googlesource.com/759318 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#515083} [modify] https://crrev.com/d2ddf5029df138e244203446c8bd81b81d09f909/tools/perf/page_sets/media_cases.py
,
Nov 9 2017
Woohoo! This is awesome! I'll get to chop away some more of the dead code.
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26f7e595d7902840edd7b95547d63f2de8a7a0b0 commit 26f7e595d7902840edd7b95547d63f2de8a7a0b0 Author: Juan A. Navarro Perez <perezju@chromium.org> Date: Thu Nov 09 21:39:01 2017 [tools/perf] Remove system_memory.SystemMemoryMetric This is now dead code. Bug: 632021 Change-Id: I6b7331ae6bd784fc329ffc58171e3c0aaaf4937b Reviewed-on: https://chromium-review.googlesource.com/761376 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#515301} [delete] https://crrev.com/3e4788635716875ee914419a9c632efa8f5bce39/tools/perf/metrics/system_memory.py
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/f5d92693eb80907f2a45e229f8c01b19305ec4ee commit f5d92693eb80907f2a45e229f8c01b19305ec4ee Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Mon Nov 13 12:25:03 2017 [Telemetry] Remove deprecated memory_stats The following are no longer used and are thus removed: - browser.memory_stats - platform_backend.GetMemoryStats() - platform_backend.PurgeUnpinnedMemory() - platform_backend.GetSystemCommitCharge() Bug: chromium:632021 Change-Id: Ie7d57eec2a740f017555668a4edc083982ac46f4 Reviewed-on: https://chromium-review.googlesource.com/761338 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/f5d92693eb80907f2a45e229f8c01b19305ec4ee/telemetry/telemetry/internal/platform/platform_backend.py [modify] https://crrev.com/f5d92693eb80907f2a45e229f8c01b19305ec4ee/telemetry/telemetry/internal/platform/linux_based_platform_backend_unittest.py [modify] https://crrev.com/f5d92693eb80907f2a45e229f8c01b19305ec4ee/telemetry/telemetry/internal/platform/win_platform_backend.py [modify] https://crrev.com/f5d92693eb80907f2a45e229f8c01b19305ec4ee/telemetry/telemetry/internal/platform/mac_platform_backend.py [modify] https://crrev.com/f5d92693eb80907f2a45e229f8c01b19305ec4ee/telemetry/telemetry/internal/platform/android_platform_backend.py [modify] https://crrev.com/f5d92693eb80907f2a45e229f8c01b19305ec4ee/telemetry/telemetry/internal/browser/browser.py [modify] https://crrev.com/f5d92693eb80907f2a45e229f8c01b19305ec4ee/telemetry/telemetry/internal/platform/linux_based_platform_backend.py [modify] https://crrev.com/f5d92693eb80907f2a45e229f8c01b19305ec4ee/telemetry/telemetry/internal/browser/browser_unittest.py
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/445e9e3fa4091ce8216988dc978b966ac570307b commit 445e9e3fa4091ce8216988dc978b966ac570307b Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Tue Nov 14 09:03:42 2017 [devil] Remove device.GetMemoryUsageForPid() No longer used as of: http://chromium-review.googlesource.com/c/catapult/+/761338 The currently supported way to measure memory is via tracing and memory-infra. Also update devil/docs/device_utils.md Bug: chromium:632021 Change-Id: If83398977218b16f7cad99a2d76666461078df70 Reviewed-on: https://chromium-review.googlesource.com/761696 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/445e9e3fa4091ce8216988dc978b966ac570307b/devil/devil/android/device_utils.py [modify] https://crrev.com/445e9e3fa4091ce8216988dc978b966ac570307b/devil/docs/device_utils.md [modify] https://crrev.com/445e9e3fa4091ce8216988dc978b966ac570307b/devil/devil/android/device_utils_test.py
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/c44654bacfc5866bbafe00b7fac50f87c82a4103 commit c44654bacfc5866bbafe00b7fac50f87c82a4103 Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Tue Nov 14 12:06:36 2017 [Telemetry] Remove purge_ashmem dependency Tool no longer used by Telemetry. Bug: chromium:632021 Change-Id: I246073be82de948ac83775c4867c310c18767d7e Reviewed-on: https://chromium-review.googlesource.com/768670 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [delete] https://crrev.com/445e9e3fa4091ce8216988dc978b966ac570307b/telemetry/bin/android/arm64-v8a/purge_ashmem.sha1 [modify] https://crrev.com/c44654bacfc5866bbafe00b7fac50f87c82a4103/telemetry/telemetry/internal/binary_dependencies.json [delete] https://crrev.com/445e9e3fa4091ce8216988dc978b966ac570307b/telemetry/bin/android/armeabi-v7a/purge_ashmem.sha1
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b9a86df3a6c72200f61065de82c6b45ed20bbab commit 9b9a86df3a6c72200f61065de82c6b45ed20bbab Author: Juan A. Navarro Perez <perezju@chromium.org> Date: Tue Nov 14 17:20:17 2017 [tools/android] Remove purge_ashmem tool Tool is no longer used. Bug: 632021 Change-Id: Ib3fc75c0fdfa0d60ae9187e3009572ba694a7f3c Reviewed-on: https://chromium-review.googlesource.com/768733 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#516340} [modify] https://crrev.com/9b9a86df3a6c72200f61065de82c6b45ed20bbab/tools/android/BUILD.gn [delete] https://crrev.com/32522b611fe1b8c5dfb2e8111baca350115dc19d/tools/android/purge_ashmem/BUILD.gn [delete] https://crrev.com/32522b611fe1b8c5dfb2e8111baca350115dc19d/tools/android/purge_ashmem/purge_ashmem.c
,
Nov 14 2017
This is done! 🎉🎆 |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by nedngu...@google.com
, Jul 27 2016