New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 632020 link

Starred by 2 users
Status: Fixed
Owner:
mcasas@chromium.org
Closed: Aug 2016
Cc:
tommi@chromium.org
emir...@chromium.org
█ perkj@chromium.org
mcasas@chromium.org
chfremer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 633257



Sign in to add a comment

Cleanup: move content/browser/media/webrtc/ into content/browser/webrtc

Project Member Reported by mcasas@chromium.org, Jul 27 2016 
content/browser/media/webrtc/ is a bunch of content_browsertests
and the code for chrome://webrtc-internals. 

It includes nothing from its parent content/browser/media, neither
does content/browser/media/ include anything from its child.

Ergo: Move content/browser/media/webrtc/ to content/browser/webrtc.

Comment 1 by chfremer@chromium.org, Jul 27 2016 

Sounds reasonable to me.

Comment 2 by mcasas@chromium.org, Jul 29 2016 

ping tommi@ perkj@ emircan@, WDYT?

Comment 3 by emir...@chromium.org, Jul 29 2016 

Sgtm.

Comment 4 by mcasas@chromium.org, Jul 29 2016

Owner: mcasas@chromium.org
Status: Started (was: Available)
This is happening in https://codereview.chromium.org/2193343002/
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae

commit 6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae
Author: mcasas <mcasas@chromium.org>
Date: Fri Jul 29 23:04:35 2016

Cleanup: move content/browser/media/webrtc/ to content/browser/webrtc

No new code, just shuffling files around -- commands:

 git mv content/browser/media/webrtc content/browser/
 tools/git/mass-rename.py

BUG= 632020 

Review-Url: https://codereview.chromium.org/2193343002
Cr-Commit-Position: refs/heads/master@{#408796}

[delete] https://crrev.com/4642f6d990020c2d15902b0de97b0acc70defc51/content/browser/media/webrtc/OWNERS
[modify] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/renderer_host/media/audio_input_renderer_host.cc
[modify] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/renderer_host/media/peer_connection_tracker_host.cc
[modify] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/renderer_host/render_process_host_impl.h
[add] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/OWNERS
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_browsertest.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_browsertest_audio.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_browsertest_data.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_capture_from_element_browsertest.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_content_browsertest_base.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_content_browsertest_base.h
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_datachannel_browsertest.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_eventlog_host.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_eventlog_host.h
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_eventlog_host_unittest.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_image_capture_browsertest.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_internals.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_internals.h
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_internals_browsertest.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_internals_message_handler.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_internals_message_handler.h
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_internals_message_handler_unittest.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_internals_ui.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_internals_ui.h
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_internals_ui_observer.h
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_internals_unittest.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_ip_permissions_browsertest.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_media_recorder_browsertest.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_webcam_browsertest.cc
[rename] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webrtc/webrtc_webcam_browsertest.h
[modify] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/browser/webui/content_web_ui_controller_factory.cc
[modify] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/content_browser.gypi
[modify] https://crrev.com/6b8c0c85dca2fd65a82c6d0eb8477de4c10b02ae/content/content_tests.gypi

Comment 6 by mcasas@chromium.org, Aug 1 2016

Status: Fixed (was: Started)

Comment 7 by mcasas@chromium.org, Aug 1 2016

Blocking: 633257
►

Sign in to add a comment