fast/images/paint-subrect-grid.html fails |
||||||||
Issue descriptionFirst failing build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/68075 (stdio attached). The test seems related to Skia, and there was a Skia roll https://codereview.chromium.org/2185003002 in the blamelist, so I'm Cc-ing authors of the 2 rolled Skia CLs (https://chromium.googlesource.com/skia.git/+/9f97882322929ee39405acb44cbf155854b38091 and https://chromium.googlesource.com/skia.git/+/39683791cc8142ff5e614b567e309cf920b32358): please have a look, if you can fix this, great, if you know who else to loop in, also great. Cheers, today's sheriff.
,
Jul 27 2016
Definitely not related to my isolate file change.
,
Jul 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d30b7dc473439a6b2123fd93ef88c9a2bbaef20a commit d30b7dc473439a6b2123fd93ef88c9a2bbaef20a Author: vabr <vabr@chromium.org> Date: Wed Jul 27 14:51:18 2016 Disable fast/images/paint-subrect-grid.html on Linux BUG= 632000 TBR=brianosman@google.com NOTRY=true Review-Url: https://codereview.chromium.org/2176183007 Cr-Commit-Position: refs/heads/master@{#408124} [modify] https://crrev.com/d30b7dc473439a6b2123fd93ef88c9a2bbaef20a/third_party/WebKit/LayoutTests/TestExpectations
,
Jul 27 2016
Yeah, I don't see how this could be me, either. The code I changed isn't exercised at all.
,
Jul 27 2016
There was a rebaseline for this yesterday. +xidachen
,
Jul 27 2016
schenney@: Ah! I think I know why. In my CL that asks rebaseline here: https://codereview.chromium.org/2186553003/ I actually override the "fast/images/paint-subrect-grid-expected.png" in that CL, so the rebaseline bots doesn't update that file. As you can see here: https://codereview.chromium.org/2185923002 The rebaseline bots update linux-precise/fast/image/..., but didn't update fast/image/. I think I will just need another rebaseline, does that make sense?
,
Jul 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9a9eebeae407da92223f7fa1cc98881eb2cf27c commit a9a9eebeae407da92223f7fa1cc98881eb2cf27c Author: xidachen <xidachen@chromium.org> Date: Wed Jul 27 18:22:48 2016 Rebaseline fast/images/paint-subrect-grid.html on linux fast/images/paint-subrect-grid.html fails on Linux and is now labeled as failure. I cannot repro this failure locally with TestExpectations updated. So ask bots to rebaseline it. TBR=schenney@chromium.org BUG= 632000 Review-Url: https://codereview.chromium.org/2189623003 Cr-Commit-Position: refs/heads/master@{#408188} [modify] https://crrev.com/a9a9eebeae407da92223f7fa1cc98881eb2cf27c/third_party/WebKit/LayoutTests/TestExpectations
,
Jul 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b14b53236fe63d3b71320ac88d83f47035a9ecb7 commit b14b53236fe63d3b71320ac88d83f47035a9ecb7 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Wed Jul 27 19:56:55 2016 Auto-rebaseline for r408188 https://chromium.googlesource.com/chromium/src/+/a9a9eebea BUG= 632000 TBR=xidachen@chromium.org Review URL: https://codereview.chromium.org/2185143002 . Cr-Commit-Position: refs/heads/master@{#408220} [modify] https://crrev.com/b14b53236fe63d3b71320ac88d83f47035a9ecb7/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/b14b53236fe63d3b71320ac88d83f47035a9ecb7/third_party/WebKit/LayoutTests/platform/linux/fast/images/paint-subrect-grid-expected.png [add] https://crrev.com/b14b53236fe63d3b71320ac88d83f47035a9ecb7/third_party/WebKit/LayoutTests/platform/win/fast/images/paint-subrect-grid-expected.png
,
Jul 28 2016
,
Jul 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f47b3d8bbc9f534f4c741198c5ad9017154cc18 commit 1f47b3d8bbc9f534f4c741198c5ad9017154cc18 Author: robliao <robliao@chromium.org> Date: Thu Jul 28 00:49:59 2016 Disable fast/images/paint-subrect-grid.html on Win7 Debug and Win10 BUG= 632000 TBR=xidachen NOTRY=true Review-Url: https://codereview.chromium.org/2185103003 Cr-Commit-Position: refs/heads/master@{#408299} [modify] https://crrev.com/1f47b3d8bbc9f534f4c741198c5ad9017154cc18/third_party/WebKit/LayoutTests/TestExpectations
,
Jul 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe248e2d21e6c1852584c47e628e6b8664cc7faf commit fe248e2d21e6c1852584c47e628e6b8664cc7faf Author: xidachen <xidachen@chromium.org> Date: Thu Jul 28 19:14:01 2016 Change the expected results on win10 bots Right now fast/images/paint-subrect-grid.html fails on win10. By looking at the expected results directory, I found that win7 doesn't have expected.png for this test, which means it refers to the expected.png under win/ directory. By looking at the stdio of win7 bots, it appears that this test always pass at the first run. That means the expected.png is good for win7, but not good for win10. So in this CL, we copy the expected.png from win/ to win7/. And replace the expected.png under win/ by the actual results generated from the win10 bots. So that next time when win10 bots runs, it will refer to the actual result that itself generated, which should pass. We should closely monitor win7 and win10 bots to make sure that they are green after this change. TBR=schenney@chromium.org BUG= 632000 Review-Url: https://codereview.chromium.org/2188893003 Cr-Commit-Position: refs/heads/master@{#408450} [modify] https://crrev.com/fe248e2d21e6c1852584c47e628e6b8664cc7faf/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/fe248e2d21e6c1852584c47e628e6b8664cc7faf/third_party/WebKit/LayoutTests/platform/win/fast/images/paint-subrect-grid-expected.png [add] https://crrev.com/fe248e2d21e6c1852584c47e628e6b8664cc7faf/third_party/WebKit/LayoutTests/platform/win7/fast/images/paint-subrect-grid-expected.png
,
Jul 29 2016
schenney@: By looking at the flakiness dashboard, this test seems to be REALLY flaky from quite a white ago (definitely before the recent rebaseline). Could you take a look.
,
Jul 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c80fd8d46e04e2069f737632e7ac7d2a977d1b53 commit c80fd8d46e04e2069f737632e7ac7d2a977d1b53 Author: tapted <tapted@chromium.org> Date: Fri Jul 29 02:56:51 2016 Disable fast/images/paint-subrect-grid.html more widely on Win Flakes on more than just debug. Link https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/44524 BUG= 632000 TBR=xidachen NOTRY=true Review-Url: https://codereview.chromium.org/2197473002 Cr-Commit-Position: refs/heads/master@{#408563} [modify] https://crrev.com/c80fd8d46e04e2069f737632e7ac7d2a977d1b53/third_party/WebKit/LayoutTests/TestExpectations
,
Jul 29 2016
,
Jul 29 2016
,
Nov 29 2016
,
Mar 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fe4e4746421bf74b720dc94750d44ec62c9c2d2 commit 1fe4e4746421bf74b720dc94750d44ec62c9c2d2 Author: schenney <schenney@chromium.org> Date: Fri Mar 31 17:35:40 2017 Rebaseline images/paint-subrect-grid.html on Windows The test was once flaky but now it always fails. So try rebaseline. TBR=vmpstr@chromium.org BUG= 632000 Review-Url: https://codereview.chromium.org/2783923003 Cr-Commit-Position: refs/heads/master@{#461162} [modify] https://crrev.com/1fe4e4746421bf74b720dc94750d44ec62c9c2d2/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/ab3761497a481d8b747d3e7342e8fbe8768fef4b/third_party/WebKit/LayoutTests/platform/linux/images/paint-subrect-grid-expected.png [delete] https://crrev.com/ab3761497a481d8b747d3e7342e8fbe8768fef4b/third_party/WebKit/LayoutTests/platform/win/images/paint-subrect-grid-expected.png [delete] https://crrev.com/ab3761497a481d8b747d3e7342e8fbe8768fef4b/third_party/WebKit/LayoutTests/platform/win7/images/paint-subrect-grid-expected.png
,
Mar 31 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by vabr@chromium.org
, Jul 27 2016