New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 631976 link

Starred by 2 users
Status: Fixed
Owner:
█ bauerb@chromium.org
Not on Chrome anymore
Closed: Aug 2016
Cc:
█ rachelis@chromium.org
█ nepper@chromium.org
fi...@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Phone toolbar appears when attempting tab swipe gesture before the omnibox reaches the top

Project Member Reported by dgn@chromium.org, Jul 27 2016 
1. Open the NTP
2. Scroll down enough so that the tab indicator disappears, but stop before the fakebox reaches the top and transitions into the omnibox
3. Swipe horizontally across the top of the tab (tab swipe gesture)

Expected: nothing happens
Actual: The toobar reappears while the gesture is performed, hiding what was before underneath. The gesture properly works.

See attached demo.
demo.mp4
9.8 MB View Download

Comment 1 by bauerb@chromium.org, Jul 27 2016 

Yeah, we should probably disable swiping when the toolbar buttons are moved out of view (we already disable tapping the buttons).

Comment 2 by bauerb@chromium.org, Jul 29 2016

Labels: zine-16-08-01

Comment 3 by fi...@chromium.org, Aug 9 2016 

What's the latest status here? sounds like simple fix?

Comment 4 by fi...@chromium.org, Aug 16 2016 

ping :-)

Comment 5 by fi...@chromium.org, Aug 22 2016 

ping ping

Comment 6 by rachelis@chromium.org, Aug 22 2016

Labels: zine-ux

Comment 7 by rachelis@chromium.org, Aug 22 2016 

I agree that we should disable the swiping behavior once you scroll down, in order to be consistent with other pages.

Comment 8 by fi...@chromium.org, Aug 22 2016

Labels: -Pri-2 Pri-1

Comment 9 by fi...@chromium.org, Aug 22 2016

Labels: -zine-client-v1 -zine-ux zine-client-ux-v1 zine-triaged

Comment 10 by bauerb@chromium.org, Aug 22 2016

Labels: zine-16-08-22
Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/077a562d6d6a7b1a31a15849892eb72b0fa660c9

commit 077a562d6d6a7b1a31a15849892eb72b0fa660c9
Author: bauerb <bauerb@chromium.org>
Date: Wed Aug 24 15:22:45 2016

Ignore swipe gestures on the NTP before the omnibox expansion starts.

BUG= 631976 

Review-Url: https://codereview.chromium.org/2269993003
Cr-Commit-Position: refs/heads/master@{#414077}

[modify] https://crrev.com/077a562d6d6a7b1a31a15849892eb72b0fa660c9/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

Comment 12 by bauerb@chromium.org, Aug 25 2016

Status: Fixed (was: Started)
Fixed with https://codereview.chromium.org/2276793003/ (which Bugdroid doesn't seem to have picked up yet).
►

Sign in to add a comment